diff options
author | Stuart Menefy <stuart.menefy@st.com> | 2009-08-24 04:36:24 -0400 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2009-08-24 04:36:24 -0400 |
commit | a5cf9e2444ec15de5407696ff21c32dd21ca0a8d (patch) | |
tree | 6835770b0361cffc204d0491156a76408f03719b /arch/sh/mm | |
parent | 5e9377ec6f84e5334e9347e84e77d34e9a089ca7 (diff) |
sh: Improve comments int SH4 cache flushing code
This is a pure documentation, to try to explain why the cache flushing code
for the SH4 is implemented the way it is.
Signed-off-by: Stuart Menefy <stuart.menefy@st.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'arch/sh/mm')
-rw-r--r-- | arch/sh/mm/cache-sh4.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/arch/sh/mm/cache-sh4.c b/arch/sh/mm/cache-sh4.c index 5cfe08dbb59e..7ce816188313 100644 --- a/arch/sh/mm/cache-sh4.c +++ b/arch/sh/mm/cache-sh4.c | |||
@@ -581,6 +581,17 @@ static void __flush_cache_4096(unsigned long addr, unsigned long phys, | |||
581 | * Break the 1, 2 and 4 way variants of this out into separate functions to | 581 | * Break the 1, 2 and 4 way variants of this out into separate functions to |
582 | * avoid nearly all the overhead of having the conditional stuff in the function | 582 | * avoid nearly all the overhead of having the conditional stuff in the function |
583 | * bodies (+ the 1 and 2 way cases avoid saving any registers too). | 583 | * bodies (+ the 1 and 2 way cases avoid saving any registers too). |
584 | * | ||
585 | * We want to eliminate unnecessary bus transactions, so this code uses | ||
586 | * a non-obvious technique. | ||
587 | * | ||
588 | * Loop over a cache way sized block of, one cache line at a time. For each | ||
589 | * line, use movca.a to cause the current cache line contents to be written | ||
590 | * back, but without reading anything from main memory. However this has the | ||
591 | * side effect that the cache is now caching that memory location. So follow | ||
592 | * this with a cache invalidate to mark the cache line invalid. And do all | ||
593 | * this with interrupts disabled, to avoid the cache line being accidently | ||
594 | * evicted while it is holding garbage. | ||
584 | */ | 595 | */ |
585 | static void __flush_dcache_segment_1way(unsigned long start, | 596 | static void __flush_dcache_segment_1way(unsigned long start, |
586 | unsigned long extent_per_way) | 597 | unsigned long extent_per_way) |