diff options
author | Matt Fleming <matt@console-pimps.org> | 2009-08-28 17:37:20 -0400 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2009-08-29 07:31:44 -0400 |
commit | 4aa5ac4ef44dd8c986241c54298abd7910b78b3f (patch) | |
tree | 960cfde9c92d8d50ae04e3c6042143e101d16ae1 /arch/sh/kernel/traps_32.c | |
parent | e79d57479c86e388051244e1f17851a0e63d1ff0 (diff) |
sh: Only shout about fixing up unexpected unaligned accesses
Some unaligned accesses are completely expected. For example, the
trapped_io code uses the unaligned access fixup code path so there's no
need to warn about having to fixup the unaligned access.
Signed-off-by: Matt Fleming <matt@console-pimps.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'arch/sh/kernel/traps_32.c')
-rw-r--r-- | arch/sh/kernel/traps_32.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/arch/sh/kernel/traps_32.c b/arch/sh/kernel/traps_32.c index c581dc31d92a..583ace55b0dc 100644 --- a/arch/sh/kernel/traps_32.c +++ b/arch/sh/kernel/traps_32.c | |||
@@ -449,7 +449,7 @@ static inline int handle_delayslot(struct pt_regs *regs, | |||
449 | #define SH_PC_12BIT_OFFSET(instr) ((((signed short)(instr<<4))>>3) + 4) | 449 | #define SH_PC_12BIT_OFFSET(instr) ((((signed short)(instr<<4))>>3) + 4) |
450 | 450 | ||
451 | int handle_unaligned_access(insn_size_t instruction, struct pt_regs *regs, | 451 | int handle_unaligned_access(insn_size_t instruction, struct pt_regs *regs, |
452 | struct mem_access *ma) | 452 | struct mem_access *ma, int expected) |
453 | { | 453 | { |
454 | u_int rm; | 454 | u_int rm; |
455 | int ret, index; | 455 | int ret, index; |
@@ -458,7 +458,7 @@ int handle_unaligned_access(insn_size_t instruction, struct pt_regs *regs, | |||
458 | rm = regs->regs[index]; | 458 | rm = regs->regs[index]; |
459 | 459 | ||
460 | /* shout about fixups */ | 460 | /* shout about fixups */ |
461 | if (printk_ratelimit()) | 461 | if (!expected && printk_ratelimit()) |
462 | printk(KERN_NOTICE "Fixing up unaligned %s access " | 462 | printk(KERN_NOTICE "Fixing up unaligned %s access " |
463 | "in \"%s\" pid=%d pc=0x%p ins=0x%04hx\n", | 463 | "in \"%s\" pid=%d pc=0x%p ins=0x%04hx\n", |
464 | user_mode(regs) ? "userspace" : "kernel", | 464 | user_mode(regs) ? "userspace" : "kernel", |
@@ -657,7 +657,7 @@ fixup: | |||
657 | 657 | ||
658 | set_fs(USER_DS); | 658 | set_fs(USER_DS); |
659 | tmp = handle_unaligned_access(instruction, regs, | 659 | tmp = handle_unaligned_access(instruction, regs, |
660 | &user_mem_access); | 660 | &user_mem_access, 0); |
661 | set_fs(oldfs); | 661 | set_fs(oldfs); |
662 | 662 | ||
663 | if (tmp==0) | 663 | if (tmp==0) |
@@ -694,7 +694,8 @@ uspace_segv: | |||
694 | die("insn faulting in do_address_error", regs, 0); | 694 | die("insn faulting in do_address_error", regs, 0); |
695 | } | 695 | } |
696 | 696 | ||
697 | handle_unaligned_access(instruction, regs, &user_mem_access); | 697 | handle_unaligned_access(instruction, regs, |
698 | &user_mem_access, 0); | ||
698 | set_fs(oldfs); | 699 | set_fs(oldfs); |
699 | } | 700 | } |
700 | } | 701 | } |