diff options
author | Kulikov Vasiliy <segooon@gmail.com> | 2010-10-10 13:28:27 -0400 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2010-10-11 11:34:42 -0400 |
commit | 5a30d7bfcd33c03f1f67d3e1c317eb5d6a6bc811 (patch) | |
tree | 9d07bf81037d87311f06d2f463fa61e797e128b5 /arch/sh/boards | |
parent | 06c7a489a97fce99fd86611f6f32e565e686e5d8 (diff) |
sh: boards/mach-x3proto: gpio: fix error handling code
Checks for (irq < 0) and (ilsel < 0) didn't make sense since they were
unsigned. Made them signed.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'arch/sh/boards')
-rw-r--r-- | arch/sh/boards/mach-x3proto/gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/sh/boards/mach-x3proto/gpio.c b/arch/sh/boards/mach-x3proto/gpio.c index 9fcd7ce6aa42..594adf76e46a 100644 --- a/arch/sh/boards/mach-x3proto/gpio.c +++ b/arch/sh/boards/mach-x3proto/gpio.c | |||
@@ -79,7 +79,7 @@ struct gpio_chip x3proto_gpio_chip = { | |||
79 | 79 | ||
80 | int __init x3proto_gpio_setup(void) | 80 | int __init x3proto_gpio_setup(void) |
81 | { | 81 | { |
82 | unsigned int ilsel; | 82 | int ilsel; |
83 | int ret, i; | 83 | int ret, i; |
84 | 84 | ||
85 | ilsel = ilsel_enable(ILSEL_KEY); | 85 | ilsel = ilsel_enable(ILSEL_KEY); |
@@ -92,7 +92,7 @@ int __init x3proto_gpio_setup(void) | |||
92 | 92 | ||
93 | for (i = 0; i < NR_BASEBOARD_GPIOS; i++) { | 93 | for (i = 0; i < NR_BASEBOARD_GPIOS; i++) { |
94 | unsigned long flags; | 94 | unsigned long flags; |
95 | unsigned int irq = create_irq(); | 95 | int irq = create_irq(); |
96 | 96 | ||
97 | if (unlikely(irq < 0)) { | 97 | if (unlikely(irq < 0)) { |
98 | ret = -EINVAL; | 98 | ret = -EINVAL; |