diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-12 15:22:13 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-12 15:22:13 -0500 |
commit | 9977d9b379cb77e0f67bd6f4563618106e58e11d (patch) | |
tree | 0191accfddf578edb52c69c933d64521e3dce297 /arch/s390/kernel | |
parent | cf4af01221579a4e895f43dbfc47598fbfc5a731 (diff) | |
parent | 541880d9a2c7871f6370071d55aa6662d329c51e (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal
Pull big execve/kernel_thread/fork unification series from Al Viro:
"All architectures are converted to new model. Quite a bit of that
stuff is actually shared with architecture trees; in such cases it's
literally shared branch pulled by both, not a cherry-pick.
A lot of ugliness and black magic is gone (-3KLoC total in this one):
- kernel_thread()/kernel_execve()/sys_execve() redesign.
We don't do syscalls from kernel anymore for either kernel_thread()
or kernel_execve():
kernel_thread() is essentially clone(2) with callback run before we
return to userland, the callbacks either never return or do
successful do_execve() before returning.
kernel_execve() is a wrapper for do_execve() - it doesn't need to
do transition to user mode anymore.
As a result kernel_thread() and kernel_execve() are
arch-independent now - they live in kernel/fork.c and fs/exec.c
resp. sys_execve() is also in fs/exec.c and it's completely
architecture-independent.
- daemonize() is gone, along with its parts in fs/*.c
- struct pt_regs * is no longer passed to do_fork/copy_process/
copy_thread/do_execve/search_binary_handler/->load_binary/do_coredump.
- sys_fork()/sys_vfork()/sys_clone() unified; some architectures
still need wrappers (ones with callee-saved registers not saved in
pt_regs on syscall entry), but the main part of those suckers is in
kernel/fork.c now."
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal: (113 commits)
do_coredump(): get rid of pt_regs argument
print_fatal_signal(): get rid of pt_regs argument
ptrace_signal(): get rid of unused arguments
get rid of ptrace_signal_deliver() arguments
new helper: signal_pt_regs()
unify default ptrace_signal_deliver
flagday: kill pt_regs argument of do_fork()
death to idle_regs()
don't pass regs to copy_process()
flagday: don't pass regs to copy_thread()
bfin: switch to generic vfork, get rid of pointless wrappers
xtensa: switch to generic clone()
openrisc: switch to use of generic fork and clone
unicore32: switch to generic clone(2)
score: switch to generic fork/vfork/clone
c6x: sanitize copy_thread(), get rid of clone(2) wrapper, switch to generic clone()
take sys_fork/sys_vfork/sys_clone prototypes to linux/syscalls.h
mn10300: switch to generic fork/vfork/clone
h8300: switch to generic fork/vfork/clone
tile: switch to generic clone()
...
Conflicts:
arch/microblaze/include/asm/Kbuild
Diffstat (limited to 'arch/s390/kernel')
-rw-r--r-- | arch/s390/kernel/entry.S | 32 | ||||
-rw-r--r-- | arch/s390/kernel/entry.h | 4 | ||||
-rw-r--r-- | arch/s390/kernel/entry64.S | 26 | ||||
-rw-r--r-- | arch/s390/kernel/process.c | 53 |
4 files changed, 20 insertions, 95 deletions
diff --git a/arch/s390/kernel/entry.S b/arch/s390/kernel/entry.S index ef46f66bc0d6..aa8f2ba6289b 100644 --- a/arch/s390/kernel/entry.S +++ b/arch/s390/kernel/entry.S | |||
@@ -330,40 +330,18 @@ ENTRY(ret_from_fork) | |||
330 | la %r11,STACK_FRAME_OVERHEAD(%r15) | 330 | la %r11,STACK_FRAME_OVERHEAD(%r15) |
331 | l %r12,__LC_THREAD_INFO | 331 | l %r12,__LC_THREAD_INFO |
332 | l %r13,__LC_SVC_NEW_PSW+4 | 332 | l %r13,__LC_SVC_NEW_PSW+4 |
333 | tm __PT_PSW+1(%r11),0x01 # forking a kernel thread ? | ||
334 | je 1f | ||
335 | l %r1,BASED(.Lschedule_tail) | 333 | l %r1,BASED(.Lschedule_tail) |
336 | basr %r14,%r1 # call schedule_tail | 334 | basr %r14,%r1 # call schedule_tail |
337 | TRACE_IRQS_ON | 335 | TRACE_IRQS_ON |
338 | ssm __LC_SVC_NEW_PSW # reenable interrupts | 336 | ssm __LC_SVC_NEW_PSW # reenable interrupts |
339 | j sysc_tracenogo | 337 | tm __PT_PSW+1(%r11),0x01 # forking a kernel thread ? |
340 | 338 | jne sysc_tracenogo | |
341 | 1: # it's a kernel thread | 339 | # it's a kernel thread |
342 | st %r15,__PT_R15(%r11) # store stack pointer for new kthread | 340 | lm %r9,%r10,__PT_R9(%r11) # load gprs |
343 | l %r1,BASED(.Lschedule_tail) | ||
344 | basr %r14,%r1 # call schedule_tail | ||
345 | TRACE_IRQS_ON | ||
346 | ssm __LC_SVC_NEW_PSW # reenable interrupts | ||
347 | lm %r9,%r11,__PT_R9(%r11) # load gprs | ||
348 | ENTRY(kernel_thread_starter) | 341 | ENTRY(kernel_thread_starter) |
349 | la %r2,0(%r10) | 342 | la %r2,0(%r10) |
350 | basr %r14,%r9 | 343 | basr %r14,%r9 |
351 | la %r2,0 | 344 | j sysc_tracenogo |
352 | br %r11 # do_exit | ||
353 | |||
354 | # | ||
355 | # kernel_execve function needs to deal with pt_regs that is not | ||
356 | # at the usual place | ||
357 | # | ||
358 | ENTRY(ret_from_kernel_execve) | ||
359 | ssm __LC_PGM_NEW_PSW # disable I/O and ext. interrupts | ||
360 | lr %r15,%r2 | ||
361 | lr %r11,%r2 | ||
362 | ahi %r15,-STACK_FRAME_OVERHEAD | ||
363 | xc __SF_BACKCHAIN(4,%r15),__SF_BACKCHAIN(%r15) | ||
364 | l %r12,__LC_THREAD_INFO | ||
365 | ssm __LC_SVC_NEW_PSW # reenable interrupts | ||
366 | j sysc_return | ||
367 | 345 | ||
368 | /* | 346 | /* |
369 | * Program check handler routine | 347 | * Program check handler routine |
diff --git a/arch/s390/kernel/entry.h b/arch/s390/kernel/entry.h index d0d3f69a7346..d8251b98f17a 100644 --- a/arch/s390/kernel/entry.h +++ b/arch/s390/kernel/entry.h | |||
@@ -54,10 +54,6 @@ long sys_s390_fadvise64(int fd, u32 offset_high, u32 offset_low, | |||
54 | long sys_s390_fadvise64_64(struct fadvise64_64_args __user *args); | 54 | long sys_s390_fadvise64_64(struct fadvise64_64_args __user *args); |
55 | long sys_s390_fallocate(int fd, int mode, loff_t offset, u32 len_high, | 55 | long sys_s390_fallocate(int fd, int mode, loff_t offset, u32 len_high, |
56 | u32 len_low); | 56 | u32 len_low); |
57 | long sys_fork(void); | ||
58 | long sys_clone(unsigned long newsp, unsigned long clone_flags, | ||
59 | int __user *parent_tidptr, int __user *child_tidptr); | ||
60 | long sys_vfork(void); | ||
61 | long sys_sigsuspend(int history0, int history1, old_sigset_t mask); | 57 | long sys_sigsuspend(int history0, int history1, old_sigset_t mask); |
62 | long sys_sigaction(int sig, const struct old_sigaction __user *act, | 58 | long sys_sigaction(int sig, const struct old_sigaction __user *act, |
63 | struct old_sigaction __user *oact); | 59 | struct old_sigaction __user *oact); |
diff --git a/arch/s390/kernel/entry64.S b/arch/s390/kernel/entry64.S index 07d8de353984..499e95e90f38 100644 --- a/arch/s390/kernel/entry64.S +++ b/arch/s390/kernel/entry64.S | |||
@@ -352,33 +352,17 @@ sysc_tracenogo: | |||
352 | ENTRY(ret_from_fork) | 352 | ENTRY(ret_from_fork) |
353 | la %r11,STACK_FRAME_OVERHEAD(%r15) | 353 | la %r11,STACK_FRAME_OVERHEAD(%r15) |
354 | lg %r12,__LC_THREAD_INFO | 354 | lg %r12,__LC_THREAD_INFO |
355 | tm __PT_PSW+1(%r11),0x01 # forking a kernel thread ? | ||
356 | je 1f | ||
357 | brasl %r14,schedule_tail | 355 | brasl %r14,schedule_tail |
358 | TRACE_IRQS_ON | 356 | TRACE_IRQS_ON |
359 | ssm __LC_SVC_NEW_PSW # reenable interrupts | 357 | ssm __LC_SVC_NEW_PSW # reenable interrupts |
360 | j sysc_tracenogo | 358 | tm __PT_PSW+1(%r11),0x01 # forking a kernel thread ? |
361 | 1: # it's a kernel thread | 359 | jne sysc_tracenogo |
362 | stg %r15,__PT_R15(%r11) # store stack pointer for new kthread | 360 | # it's a kernel thread |
363 | brasl %r14,schedule_tail | 361 | lmg %r9,%r10,__PT_R9(%r11) # load gprs |
364 | TRACE_IRQS_ON | ||
365 | ssm __LC_SVC_NEW_PSW # reenable interrupts | ||
366 | lmg %r9,%r11,__PT_R9(%r11) # load gprs | ||
367 | ENTRY(kernel_thread_starter) | 362 | ENTRY(kernel_thread_starter) |
368 | la %r2,0(%r10) | 363 | la %r2,0(%r10) |
369 | basr %r14,%r9 | 364 | basr %r14,%r9 |
370 | la %r2,0 | 365 | j sysc_tracenogo |
371 | br %r11 # do_exit | ||
372 | |||
373 | ENTRY(ret_from_kernel_execve) | ||
374 | ssm __LC_PGM_NEW_PSW # disable I/O and ext. interrupts | ||
375 | lgr %r15,%r2 | ||
376 | lgr %r11,%r2 | ||
377 | aghi %r15,-STACK_FRAME_OVERHEAD | ||
378 | xc __SF_BACKCHAIN(8,%r15),__SF_BACKCHAIN(%r15) | ||
379 | lg %r12,__LC_THREAD_INFO | ||
380 | ssm __LC_SVC_NEW_PSW # reenable interrupts | ||
381 | j sysc_return | ||
382 | 366 | ||
383 | /* | 367 | /* |
384 | * Program check handler routine | 368 | * Program check handler routine |
diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c index cd31ad457a9b..536d64579d9a 100644 --- a/arch/s390/kernel/process.c +++ b/arch/s390/kernel/process.c | |||
@@ -117,8 +117,7 @@ void release_thread(struct task_struct *dead_task) | |||
117 | } | 117 | } |
118 | 118 | ||
119 | int copy_thread(unsigned long clone_flags, unsigned long new_stackp, | 119 | int copy_thread(unsigned long clone_flags, unsigned long new_stackp, |
120 | unsigned long arg, | 120 | unsigned long arg, struct task_struct *p) |
121 | struct task_struct *p, struct pt_regs *regs) | ||
122 | { | 121 | { |
123 | struct thread_info *ti; | 122 | struct thread_info *ti; |
124 | struct fake_frame | 123 | struct fake_frame |
@@ -150,7 +149,7 @@ int copy_thread(unsigned long clone_flags, unsigned long new_stackp, | |||
150 | frame->sf.gprs[9] = (unsigned long) frame; | 149 | frame->sf.gprs[9] = (unsigned long) frame; |
151 | 150 | ||
152 | /* Store access registers to kernel stack of new process. */ | 151 | /* Store access registers to kernel stack of new process. */ |
153 | if (unlikely(!regs)) { | 152 | if (unlikely(p->flags & PF_KTHREAD)) { |
154 | /* kernel thread */ | 153 | /* kernel thread */ |
155 | memset(&frame->childregs, 0, sizeof(struct pt_regs)); | 154 | memset(&frame->childregs, 0, sizeof(struct pt_regs)); |
156 | frame->childregs.psw.mask = psw_kernel_bits | PSW_MASK_DAT | | 155 | frame->childregs.psw.mask = psw_kernel_bits | PSW_MASK_DAT | |
@@ -164,9 +163,10 @@ int copy_thread(unsigned long clone_flags, unsigned long new_stackp, | |||
164 | 163 | ||
165 | return 0; | 164 | return 0; |
166 | } | 165 | } |
167 | frame->childregs = *regs; | 166 | frame->childregs = *current_pt_regs(); |
168 | frame->childregs.gprs[2] = 0; /* child returns 0 on fork. */ | 167 | frame->childregs.gprs[2] = 0; /* child returns 0 on fork. */ |
169 | frame->childregs.gprs[15] = new_stackp; | 168 | if (new_stackp) |
169 | frame->childregs.gprs[15] = new_stackp; | ||
170 | 170 | ||
171 | /* Don't copy runtime instrumentation info */ | 171 | /* Don't copy runtime instrumentation info */ |
172 | p->thread.ri_cb = NULL; | 172 | p->thread.ri_cb = NULL; |
@@ -183,57 +183,24 @@ int copy_thread(unsigned long clone_flags, unsigned long new_stackp, | |||
183 | sizeof(s390_fp_regs)); | 183 | sizeof(s390_fp_regs)); |
184 | /* Set a new TLS ? */ | 184 | /* Set a new TLS ? */ |
185 | if (clone_flags & CLONE_SETTLS) | 185 | if (clone_flags & CLONE_SETTLS) |
186 | p->thread.acrs[0] = regs->gprs[6]; | 186 | p->thread.acrs[0] = frame->childregs.gprs[6]; |
187 | #else /* CONFIG_64BIT */ | 187 | #else /* CONFIG_64BIT */ |
188 | /* Save the fpu registers to new thread structure. */ | 188 | /* Save the fpu registers to new thread structure. */ |
189 | save_fp_regs(&p->thread.fp_regs); | 189 | save_fp_regs(&p->thread.fp_regs); |
190 | /* Set a new TLS ? */ | 190 | /* Set a new TLS ? */ |
191 | if (clone_flags & CLONE_SETTLS) { | 191 | if (clone_flags & CLONE_SETTLS) { |
192 | unsigned long tls = frame->childregs.gprs[6]; | ||
192 | if (is_compat_task()) { | 193 | if (is_compat_task()) { |
193 | p->thread.acrs[0] = (unsigned int) regs->gprs[6]; | 194 | p->thread.acrs[0] = (unsigned int)tls; |
194 | } else { | 195 | } else { |
195 | p->thread.acrs[0] = (unsigned int)(regs->gprs[6] >> 32); | 196 | p->thread.acrs[0] = (unsigned int)(tls >> 32); |
196 | p->thread.acrs[1] = (unsigned int) regs->gprs[6]; | 197 | p->thread.acrs[1] = (unsigned int)tls; |
197 | } | 198 | } |
198 | } | 199 | } |
199 | #endif /* CONFIG_64BIT */ | 200 | #endif /* CONFIG_64BIT */ |
200 | return 0; | 201 | return 0; |
201 | } | 202 | } |
202 | 203 | ||
203 | SYSCALL_DEFINE0(fork) | ||
204 | { | ||
205 | struct pt_regs *regs = task_pt_regs(current); | ||
206 | return do_fork(SIGCHLD, regs->gprs[15], regs, 0, NULL, NULL); | ||
207 | } | ||
208 | |||
209 | SYSCALL_DEFINE4(clone, unsigned long, newsp, unsigned long, clone_flags, | ||
210 | int __user *, parent_tidptr, int __user *, child_tidptr) | ||
211 | { | ||
212 | struct pt_regs *regs = task_pt_regs(current); | ||
213 | |||
214 | if (!newsp) | ||
215 | newsp = regs->gprs[15]; | ||
216 | return do_fork(clone_flags, newsp, regs, 0, | ||
217 | parent_tidptr, child_tidptr); | ||
218 | } | ||
219 | |||
220 | /* | ||
221 | * This is trivial, and on the face of it looks like it | ||
222 | * could equally well be done in user mode. | ||
223 | * | ||
224 | * Not so, for quite unobvious reasons - register pressure. | ||
225 | * In user mode vfork() cannot have a stack frame, and if | ||
226 | * done by calling the "clone()" system call directly, you | ||
227 | * do not have enough call-clobbered registers to hold all | ||
228 | * the information you need. | ||
229 | */ | ||
230 | SYSCALL_DEFINE0(vfork) | ||
231 | { | ||
232 | struct pt_regs *regs = task_pt_regs(current); | ||
233 | return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, | ||
234 | regs->gprs[15], regs, 0, NULL, NULL); | ||
235 | } | ||
236 | |||
237 | asmlinkage void execve_tail(void) | 204 | asmlinkage void execve_tail(void) |
238 | { | 205 | { |
239 | current->thread.fp_regs.fpc = 0; | 206 | current->thread.fp_regs.fpc = 0; |