[PATCH] remove timer debug field

Remove timer_list.magic and associated debugging code.

I originally added this when a spinlock was added to timer_list - this meant
that an all-zeroes timer became illegal and init_timer() was required.

That spinlock isn't even there any more, although timer.base must now be
initialised.

I'll keep this debugging code in -mm.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 2 insertions, 16 deletions

diff --git a/arch/s390/kernel/vtime.c b/arch/s390/kernel/vtime.c
index fa0726507b3d..22a895ecb7a4 100644
--- a/arch/s390/kernel/vtime.c
+++ b/arch/s390/kernel/vtime.c
@@ -24,7 +24,6 @@
 #include <asm/s390_ext.h>
 #include <asm/timer.h>
 
-#define VTIMER_MAGIC (TIMER_MAGIC + 1)
 static ext_int_info_t ext_int_info_timer;
 DEFINE_PER_CPU(struct vtimer_queue, virt_cpu_timer);
 
@@ -277,20 +276,12 @@ static void do_cpu_timer_interrupt(struct pt_regs *regs, __u16 error_code)
 
 void init_virt_timer(struct vtimer_list *timer)
 {
-        timer->magic = VTIMER_MAGIC;
         timer->function = NULL;
         INIT_LIST_HEAD(&timer->entry);
         spin_lock_init(&timer->lock);
 }
 EXPORT_SYMBOL(init_virt_timer);
 
-static inline int check_vtimer(struct vtimer_list *timer)
-{
-        if (timer->magic != VTIMER_MAGIC)
-                return -EINVAL;
-        return 0;
-}
-
 static inline int vtimer_pending(struct vtimer_list *timer)
 {
         return (!list_empty(&timer->entry));
@@ -346,7 +337,7 @@ static void internal_add_vtimer(struct vtimer_list *timer)
 
 static inline int prepare_vtimer(struct vtimer_list *timer)
 {
-        if (check_vtimer(timer) || !timer->function) {
+        if (!timer->function) {
                 printk("add_virt_timer: uninitialized timer\n");
                 return -EINVAL;
         }
@@ -414,7 +405,7 @@ int mod_virt_timer(struct vtimer_list *timer, __u64 expires)
         unsigned long flags;
         int cpu;
 
-        if (check_vtimer(timer) || !timer->function) {
+        if (!timer->function) {
                 printk("mod_virt_timer: uninitialized timer\n");
                 return  -EINVAL;
         }
@@ -481,11 +472,6 @@ int del_virt_timer(struct vtimer_list *timer)
         unsigned long flags;
         struct vtimer_queue *vt_list;
 
-        if (check_vtimer(timer)) {
-                printk("del_virt_timer: timer not initialized\n");
-                return -EINVAL;
-        }
-
         /* check if timer is pending */
         if (!vtimer_pending(timer))
                 return 0;