diff options
author | Theodore Ts'o <tytso@mit.edu> | 2006-09-27 04:50:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:17 -0400 |
commit | 8e18e2941c53416aa219708e7dcad21fb4bd6794 (patch) | |
tree | 44118f8b09556193ac93e0b71aecfa3e1d4bc182 /arch/s390/hypfs/inode.c | |
parent | 6a1d9805ec506d8b9d04450997707da5f643d87c (diff) |
[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private
The following patches reduce the size of the VFS inode structure by 28 bytes
on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
in the inode size on a UP kernel that is configured in a production mode
(i.e., with no spinlock or other debugging functions enabled; if you want to
save memory taken up by in-core inodes, the first thing you should do is
disable the debugging options; they are responsible for a huge amount of bloat
in the VFS inode structure).
This patch:
The filesystem or device-specific pointer in the inode is inside a union,
which is pretty pointless given that all 30+ users of this field have been
using the void pointer. Get rid of the union and rename it to i_private, with
a comment to explain who is allowed to use the void pointer. This is just a
cleanup, but it allows us to reuse the union 'u' for something something where
the union will actually be used.
[judith@osdl.org: powerpc build fix]
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Judith Lebzelter <judith@osdl.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/s390/hypfs/inode.c')
-rw-r--r-- | arch/s390/hypfs/inode.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index bdade5f2e325..8735024d235b 100644 --- a/arch/s390/hypfs/inode.c +++ b/arch/s390/hypfs/inode.c | |||
@@ -104,13 +104,13 @@ static struct inode *hypfs_make_inode(struct super_block *sb, int mode) | |||
104 | 104 | ||
105 | static void hypfs_drop_inode(struct inode *inode) | 105 | static void hypfs_drop_inode(struct inode *inode) |
106 | { | 106 | { |
107 | kfree(inode->u.generic_ip); | 107 | kfree(inode->i_private); |
108 | generic_delete_inode(inode); | 108 | generic_delete_inode(inode); |
109 | } | 109 | } |
110 | 110 | ||
111 | static int hypfs_open(struct inode *inode, struct file *filp) | 111 | static int hypfs_open(struct inode *inode, struct file *filp) |
112 | { | 112 | { |
113 | char *data = filp->f_dentry->d_inode->u.generic_ip; | 113 | char *data = filp->f_dentry->d_inode->i_private; |
114 | struct hypfs_sb_info *fs_info; | 114 | struct hypfs_sb_info *fs_info; |
115 | 115 | ||
116 | if (filp->f_mode & FMODE_WRITE) { | 116 | if (filp->f_mode & FMODE_WRITE) { |
@@ -352,7 +352,7 @@ static struct dentry *hypfs_create_file(struct super_block *sb, | |||
352 | parent->d_inode->i_nlink++; | 352 | parent->d_inode->i_nlink++; |
353 | } else | 353 | } else |
354 | BUG(); | 354 | BUG(); |
355 | inode->u.generic_ip = data; | 355 | inode->i_private = data; |
356 | d_instantiate(dentry, inode); | 356 | d_instantiate(dentry, inode); |
357 | dget(dentry); | 357 | dget(dentry); |
358 | return dentry; | 358 | return dentry; |