[PATCH] genirq: rename desc->handler to desc->chip

This patch-queue improves the generic IRQ layer to be truly generic, by adding
various abstractions and features to it, without impacting existing
functionality.

While the queue can be best described as "fix and improve everything in the
generic IRQ layer that we could think of", and thus it consists of many
smaller features and lots of cleanups, the one feature that stands out most is
the new 'irq chip' abstraction.

The irq-chip abstraction is about describing and coding and IRQ controller
driver by mapping its raw hardware capabilities [and quirks, if needed] in a
straightforward way, without having to think about "IRQ flow"
(level/edge/etc.) type of details.

This stands in contrast with the current 'irq-type' model of genirq
architectures, which 'mixes' raw hardware capabilities with 'flow' details.
The patchset supports both types of irq controller designs at once, and
converts i386 and x86_64 to the new irq-chip design.

As a bonus side-effect of the irq-chip approach, chained interrupt controllers
(master/slave PIC constructs, etc.) are now supported by design as well.

The end result of this patchset intends to be simpler architecture-level code
and more consolidation between architectures.

We reused many bits of code and many concepts from Russell King's ARM IRQ
layer, the merging of which was one of the motivations for this patchset.

This patch:

rename desc->handler to desc->chip.

Originally i did not want to do this, because it's a big patch.  But having
both "desc->handler", "desc->handle_irq" and "action->handler" caused a
large degree of confusion and made the code appear alot less clean than it
truly is.

I have also attempted a dual approach as well by introducing a
desc->chip alias - but that just wasnt robust enough and broke
frequently.

So lets get over with this quickly.  The conversion was done automatically
via scripts and converts all the code in the kernel.

This renaming patch is the first one amongst the patches, so that the
remaining patches can stay flexible and can be merged and split up
without having some big monolithic patch act as a merge barrier.

[akpm@osdl.org: build fix]
[akpm@osdl.org: another build fix]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

15 files changed, 20 insertions, 20 deletions

diff --git a/arch/ppc/8xx_io/commproc.c b/arch/ppc/8xx_io/commproc.c
index 12b84ca51327..9b3ace26280c 100644
--- a/arch/ppc/8xx_io/commproc.c
+++ b/arch/ppc/8xx_io/commproc.c
@@ -187,7 +187,7 @@ cpm_interrupt_init(void)
          * interrupt vectors
          */
         for ( i = CPM_IRQ_OFFSET ; i < CPM_IRQ_OFFSET + NR_CPM_INTS ; i++ )
-                irq_desc[i].handler = &cpm_pic;
+                irq_desc[i].chip = &cpm_pic;
 
         /* Set our interrupt handler with the core CPU. */
         if (setup_irq(CPM_INTERRUPT, &cpm_interrupt_irqaction))
diff --git a/arch/ppc/platforms/apus_setup.c b/arch/ppc/platforms/apus_setup.c
index fe0cdc04d436..5c4118a459f3 100644
--- a/arch/ppc/platforms/apus_setup.c
+++ b/arch/ppc/platforms/apus_setup.c
@@ -734,9 +734,9 @@ void apus_init_IRQ(void)
         for ( i = 0 ; i < AMI_IRQS; i++ ) {
                 irq_desc[i].status = IRQ_LEVEL;
                 if (i < IRQ_AMIGA_AUTO) {
-                        irq_desc[i].handler = &amiga_irqctrl;
+                        irq_desc[i].chip = &amiga_irqctrl;
                 } else {
-                        irq_desc[i].handler = &amiga_sys_irqctrl;
+                        irq_desc[i].chip = &amiga_sys_irqctrl;
                         action = &amiga_sys_irqaction[i-IRQ_AMIGA_AUTO];
                         if (action->name)
                                 setup_irq(i, action);
diff --git a/arch/ppc/platforms/sbc82xx.c b/arch/ppc/platforms/sbc82xx.c
index 866807b4ad0b..41006d2b4b38 100644
--- a/arch/ppc/platforms/sbc82xx.c
+++ b/arch/ppc/platforms/sbc82xx.c
@@ -172,7 +172,7 @@ void __init sbc82xx_init_IRQ(void)
         
         /* Set up the interrupt handlers for the i8259 IRQs */
         for (i = NR_SIU_INTS; i < NR_SIU_INTS + 8; i++) {
-                irq_desc[i].handler = &sbc82xx_i8259_ic;
+                irq_desc[i].chip = &sbc82xx_i8259_ic;
                 irq_desc[i].status |= IRQ_LEVEL;
         }
 
diff --git a/arch/ppc/syslib/cpc700_pic.c b/arch/ppc/syslib/cpc700_pic.c
index 5add0a919ef6..172aa215fdb0 100644
--- a/arch/ppc/syslib/cpc700_pic.c
+++ b/arch/ppc/syslib/cpc700_pic.c
@@ -140,12 +140,12 @@ cpc700_init_IRQ(void)
                                                         /* IRQ 0 is highest */
 
         for (i = 0; i < 17; i++) {
-                irq_desc[i].handler = &cpc700_pic;
+                irq_desc[i].chip = &cpc700_pic;
                 cpc700_pic_init_irq(i);
         }
 
         for (i = 20; i < 32; i++) {
-                irq_desc[i].handler = &cpc700_pic;
+                irq_desc[i].chip = &cpc700_pic;
                 cpc700_pic_init_irq(i);
         }
 
diff --git a/arch/ppc/syslib/cpm2_pic.c b/arch/ppc/syslib/cpm2_pic.c
index 29d95d415ceb..c0fee0beb815 100644
--- a/arch/ppc/syslib/cpm2_pic.c
+++ b/arch/ppc/syslib/cpm2_pic.c
@@ -171,7 +171,7 @@ void cpm2_init_IRQ(void)
         /* Enable chaining to OpenPIC, and make everything level
          */
         for (i = 0; i < NR_CPM_INTS; i++) {
-                irq_desc[i+CPM_IRQ_OFFSET].handler = &cpm2_pic;
+                irq_desc[i+CPM_IRQ_OFFSET].chip = &cpm2_pic;
                 irq_desc[i+CPM_IRQ_OFFSET].status |= IRQ_LEVEL;
         }
 }
diff --git a/arch/ppc/syslib/gt64260_pic.c b/arch/ppc/syslib/gt64260_pic.c
index dc3bd9ecbbf6..91096b38ae70 100644
--- a/arch/ppc/syslib/gt64260_pic.c
+++ b/arch/ppc/syslib/gt64260_pic.c
@@ -98,7 +98,7 @@ gt64260_init_irq(void)
 
         /* use the gt64260 for all (possible) interrupt sources */
         for (i = gt64260_irq_base; i < (gt64260_irq_base + 96); i++)
-                irq_desc[i].handler = &gt64260_pic;
+                irq_desc[i].chip = &gt64260_pic;
 
         if (ppc_md.progress)
                 ppc_md.progress("gt64260_init_irq: exit", 0x0);
diff --git a/arch/ppc/syslib/m82xx_pci.c b/arch/ppc/syslib/m82xx_pci.c
index 1941a8c7ca9a..63fa5b313396 100644
--- a/arch/ppc/syslib/m82xx_pci.c
+++ b/arch/ppc/syslib/m82xx_pci.c
@@ -159,7 +159,7 @@ pq2pci_init_irq(void)
         immap->im_memctl.memc_or8 = 0xffff8010;
 #endif
         for (irq = NR_CPM_INTS; irq < NR_CPM_INTS + 4; irq++)
-                irq_desc[irq].handler = &pq2pci_ic;
+                irq_desc[irq].chip = &pq2pci_ic;
 
         /* make PCI IRQ level sensitive */
         immap->im_intctl.ic_siexr &=
diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c
index dae9af78bde1..0c4c0de7c59f 100644
--- a/arch/ppc/syslib/m8xx_setup.c
+++ b/arch/ppc/syslib/m8xx_setup.c
@@ -347,13 +347,13 @@ m8xx_init_IRQ(void)
         int i;
 
         for (i = SIU_IRQ_OFFSET ; i < SIU_IRQ_OFFSET + NR_SIU_INTS ; i++)
-                irq_desc[i].handler = &ppc8xx_pic;
+                irq_desc[i].chip = &ppc8xx_pic;
 
         cpm_interrupt_init();
 
 #if defined(CONFIG_PCI)
         for (i = I8259_IRQ_OFFSET ; i < I8259_IRQ_OFFSET + NR_8259_INTS ; i++)
-                irq_desc[i].handler = &i8259_pic;
+                irq_desc[i].chip = &i8259_pic;
 
         i8259_pic_irq_offset = I8259_IRQ_OFFSET;
         i8259_init(0);
diff --git a/arch/ppc/syslib/mpc52xx_pic.c b/arch/ppc/syslib/mpc52xx_pic.c
index c4406f9dc6a3..6425b5cee7db 100644
--- a/arch/ppc/syslib/mpc52xx_pic.c
+++ b/arch/ppc/syslib/mpc52xx_pic.c
@@ -204,9 +204,9 @@ mpc52xx_init_irq(void)
         out_be32(&intr->main_pri1, 0);
         out_be32(&intr->main_pri2, 0);
 
-        /* Initialize irq_desc[i].handler's with mpc52xx_ic. */
+        /* Initialize irq_desc[i].chip's with mpc52xx_ic. */
         for (i = 0; i < NR_IRQS; i++) {
-                irq_desc[i].handler = &mpc52xx_ic;
+                irq_desc[i].chip = &mpc52xx_ic;
                 irq_desc[i].status = IRQ_LEVEL;
         }
 
diff --git a/arch/ppc/syslib/mv64360_pic.c b/arch/ppc/syslib/mv64360_pic.c
index 5a19697060f0..a4244d468381 100644
--- a/arch/ppc/syslib/mv64360_pic.c
+++ b/arch/ppc/syslib/mv64360_pic.c
@@ -119,7 +119,7 @@ mv64360_init_irq(void)
         /* All interrupts are level interrupts */
         for (i = mv64360_irq_base; i < (mv64360_irq_base + 96); i++) {
                 irq_desc[i].status |= IRQ_LEVEL;
-                irq_desc[i].handler = &mv64360_pic;
+                irq_desc[i].chip = &mv64360_pic;
         }
 
         if (ppc_md.progress)
diff --git a/arch/ppc/syslib/open_pic.c b/arch/ppc/syslib/open_pic.c
index 70456c8f998c..822058c2983e 100644
--- a/arch/ppc/syslib/open_pic.c
+++ b/arch/ppc/syslib/open_pic.c
@@ -373,7 +373,7 @@ void __init openpic_init(int offset)
                                 OPENPIC_VEC_IPI+i+offset);
                 /* IPIs are per-CPU */
                 irq_desc[OPENPIC_VEC_IPI+i+offset].status |= IRQ_PER_CPU;
-                irq_desc[OPENPIC_VEC_IPI+i+offset].handler = &open_pic_ipi;
+                irq_desc[OPENPIC_VEC_IPI+i+offset].chip = &open_pic_ipi;
         }
 #endif
 
@@ -408,7 +408,7 @@ void __init openpic_init(int offset)
 
         /* Init descriptors */
         for (i = offset; i < NumSources + offset; i++)
-                irq_desc[i].handler = &open_pic;
+                irq_desc[i].chip = &open_pic;
 
         /* Initialize the spurious interrupt */
         if (ppc_md.progress) ppc_md.progress("openpic: spurious",0x3bd);
diff --git a/arch/ppc/syslib/open_pic2.c b/arch/ppc/syslib/open_pic2.c
index bcbe40de26fe..b8154efff6ed 100644
--- a/arch/ppc/syslib/open_pic2.c
+++ b/arch/ppc/syslib/open_pic2.c
@@ -290,7 +290,7 @@ void __init openpic2_init(int offset)
 
         /* Init descriptors */
         for (i = offset; i < NumSources + offset; i++)
-                irq_desc[i].handler = &open_pic2;
+                irq_desc[i].chip = &open_pic2;
 
         /* Initialize the spurious interrupt */
         if (ppc_md.progress) ppc_md.progress("openpic2: spurious",0x3bd);
diff --git a/arch/ppc/syslib/ppc403_pic.c b/arch/ppc/syslib/ppc403_pic.c
index c46043c47225..1584c8b1229f 100644
--- a/arch/ppc/syslib/ppc403_pic.c
+++ b/arch/ppc/syslib/ppc403_pic.c
@@ -121,5 +121,5 @@ ppc4xx_pic_init(void)
         ppc_md.get_irq = ppc403_pic_get_irq;
 
         for (i = 0; i < NR_IRQS; i++)
-                irq_desc[i].handler = &ppc403_aic;
+                irq_desc[i].chip = &ppc403_aic;
 }
diff --git a/arch/ppc/syslib/ppc4xx_pic.c b/arch/ppc/syslib/ppc4xx_pic.c
index fd9af0fc0e9f..e669c1335d47 100644
--- a/arch/ppc/syslib/ppc4xx_pic.c
+++ b/arch/ppc/syslib/ppc4xx_pic.c
@@ -276,7 +276,7 @@ void __init ppc4xx_pic_init(void)
 
         /* Attach low-level handlers */
         for (i = 0; i < (NR_UICS << 5); ++i) {
-                irq_desc[i].handler = &__uic[i >> 5].decl;
+                irq_desc[i].chip = &__uic[i >> 5].decl;
                 if (is_level_sensitive(i))
                         irq_desc[i].status |= IRQ_LEVEL;
         }
diff --git a/arch/ppc/syslib/xilinx_pic.c b/arch/ppc/syslib/xilinx_pic.c
index e672b600f315..39a93dc6375b 100644
--- a/arch/ppc/syslib/xilinx_pic.c
+++ b/arch/ppc/syslib/xilinx_pic.c
@@ -143,7 +143,7 @@ ppc4xx_pic_init(void)
         ppc_md.get_irq = xilinx_pic_get_irq;
 
         for (i = 0; i < NR_IRQS; ++i) {
-                irq_desc[i].handler = &xilinx_intc;
+                irq_desc[i].chip = &xilinx_intc;
 
                 if (XPAR_INTC_0_KIND_OF_INTR & (0x00000001 << i))
                         irq_desc[i].status &= ~IRQ_LEVEL;