aboutsummaryrefslogtreecommitdiffstats
path: root/arch/powerpc
diff options
context:
space:
mode:
authorSuresh E. Warrier <warrier@linux.vnet.ibm.com>2014-11-02 23:52:00 -0500
committerAlexander Graf <agraf@suse.de>2014-12-15 07:27:25 -0500
commit1bc5d59c35976d39b39b14f86abb76c08364cf97 (patch)
treea74507c75182d8e542940477be7f0c3ea7bbea17 /arch/powerpc
parentffada016fb22fbbb9849d3cc5ec72ca8f0377681 (diff)
KVM: PPC: Book3S HV: Check wait conditions before sleeping in kvmppc_vcore_blocked
The kvmppc_vcore_blocked() code does not check for the wait condition after putting the process on the wait queue. This means that it is possible for an external interrupt to become pending, but the vcpu to remain asleep until the next decrementer interrupt. The fix is to make one last check for pending exceptions and ceded state before calling schedule(). Signed-off-by: Suresh Warrier <warrier@linux.vnet.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'arch/powerpc')
-rw-r--r--arch/powerpc/kvm/book3s_hv.c20
1 files changed, 20 insertions, 0 deletions
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index cd7e030087f8..1a7a281be3bd 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -1828,9 +1828,29 @@ static void kvmppc_wait_for_exec(struct kvm_vcpu *vcpu, int wait_state)
1828 */ 1828 */
1829static void kvmppc_vcore_blocked(struct kvmppc_vcore *vc) 1829static void kvmppc_vcore_blocked(struct kvmppc_vcore *vc)
1830{ 1830{
1831 struct kvm_vcpu *vcpu;
1832 int do_sleep = 1;
1833
1831 DEFINE_WAIT(wait); 1834 DEFINE_WAIT(wait);
1832 1835
1833 prepare_to_wait(&vc->wq, &wait, TASK_INTERRUPTIBLE); 1836 prepare_to_wait(&vc->wq, &wait, TASK_INTERRUPTIBLE);
1837
1838 /*
1839 * Check one last time for pending exceptions and ceded state after
1840 * we put ourselves on the wait queue
1841 */
1842 list_for_each_entry(vcpu, &vc->runnable_threads, arch.run_list) {
1843 if (vcpu->arch.pending_exceptions || !vcpu->arch.ceded) {
1844 do_sleep = 0;
1845 break;
1846 }
1847 }
1848
1849 if (!do_sleep) {
1850 finish_wait(&vc->wq, &wait);
1851 return;
1852 }
1853
1834 vc->vcore_state = VCORE_SLEEPING; 1854 vc->vcore_state = VCORE_SLEEPING;
1835 spin_unlock(&vc->lock); 1855 spin_unlock(&vc->lock);
1836 schedule(); 1856 schedule();