diff options
author | Andy Fleming <afleming@freescale.com> | 2006-08-17 21:24:48 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-08-23 01:51:18 -0400 |
commit | ddd64159eb0d090766eee79b191a974ffdd83a42 (patch) | |
tree | 004015a1fd7b0994ad5196d8642545e55ac7e287 /arch/powerpc | |
parent | 4c86cd9c59428a40233fb707f5de18caa5ab5cb7 (diff) |
[POWERPC] Fix CDS IRQ handling and PCI code
* Fix IRQ support in the 85xx CDS boards so it uses the new
generic stuff
* Fix PCI IRQ mapping to use the device tree
* Disabled i8259 support to allow the CDS to boot. This will be
fixed soon, but the current code doesn't even compile, so this
is a vast improvement
Signed-off-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc')
-rw-r--r-- | arch/powerpc/platforms/85xx/Kconfig | 1 | ||||
-rw-r--r-- | arch/powerpc/platforms/85xx/mpc85xx_cds.c | 210 |
2 files changed, 88 insertions, 123 deletions
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 454fc53289ab..c3268d9877e4 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig | |||
@@ -14,7 +14,6 @@ config MPC8540_ADS | |||
14 | config MPC85xx_CDS | 14 | config MPC85xx_CDS |
15 | bool "Freescale MPC85xx CDS" | 15 | bool "Freescale MPC85xx CDS" |
16 | select DEFAULT_UIMAGE | 16 | select DEFAULT_UIMAGE |
17 | select PPC_I8259 if PCI | ||
18 | help | 17 | help |
19 | This option enables support for the MPC85xx CDS board | 18 | This option enables support for the MPC85xx CDS board |
20 | 19 | ||
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c index 18e6e11f7020..1d357d32a29f 100644 --- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c +++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c | |||
@@ -57,94 +57,8 @@ unsigned long isa_mem_base = 0; | |||
57 | static int cds_pci_slot = 2; | 57 | static int cds_pci_slot = 2; |
58 | static volatile u8 *cadmus; | 58 | static volatile u8 *cadmus; |
59 | 59 | ||
60 | /* | ||
61 | * Internal interrupts are all Level Sensitive, and Positive Polarity | ||
62 | * | ||
63 | * Note: Likely, this table and the following function should be | ||
64 | * obtained and derived from the OF Device Tree. | ||
65 | */ | ||
66 | static u_char mpc85xx_cds_openpic_initsenses[] __initdata = { | ||
67 | MPC85XX_INTERNAL_IRQ_SENSES, | ||
68 | #if defined(CONFIG_PCI) | ||
69 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_POSITIVE), /* Ext 0: PCI slot 0 */ | ||
70 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_NEGATIVE), /* Ext 1: PCI slot 1 */ | ||
71 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_NEGATIVE), /* Ext 2: PCI slot 2 */ | ||
72 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_NEGATIVE), /* Ext 3: PCI slot 3 */ | ||
73 | #else | ||
74 | 0x0, /* External 0: */ | ||
75 | 0x0, /* External 1: */ | ||
76 | 0x0, /* External 2: */ | ||
77 | 0x0, /* External 3: */ | ||
78 | #endif | ||
79 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_NEGATIVE), /* External 5: PHY */ | ||
80 | 0x0, /* External 6: */ | ||
81 | 0x0, /* External 7: */ | ||
82 | 0x0, /* External 8: */ | ||
83 | 0x0, /* External 9: */ | ||
84 | 0x0, /* External 10: */ | ||
85 | #ifdef CONFIG_PCI | ||
86 | (IRQ_SENSE_LEVEL | IRQ_POLARITY_NEGATIVE), /* Ext 11: PCI2 slot 0 */ | ||
87 | #else | ||
88 | 0x0, /* External 11: */ | ||
89 | #endif | ||
90 | }; | ||
91 | |||
92 | 60 | ||
93 | #ifdef CONFIG_PCI | 61 | #ifdef CONFIG_PCI |
94 | /* | ||
95 | * interrupt routing | ||
96 | */ | ||
97 | int | ||
98 | mpc85xx_map_irq(struct pci_dev *dev, unsigned char idsel, unsigned char pin) | ||
99 | { | ||
100 | struct pci_controller *hose = pci_bus_to_hose(dev->bus->number); | ||
101 | |||
102 | if (!hose->index) | ||
103 | { | ||
104 | /* Handle PCI1 interrupts */ | ||
105 | char pci_irq_table[][4] = | ||
106 | /* | ||
107 | * PCI IDSEL/INTPIN->INTLINE | ||
108 | * A B C D | ||
109 | */ | ||
110 | |||
111 | /* Note IRQ assignment for slots is based on which slot the elysium is | ||
112 | * in -- in this setup elysium is in slot #2 (this PIRQA as first | ||
113 | * interrupt on slot */ | ||
114 | { | ||
115 | { 0, 1, 2, 3 }, /* 16 - PMC */ | ||
116 | { 0, 1, 2, 3 }, /* 17 P2P (Tsi320) */ | ||
117 | { 0, 1, 2, 3 }, /* 18 - Slot 1 */ | ||
118 | { 1, 2, 3, 0 }, /* 19 - Slot 2 */ | ||
119 | { 2, 3, 0, 1 }, /* 20 - Slot 3 */ | ||
120 | { 3, 0, 1, 2 }, /* 21 - Slot 4 */ | ||
121 | }; | ||
122 | |||
123 | const long min_idsel = 16, max_idsel = 21, irqs_per_slot = 4; | ||
124 | int i, j; | ||
125 | |||
126 | for (i = 0; i < 6; i++) | ||
127 | for (j = 0; j < 4; j++) | ||
128 | pci_irq_table[i][j] = | ||
129 | ((pci_irq_table[i][j] + 5 - | ||
130 | cds_pci_slot) & 0x3) + PIRQ0A; | ||
131 | |||
132 | return PCI_IRQ_TABLE_LOOKUP; | ||
133 | } else { | ||
134 | /* Handle PCI2 interrupts (if we have one) */ | ||
135 | char pci_irq_table[][4] = | ||
136 | { | ||
137 | /* | ||
138 | * We only have one slot and one interrupt | ||
139 | * going to PIRQA - PIRQD */ | ||
140 | { PIRQ1A, PIRQ1A, PIRQ1A, PIRQ1A }, /* 21 - slot 0 */ | ||
141 | }; | ||
142 | |||
143 | const long min_idsel = 21, max_idsel = 21, irqs_per_slot = 4; | ||
144 | |||
145 | return PCI_IRQ_TABLE_LOOKUP; | ||
146 | } | ||
147 | } | ||
148 | 62 | ||
149 | #define ARCADIA_HOST_BRIDGE_IDSEL 17 | 63 | #define ARCADIA_HOST_BRIDGE_IDSEL 17 |
150 | #define ARCADIA_2ND_BRIDGE_IDSEL 3 | 64 | #define ARCADIA_2ND_BRIDGE_IDSEL 3 |
@@ -210,50 +124,104 @@ mpc85xx_cds_pcibios_fixup(void) | |||
210 | pci_write_config_byte(dev, PCI_INTERRUPT_LINE, 11); | 124 | pci_write_config_byte(dev, PCI_INTERRUPT_LINE, 11); |
211 | pci_dev_put(dev); | 125 | pci_dev_put(dev); |
212 | } | 126 | } |
127 | |||
128 | /* Now map all the PCI irqs */ | ||
129 | dev = NULL; | ||
130 | for_each_pci_dev(dev) | ||
131 | pci_read_irq_line(dev); | ||
132 | } | ||
133 | |||
134 | #ifdef CONFIG_PPC_I8259 | ||
135 | #warning The i8259 PIC support is currently broken | ||
136 | static void mpc85xx_8259_cascade(unsigned int irq, struct | ||
137 | irq_desc *desc, struct pt_regs *regs) | ||
138 | { | ||
139 | unsigned int cascade_irq = i8259_irq(regs); | ||
140 | |||
141 | if (cascade_irq != NO_IRQ) | ||
142 | generic_handle_irq(cascade_irq, regs); | ||
143 | |||
144 | desc->chip->eoi(irq); | ||
213 | } | 145 | } |
146 | #endif /* PPC_I8259 */ | ||
214 | #endif /* CONFIG_PCI */ | 147 | #endif /* CONFIG_PCI */ |
215 | 148 | ||
216 | void __init mpc85xx_cds_pic_init(void) | 149 | void __init mpc85xx_cds_pic_init(void) |
217 | { | 150 | { |
218 | struct mpic *mpic1; | 151 | struct mpic *mpic; |
219 | phys_addr_t OpenPIC_PAddr; | 152 | struct resource r; |
153 | struct device_node *np = NULL; | ||
154 | struct device_node *cascade_node = NULL; | ||
155 | int cascade_irq; | ||
220 | 156 | ||
221 | /* Determine the Physical Address of the OpenPIC regs */ | 157 | np = of_find_node_by_type(np, "open-pic"); |
222 | OpenPIC_PAddr = get_immrbase() + MPC85xx_OPENPIC_OFFSET; | 158 | |
159 | if (np == NULL) { | ||
160 | printk(KERN_ERR "Could not find open-pic node\n"); | ||
161 | return; | ||
162 | } | ||
223 | 163 | ||
224 | mpic1 = mpic_alloc(OpenPIC_PAddr, | 164 | if (of_address_to_resource(np, 0, &r)) { |
165 | printk(KERN_ERR "Failed to map mpic register space\n"); | ||
166 | of_node_put(np); | ||
167 | return; | ||
168 | } | ||
169 | |||
170 | mpic = mpic_alloc(np, r.start, | ||
225 | MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN, | 171 | MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN, |
226 | 4, MPC85xx_OPENPIC_IRQ_OFFSET, 0, 250, | 172 | 4, 0, " OpenPIC "); |
227 | mpc85xx_cds_openpic_initsenses, | 173 | BUG_ON(mpic == NULL); |
228 | sizeof(mpc85xx_cds_openpic_initsenses), " OpenPIC "); | 174 | |
229 | BUG_ON(mpic1 == NULL); | 175 | /* Return the mpic node */ |
230 | mpic_assign_isu(mpic1, 0, OpenPIC_PAddr + 0x10200); | 176 | of_node_put(np); |
231 | mpic_assign_isu(mpic1, 1, OpenPIC_PAddr + 0x10280); | 177 | |
232 | mpic_assign_isu(mpic1, 2, OpenPIC_PAddr + 0x10300); | 178 | mpic_assign_isu(mpic, 0, r.start + 0x10200); |
233 | mpic_assign_isu(mpic1, 3, OpenPIC_PAddr + 0x10380); | 179 | mpic_assign_isu(mpic, 1, r.start + 0x10280); |
234 | mpic_assign_isu(mpic1, 4, OpenPIC_PAddr + 0x10400); | 180 | mpic_assign_isu(mpic, 2, r.start + 0x10300); |
235 | mpic_assign_isu(mpic1, 5, OpenPIC_PAddr + 0x10480); | 181 | mpic_assign_isu(mpic, 3, r.start + 0x10380); |
236 | mpic_assign_isu(mpic1, 6, OpenPIC_PAddr + 0x10500); | 182 | mpic_assign_isu(mpic, 4, r.start + 0x10400); |
237 | mpic_assign_isu(mpic1, 7, OpenPIC_PAddr + 0x10580); | 183 | mpic_assign_isu(mpic, 5, r.start + 0x10480); |
238 | 184 | mpic_assign_isu(mpic, 6, r.start + 0x10500); | |
239 | /* dummy mappings to get to 48 */ | 185 | mpic_assign_isu(mpic, 7, r.start + 0x10580); |
240 | mpic_assign_isu(mpic1, 8, OpenPIC_PAddr + 0x10600); | 186 | |
241 | mpic_assign_isu(mpic1, 9, OpenPIC_PAddr + 0x10680); | 187 | /* Used only for 8548 so far, but no harm in |
242 | mpic_assign_isu(mpic1, 10, OpenPIC_PAddr + 0x10700); | 188 | * allocating them for everyone */ |
243 | mpic_assign_isu(mpic1, 11, OpenPIC_PAddr + 0x10780); | 189 | mpic_assign_isu(mpic, 8, r.start + 0x10600); |
244 | 190 | mpic_assign_isu(mpic, 9, r.start + 0x10680); | |
245 | /* External ints */ | 191 | mpic_assign_isu(mpic, 10, r.start + 0x10700); |
246 | mpic_assign_isu(mpic1, 12, OpenPIC_PAddr + 0x10000); | 192 | mpic_assign_isu(mpic, 11, r.start + 0x10780); |
247 | mpic_assign_isu(mpic1, 13, OpenPIC_PAddr + 0x10080); | 193 | |
248 | mpic_assign_isu(mpic1, 14, OpenPIC_PAddr + 0x10100); | 194 | /* External Interrupts */ |
249 | 195 | mpic_assign_isu(mpic, 12, r.start + 0x10000); | |
250 | mpic_init(mpic1); | 196 | mpic_assign_isu(mpic, 13, r.start + 0x10080); |
197 | mpic_assign_isu(mpic, 14, r.start + 0x10100); | ||
198 | |||
199 | mpic_init(mpic); | ||
200 | |||
201 | #ifdef CONFIG_PPC_I8259 | ||
202 | /* Initialize the i8259 controller */ | ||
203 | for_each_node_by_type(np, "interrupt-controller") | ||
204 | if (device_is_compatible(np, "chrp,iic")) { | ||
205 | cascade_node = np; | ||
206 | break; | ||
207 | } | ||
208 | |||
209 | if (cascade_node == NULL) { | ||
210 | printk(KERN_DEBUG "Could not find i8259 PIC\n"); | ||
211 | return; | ||
212 | } | ||
251 | 213 | ||
252 | #ifdef CONFIG_PCI | 214 | cascade_irq = irq_of_parse_and_map(cascade_node, 0); |
253 | mpic_setup_cascade(PIRQ0A, i8259_irq_cascade, NULL); | 215 | if (cascade_irq == NO_IRQ) { |
216 | printk(KERN_ERR "Failed to map cascade interrupt\n"); | ||
217 | return; | ||
218 | } | ||
254 | 219 | ||
255 | i8259_init(0,0); | 220 | i8259_init(cascade_node, 0); |
256 | #endif | 221 | of_node_put(cascade_node); |
222 | |||
223 | set_irq_chained_handler(cascade_irq, mpc85xx_8259_cascade); | ||
224 | #endif /* CONFIG_PPC_I8259 */ | ||
257 | } | 225 | } |
258 | 226 | ||
259 | 227 | ||
@@ -298,8 +266,6 @@ mpc85xx_cds_setup_arch(void) | |||
298 | add_bridge(np); | 266 | add_bridge(np); |
299 | 267 | ||
300 | ppc_md.pcibios_fixup = mpc85xx_cds_pcibios_fixup; | 268 | ppc_md.pcibios_fixup = mpc85xx_cds_pcibios_fixup; |
301 | ppc_md.pci_swizzle = common_swizzle; | ||
302 | ppc_md.pci_map_irq = mpc85xx_map_irq; | ||
303 | ppc_md.pci_exclude_device = mpc85xx_exclude_device; | 269 | ppc_md.pci_exclude_device = mpc85xx_exclude_device; |
304 | #endif | 270 | #endif |
305 | 271 | ||