diff options
author | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2013-10-07 12:48:02 -0400 |
---|---|---|
committer | Alexander Graf <agraf@suse.de> | 2013-10-17 12:43:34 -0400 |
commit | a78b55d1c0218b6d91d504941d20e36435c276f5 (patch) | |
tree | 2c9ff880ba9fd1e83cc54464e8d86b56593217f1 /arch/powerpc | |
parent | cbbc58d4fdfab1a39a6ac1b41fcb17885952157a (diff) |
kvm: powerpc: book3s: drop is_hv_enabled
drop is_hv_enabled, because that should not be a callback property
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'arch/powerpc')
-rw-r--r-- | arch/powerpc/include/asm/kvm_ppc.h | 6 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s.c | 6 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s_hv.c | 1 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s_pr.c | 1 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s_xics.c | 2 | ||||
-rw-r--r-- | arch/powerpc/kvm/powerpc.c | 2 |
6 files changed, 10 insertions, 8 deletions
diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index 3069cf4dcc88..c8317fbf92c4 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h | |||
@@ -183,7 +183,6 @@ union kvmppc_one_reg { | |||
183 | 183 | ||
184 | struct kvmppc_ops { | 184 | struct kvmppc_ops { |
185 | struct module *owner; | 185 | struct module *owner; |
186 | bool is_hv_enabled; | ||
187 | int (*get_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs); | 186 | int (*get_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs); |
188 | int (*set_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs); | 187 | int (*set_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs); |
189 | int (*get_one_reg)(struct kvm_vcpu *vcpu, u64 id, | 188 | int (*get_one_reg)(struct kvm_vcpu *vcpu, u64 id, |
@@ -232,6 +231,11 @@ struct kvmppc_ops { | |||
232 | extern struct kvmppc_ops *kvmppc_hv_ops; | 231 | extern struct kvmppc_ops *kvmppc_hv_ops; |
233 | extern struct kvmppc_ops *kvmppc_pr_ops; | 232 | extern struct kvmppc_ops *kvmppc_pr_ops; |
234 | 233 | ||
234 | static inline bool is_kvmppc_hv_enabled(struct kvm *kvm) | ||
235 | { | ||
236 | return kvm->arch.kvm_ops == kvmppc_hv_ops; | ||
237 | } | ||
238 | |||
235 | /* | 239 | /* |
236 | * Cuts out inst bits with ordering according to spec. | 240 | * Cuts out inst bits with ordering according to spec. |
237 | * That means the leftmost bit is zero. All given bits are included. | 241 | * That means the leftmost bit is zero. All given bits are included. |
diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index ad8f6ed3f136..8912608b7e1b 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c | |||
@@ -72,7 +72,7 @@ void kvmppc_core_load_guest_debugstate(struct kvm_vcpu *vcpu) | |||
72 | 72 | ||
73 | static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu) | 73 | static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu) |
74 | { | 74 | { |
75 | if (!vcpu->kvm->arch.kvm_ops->is_hv_enabled) | 75 | if (!is_kvmppc_hv_enabled(vcpu->kvm)) |
76 | return to_book3s(vcpu)->hior; | 76 | return to_book3s(vcpu)->hior; |
77 | return 0; | 77 | return 0; |
78 | } | 78 | } |
@@ -80,7 +80,7 @@ static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu) | |||
80 | static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu, | 80 | static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu, |
81 | unsigned long pending_now, unsigned long old_pending) | 81 | unsigned long pending_now, unsigned long old_pending) |
82 | { | 82 | { |
83 | if (vcpu->kvm->arch.kvm_ops->is_hv_enabled) | 83 | if (is_kvmppc_hv_enabled(vcpu->kvm)) |
84 | return; | 84 | return; |
85 | if (pending_now) | 85 | if (pending_now) |
86 | vcpu->arch.shared->int_pending = 1; | 86 | vcpu->arch.shared->int_pending = 1; |
@@ -94,7 +94,7 @@ static inline bool kvmppc_critical_section(struct kvm_vcpu *vcpu) | |||
94 | ulong crit_r1; | 94 | ulong crit_r1; |
95 | bool crit; | 95 | bool crit; |
96 | 96 | ||
97 | if (vcpu->kvm->arch.kvm_ops->is_hv_enabled) | 97 | if (is_kvmppc_hv_enabled(vcpu->kvm)) |
98 | return false; | 98 | return false; |
99 | 99 | ||
100 | crit_raw = vcpu->arch.shared->critical; | 100 | crit_raw = vcpu->arch.shared->critical; |
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 8743048881b7..072287f1c3bc 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c | |||
@@ -2160,7 +2160,6 @@ static long kvm_arch_vm_ioctl_hv(struct file *filp, | |||
2160 | } | 2160 | } |
2161 | 2161 | ||
2162 | static struct kvmppc_ops kvm_ops_hv = { | 2162 | static struct kvmppc_ops kvm_ops_hv = { |
2163 | .is_hv_enabled = true, | ||
2164 | .get_sregs = kvm_arch_vcpu_ioctl_get_sregs_hv, | 2163 | .get_sregs = kvm_arch_vcpu_ioctl_get_sregs_hv, |
2165 | .set_sregs = kvm_arch_vcpu_ioctl_set_sregs_hv, | 2164 | .set_sregs = kvm_arch_vcpu_ioctl_set_sregs_hv, |
2166 | .get_one_reg = kvmppc_get_one_reg_hv, | 2165 | .get_one_reg = kvmppc_get_one_reg_hv, |
diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c index fbd985f0cb02..df36cf2ed22b 100644 --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c | |||
@@ -1526,7 +1526,6 @@ static long kvm_arch_vm_ioctl_pr(struct file *filp, | |||
1526 | } | 1526 | } |
1527 | 1527 | ||
1528 | static struct kvmppc_ops kvm_ops_pr = { | 1528 | static struct kvmppc_ops kvm_ops_pr = { |
1529 | .is_hv_enabled = false, | ||
1530 | .get_sregs = kvm_arch_vcpu_ioctl_get_sregs_pr, | 1529 | .get_sregs = kvm_arch_vcpu_ioctl_get_sregs_pr, |
1531 | .set_sregs = kvm_arch_vcpu_ioctl_set_sregs_pr, | 1530 | .set_sregs = kvm_arch_vcpu_ioctl_set_sregs_pr, |
1532 | .get_one_reg = kvmppc_get_one_reg_pr, | 1531 | .get_one_reg = kvmppc_get_one_reg_pr, |
diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c index f7a5108a3483..02a17dcf1610 100644 --- a/arch/powerpc/kvm/book3s_xics.c +++ b/arch/powerpc/kvm/book3s_xics.c | |||
@@ -818,7 +818,7 @@ int kvmppc_xics_hcall(struct kvm_vcpu *vcpu, u32 req) | |||
818 | } | 818 | } |
819 | 819 | ||
820 | /* Check for real mode returning too hard */ | 820 | /* Check for real mode returning too hard */ |
821 | if (xics->real_mode && vcpu->kvm->arch.kvm_ops->is_hv_enabled) | 821 | if (xics->real_mode && is_kvmppc_hv_enabled(vcpu->kvm)) |
822 | return kvmppc_xics_rm_complete(vcpu, req); | 822 | return kvmppc_xics_rm_complete(vcpu, req); |
823 | 823 | ||
824 | switch (req) { | 824 | switch (req) { |
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 0320c1721caa..9ae97686e9f4 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c | |||
@@ -200,7 +200,7 @@ int kvmppc_sanity_check(struct kvm_vcpu *vcpu) | |||
200 | goto out; | 200 | goto out; |
201 | 201 | ||
202 | /* HV KVM can only do PAPR mode for now */ | 202 | /* HV KVM can only do PAPR mode for now */ |
203 | if (!vcpu->arch.papr_enabled && vcpu->kvm->arch.kvm_ops->is_hv_enabled) | 203 | if (!vcpu->arch.papr_enabled && is_kvmppc_hv_enabled(vcpu->kvm)) |
204 | goto out; | 204 | goto out; |
205 | 205 | ||
206 | #ifdef CONFIG_KVM_BOOKE_HV | 206 | #ifdef CONFIG_KVM_BOOKE_HV |