diff options
author | Michael Ellerman <michael@ellerman.id.au> | 2008-05-25 22:12:32 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2008-06-08 23:51:16 -0400 |
commit | 19fc65b5251dfd90312ae0142cc8650cd273e6a6 (patch) | |
tree | 2b61ab4405dce8bd17e76584821856ea3baabd88 /arch/powerpc/sysdev/tsi108_pci.c | |
parent | 2272a55f16c998d916904bba018b0f40f430d744 (diff) |
powerpc: Fix irq_alloc_host() reference counting and callers
When I changed irq_alloc_host() to take an of_node
(52964f87c64e6c6ea671b5bf3030fb1494090a48: "Add an optional
device_node pointer to the irq_host"), I botched the reference
counting semantics.
Stephen pointed out that it's irq_alloc_host()'s business if
it needs to take an additional reference to the device_node,
the caller shouldn't need to care.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/sysdev/tsi108_pci.c')
-rw-r--r-- | arch/powerpc/sysdev/tsi108_pci.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/powerpc/sysdev/tsi108_pci.c b/arch/powerpc/sysdev/tsi108_pci.c index ac1a72dc21e5..24e1f5a197ae 100644 --- a/arch/powerpc/sysdev/tsi108_pci.c +++ b/arch/powerpc/sysdev/tsi108_pci.c | |||
@@ -426,11 +426,10 @@ void __init tsi108_pci_int_init(struct device_node *node) | |||
426 | { | 426 | { |
427 | DBG("Tsi108_pci_int_init: initializing PCI interrupts\n"); | 427 | DBG("Tsi108_pci_int_init: initializing PCI interrupts\n"); |
428 | 428 | ||
429 | pci_irq_host = irq_alloc_host(of_node_get(node), IRQ_HOST_MAP_LEGACY, | 429 | pci_irq_host = irq_alloc_host(node, IRQ_HOST_MAP_LEGACY, |
430 | 0, &pci_irq_host_ops, 0); | 430 | 0, &pci_irq_host_ops, 0); |
431 | if (pci_irq_host == NULL) { | 431 | if (pci_irq_host == NULL) { |
432 | printk(KERN_ERR "pci_irq_host: failed to allocate irq host !\n"); | 432 | printk(KERN_ERR "pci_irq_host: failed to allocate irq host !\n"); |
433 | of_node_put(node); | ||
434 | return; | 433 | return; |
435 | } | 434 | } |
436 | 435 | ||