[PATCH] powerpc: Remove device_node addrs/n_addr

The pre-parsed addrs/n_addrs fields in struct device_node are finally
gone. Remove the dodgy heuristics that did that parsing at boot and
remove the fields themselves since we now have a good replacement with
the new OF parsing code. This patch also fixes a bunch of drivers to use
the new code instead, so that at least pmac32, pseries, iseries and g5
defconfigs build.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

7 files changed, 381 insertions, 313 deletions

diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index b2928bbe9227..b1f896952b1b 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -1445,20 +1445,55 @@ static long g5_i2s_enable(struct device_node *node, long param, long value)
         /* Very crude implementation for now */
         struct macio_chip *macio = &macio_chips[0];
         unsigned long flags;
-
-        if (value == 0)
-                return 0; /* don't disable yet */
+        int cell;
+        u32 fcrs[3][3] = {
+                { 0,
+                  K2_FCR1_I2S0_CELL_ENABLE |
+                  K2_FCR1_I2S0_CLK_ENABLE_BIT | K2_FCR1_I2S0_ENABLE,
+                  KL3_I2S0_CLK18_ENABLE
+                },
+                { KL0_SCC_A_INTF_ENABLE,
+                  K2_FCR1_I2S1_CELL_ENABLE |
+                  K2_FCR1_I2S1_CLK_ENABLE_BIT | K2_FCR1_I2S1_ENABLE,
+                  KL3_I2S1_CLK18_ENABLE
+                },
+                { KL0_SCC_B_INTF_ENABLE,
+                  SH_FCR1_I2S2_CELL_ENABLE |
+                  SH_FCR1_I2S2_CLK_ENABLE_BIT | SH_FCR1_I2S2_ENABLE,
+                  SH_FCR3_I2S2_CLK18_ENABLE
+                },
+        };
+
+        if (macio->type != macio_keylargo2 /* && macio->type != macio_shasta*/)
+                return -ENODEV;
+        if (strncmp(node->name, "i2s-", 4))
+                return -ENODEV;
+        cell = node->name[4] - 'a';
+        switch(cell) {
+        case 0:
+        case 1:
+                break;
+#if 0
+        case 2:
+                if (macio->type == macio_shasta)
+                        break;
+#endif
+        default:
+                return -ENODEV;
+        }
 
         LOCK(flags);
-        MACIO_BIS(KEYLARGO_FCR3, KL3_CLK45_ENABLE | KL3_CLK49_ENABLE |
-                  KL3_I2S0_CLK18_ENABLE);
-        udelay(10);
-        MACIO_BIS(KEYLARGO_FCR1, K2_FCR1_I2S0_CELL_ENABLE |
-                  K2_FCR1_I2S0_CLK_ENABLE_BIT | K2_FCR1_I2S0_ENABLE);
+        if (value) {
+                MACIO_BIC(KEYLARGO_FCR0, fcrs[cell][0]);
+                MACIO_BIS(KEYLARGO_FCR1, fcrs[cell][1]);
+                MACIO_BIS(KEYLARGO_FCR3, fcrs[cell][2]);
+        } else {
+                MACIO_BIC(KEYLARGO_FCR3, fcrs[cell][2]);
+                MACIO_BIC(KEYLARGO_FCR1, fcrs[cell][1]);
+                MACIO_BIS(KEYLARGO_FCR0, fcrs[cell][0]);
+        }
         udelay(10);
-        MACIO_BIC(KEYLARGO_FCR1, K2_FCR1_I2S0_RESET);
         UNLOCK(flags);
-        udelay(10);
 
         return 0;
 }
@@ -2960,26 +2995,6 @@ pmac_feature_init(void)
         set_initial_features();
 }
 
-int __init pmac_feature_late_init(void)
-{
-#if 0
-        struct device_node *np;
-
-        /* Request some resources late */
-        if (uninorth_node)
-                request_OF_resource(uninorth_node, 0, NULL);
-        np = find_devices("hammerhead");
-        if (np)
-                request_OF_resource(np, 0, NULL);
-        np = find_devices("interrupt-controller");
-        if (np)
-                request_OF_resource(np, 0, NULL);
-#endif
-        return 0;
-}
-
-device_initcall(pmac_feature_late_init);
-
 #if 0
 static void dump_HT_speeds(char *name, u32 cfg, u32 frq)
 {
diff --git a/arch/powerpc/platforms/powermac/nvram.c b/arch/powerpc/platforms/powermac/nvram.c
index 59e0e51cf663..3ebd045a3350 100644
--- a/arch/powerpc/platforms/powermac/nvram.c
+++ b/arch/powerpc/platforms/powermac/nvram.c
@@ -514,7 +514,7 @@ static void core99_nvram_sync(void)
 #endif
 }
 
-static int __init core99_nvram_setup(struct device_node *dp)
+static int __init core99_nvram_setup(struct device_node *dp, unsigned long addr)
 {
         int i;
         u32 gen_bank0, gen_bank1;
@@ -528,7 +528,7 @@ static int __init core99_nvram_setup(struct device_node *dp)
                 printk(KERN_ERR "nvram: can't allocate ram image\n");
                 return -ENOMEM;
         }
-        nvram_data = ioremap(dp->addrs[0].address, NVRAM_SIZE*2);
+        nvram_data = ioremap(addr, NVRAM_SIZE*2);
         nvram_naddrs = 1; /* Make sure we get the correct case */
 
         DBG("nvram: Checking bank 0...\n");
@@ -570,34 +570,48 @@ static int __init core99_nvram_setup(struct device_node *dp)
 int __init pmac_nvram_init(void)
 {
         struct device_node *dp;
+        struct resource r1, r2;
+        unsigned int s1 = 0, s2 = 0;
         int err = 0;
 
         nvram_naddrs = 0;
 
-        dp = find_devices("nvram");
+        dp = of_find_node_by_name(NULL, "nvram");
         if (dp == NULL) {
                 printk(KERN_ERR "Can't find NVRAM device\n");
                 return -ENODEV;
         }
-        nvram_naddrs = dp->n_addrs;
+
+        /* Try to obtain an address */
+        if (of_address_to_resource(dp, 0, &r1) == 0) {
+                nvram_naddrs = 1;
+                s1 = (r1.end - r1.start) + 1;
+                if (of_address_to_resource(dp, 1, &r2) == 0) {
+                        nvram_naddrs = 2;
+                        s2 = (r2.end - r2.start) + 1;
+                }
+        }
+
         is_core_99 = device_is_compatible(dp, "nvram,flash");
-        if (is_core_99)
-                err = core99_nvram_setup(dp);
+        if (is_core_99) {
+                err = core99_nvram_setup(dp, r1.start);
+                goto bail;
+        }
+
 #ifdef CONFIG_PPC32
-        else if (_machine == _MACH_chrp && nvram_naddrs == 1) {
-                nvram_data = ioremap(dp->addrs[0].address + isa_mem_base,
-                                     dp->addrs[0].size);
+        if (_machine == _MACH_chrp && nvram_naddrs == 1) {
+                nvram_data = ioremap(r1.start, s1);
                 nvram_mult = 1;
                 ppc_md.nvram_read_val   = direct_nvram_read_byte;
                 ppc_md.nvram_write_val  = direct_nvram_write_byte;
         } else if (nvram_naddrs == 1) {
-                nvram_data = ioremap(dp->addrs[0].address, dp->addrs[0].size);
-                nvram_mult = (dp->addrs[0].size + NVRAM_SIZE - 1) / NVRAM_SIZE;
+                nvram_data = ioremap(r1.start, s1);
+                nvram_mult = (s1 + NVRAM_SIZE - 1) / NVRAM_SIZE;
                 ppc_md.nvram_read_val   = direct_nvram_read_byte;
                 ppc_md.nvram_write_val  = direct_nvram_write_byte;
         } else if (nvram_naddrs == 2) {
-                nvram_addr = ioremap(dp->addrs[0].address, dp->addrs[0].size);
-                nvram_data = ioremap(dp->addrs[1].address, dp->addrs[1].size);
+                nvram_addr = ioremap(r1.start, s1);
+                nvram_data = ioremap(r2.start, s2);
                 ppc_md.nvram_read_val   = indirect_nvram_read_byte;
                 ppc_md.nvram_write_val  = indirect_nvram_write_byte;
         } else if (nvram_naddrs == 0 && sys_ctrler == SYS_CTRLER_PMU) {
@@ -606,13 +620,15 @@ int __init pmac_nvram_init(void)
                 ppc_md.nvram_read_val   = pmu_nvram_read_byte;
                 ppc_md.nvram_write_val  = pmu_nvram_write_byte;
 #endif /* CONFIG_ADB_PMU */
-        }
-#endif
-        else {
+        } else {
                 printk(KERN_ERR "Incompatible type of NVRAM\n");
-                return -ENXIO;
+                err = -ENXIO;
         }
-        lookup_partitions();
+#endif /* CONFIG_PPC32 */
+bail:
+        of_node_put(dp);
+        if (err == 0)
+                lookup_partitions();
         return err;
 }
 
diff --git a/arch/powerpc/platforms/powermac/pci.c b/arch/powerpc/platforms/powermac/pci.c
index e0b66f55a5f8..5aab261075de 100644
--- a/arch/powerpc/platforms/powermac/pci.c
+++ b/arch/powerpc/platforms/powermac/pci.c
@@ -285,15 +285,13 @@ static struct pci_ops chaos_pci_ops =
 };
 
 static void __init setup_chaos(struct pci_controller *hose,
-                               struct reg_property *addr)
+                               struct resource *addr)
 {
         /* assume a `chaos' bridge */
         hose->ops = &chaos_pci_ops;
-        hose->cfg_addr = ioremap(addr->address + 0x800000, 0x1000);
-        hose->cfg_data = ioremap(addr->address + 0xc00000, 0x1000);
+        hose->cfg_addr = ioremap(addr->start + 0x800000, 0x1000);
+        hose->cfg_data = ioremap(addr->start + 0xc00000, 0x1000);
 }
-#else
-#define setup_chaos(hose, addr)
 #endif /* CONFIG_PPC32 */
 
 #ifdef CONFIG_PPC64
@@ -356,9 +354,11 @@ static unsigned long u3_ht_cfg_access(struct pci_controller* hose,
                 /* For now, we don't self probe U3 HT bridge */
                 if (PCI_SLOT(devfn) == 0)
                         return 0;
-                return ((unsigned long)hose->cfg_data) + U3_HT_CFA0(devfn, offset);
+                return ((unsigned long)hose->cfg_data) +
+                        U3_HT_CFA0(devfn, offset);
         } else
-                return ((unsigned long)hose->cfg_data) + U3_HT_CFA1(bus, devfn, offset);
+                return ((unsigned long)hose->cfg_data) +
+                        U3_HT_CFA1(bus, devfn, offset);
 }
 
 static int u3_ht_read_config(struct pci_bus *bus, unsigned int devfn,
@@ -532,7 +532,8 @@ static void __init init_p2pbridge(void)
         }
         if (early_read_config_word(hose, bus, devfn,
                                    PCI_BRIDGE_CONTROL, &val) < 0) {
-                printk(KERN_ERR "init_p2pbridge: couldn't read bridge control\n");
+                printk(KERN_ERR "init_p2pbridge: couldn't read bridge"
+                       " control\n");
                 return;
         }
         val &= ~PCI_BRIDGE_CTL_MASTER_ABORT;
@@ -576,36 +577,38 @@ static void __init fixup_nec_usb2(void)
                         continue;
                 early_read_config_dword(hose, bus, devfn, 0xe4, &data);
                 if (data & 1UL) {
-                        printk("Found NEC PD720100A USB2 chip with disabled EHCI, fixing up...\n");
+                        printk("Found NEC PD720100A USB2 chip with disabled"
+                               " EHCI, fixing up...\n");
                         data &= ~1UL;
                         early_write_config_dword(hose, bus, devfn, 0xe4, data);
-                        early_write_config_byte(hose, bus, devfn | 2, PCI_INTERRUPT_LINE,
+                        early_write_config_byte(hose, bus,
+                                                devfn | 2, PCI_INTERRUPT_LINE,
                                 nec->intrs[0].line);
                 }
         }
 }
 
 static void __init setup_bandit(struct pci_controller *hose,
-                                struct reg_property *addr)
+                                struct resource *addr)
 {
         hose->ops = &macrisc_pci_ops;
-        hose->cfg_addr = ioremap(addr->address + 0x800000, 0x1000);
-        hose->cfg_data = ioremap(addr->address + 0xc00000, 0x1000);
+        hose->cfg_addr = ioremap(addr->start + 0x800000, 0x1000);
+        hose->cfg_data = ioremap(addr->start + 0xc00000, 0x1000);
         init_bandit(hose);
 }
 
 static int __init setup_uninorth(struct pci_controller *hose,
-                                 struct reg_property *addr)
+                                 struct resource *addr)
 {
         pci_assign_all_buses = 1;
         has_uninorth = 1;
         hose->ops = &macrisc_pci_ops;
-        hose->cfg_addr = ioremap(addr->address + 0x800000, 0x1000);
-        hose->cfg_data = ioremap(addr->address + 0xc00000, 0x1000);
+        hose->cfg_addr = ioremap(addr->start + 0x800000, 0x1000);
+        hose->cfg_data = ioremap(addr->start + 0xc00000, 0x1000);
         /* We "know" that the bridge at f2000000 has the PCI slots. */
-        return addr->address == 0xf2000000;
+        return addr->start == 0xf2000000;
 }
-#endif
+#endif /* CONFIG_PPC32 */
 
 #ifdef CONFIG_PPC64
 static void __init setup_u3_agp(struct pci_controller* hose)
@@ -722,7 +725,7 @@ static void __init setup_u3_ht(struct pci_controller* hose)
                 hose->mem_resources[cur-1].end = res->start - 1;
         }
 }
-#endif
+#endif /* CONFIG_PPC64 */
 
 /*
  * We assume that if we have a G3 powermac, we have one bridge called
@@ -733,24 +736,17 @@ static int __init add_bridge(struct device_node *dev)
 {
         int len;
         struct pci_controller *hose;
-#ifdef CONFIG_PPC32
-        struct reg_property *addr;
-#endif
+        struct resource rsrc;
         char *disp_name;
         int *bus_range;
-        int primary = 1;
+        int primary = 1, has_address = 0;
 
         DBG("Adding PCI host bridge %s\n", dev->full_name);
 
-#ifdef CONFIG_PPC32
-        /* XXX fix this */
-        addr = (struct reg_property *) get_property(dev, "reg", &len);
-        if (addr == NULL || len < sizeof(*addr)) {
-                printk(KERN_WARNING "Can't use %s: no address\n",
-                       dev->full_name);
-                return -ENODEV;
-        }
-#endif
+        /* Fetch host bridge registers address */
+        has_address = (of_address_to_resource(dev, 0, &rsrc) == 0);
+
+        /* Get bus range if any */
         bus_range = (int *) get_property(dev, "bus-range", &len);
         if (bus_range == NULL || len < 2 * sizeof(int)) {
                 printk(KERN_WARNING "Can't get bus-range for %s, assume"
@@ -770,6 +766,8 @@ static int __init add_bridge(struct device_node *dev)
         hose->last_busno = bus_range ? bus_range[1] : 0xff;
 
         disp_name = NULL;
+
+        /* 64 bits only bridges */
 #ifdef CONFIG_PPC64
         if (device_is_compatible(dev, "u3-agp")) {
                 setup_u3_agp(hose);
@@ -782,25 +780,30 @@ static int __init add_bridge(struct device_node *dev)
         }
         printk(KERN_INFO "Found %s PCI host bridge.  Firmware bus number: %d->%d\n",
                 disp_name, hose->first_busno, hose->last_busno);
-#else
+#endif /* CONFIG_PPC64 */
+
+        /* 32 bits only bridges */
+#ifdef CONFIG_PPC32
         if (device_is_compatible(dev, "uni-north")) {
-                primary = setup_uninorth(hose, addr);
+                primary = setup_uninorth(hose, &rsrc);
                 disp_name = "UniNorth";
         } else if (strcmp(dev->name, "pci") == 0) {
                 /* XXX assume this is a mpc106 (grackle) */
                 setup_grackle(hose);
                 disp_name = "Grackle (MPC106)";
         } else if (strcmp(dev->name, "bandit") == 0) {
-                setup_bandit(hose, addr);
+                setup_bandit(hose, &rsrc);
                 disp_name = "Bandit";
         } else if (strcmp(dev->name, "chaos") == 0) {
-                setup_chaos(hose, addr);
+                setup_chaos(hose, &rsrc);
                 disp_name = "Chaos";
                 primary = 0;
         }
-        printk(KERN_INFO "Found %s PCI host bridge at 0x%08lx. Firmware bus number: %d->%d\n",
-                disp_name, addr->address, hose->first_busno, hose->last_busno);
-#endif
+        printk(KERN_INFO "Found %s PCI host bridge at 0x%08lx. "
+               "Firmware bus number: %d->%d\n",
+                disp_name, rsrc.start, hose->first_busno, hose->last_busno);
+#endif /* CONFIG_PPC32 */
+
         DBG(" ->Hose at 0x%p, cfg_addr=0x%p,cfg_data=0x%p\n",
                 hose, hose->cfg_addr, hose->cfg_data);
 
@@ -814,8 +817,7 @@ static int __init add_bridge(struct device_node *dev)
         return 0;
 }
 
-static void __init
-pcibios_fixup_OF_interrupts(void)
+static void __init pcibios_fixup_OF_interrupts(void)
 {
         struct pci_dev* dev = NULL;
 
@@ -835,8 +837,7 @@ pcibios_fixup_OF_interrupts(void)
         }
 }
 
-void __init
-pmac_pcibios_fixup(void)
+void __init pmac_pcibios_fixup(void)
 {
         /* Fixup interrupts according to OF tree */
         pcibios_fixup_OF_interrupts();
diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index a36527c98133..dbb524a851aa 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -5,8 +5,8 @@
  *  in a separate file
  *
  *  Copyright (C) 1997 Paul Mackerras (paulus@samba.org)
- *
- *  Maintained by Benjamin Herrenschmidt (benh@kernel.crashing.org)
+ *  Copyright (C) 2005 Benjamin Herrenschmidt (benh@kernel.crashing.org)
+ *                     IBM, Corp.
  *
  *  This program is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU General Public License
@@ -54,12 +54,7 @@ struct pmac_irq_hw {
 };
 
 /* Default addresses */
-static volatile struct pmac_irq_hw *pmac_irq_hw[4] = {
-        (struct pmac_irq_hw *) 0xf3000020,
-        (struct pmac_irq_hw *) 0xf3000010,
-        (struct pmac_irq_hw *) 0xf4000020,
-        (struct pmac_irq_hw *) 0xf4000010,
-};
+static volatile struct pmac_irq_hw __iomem *pmac_irq_hw[4];
 
 #define GC_LEVEL_MASK           0x3ff00000
 #define OHARE_LEVEL_MASK        0x1ff00000
@@ -82,8 +77,7 @@ static unsigned long ppc_lost_interrupts[NR_MASK_WORDS];
  * since it can lose interrupts (see pmac_set_irq_mask).
  * -- Cort
  */
-void
-__set_lost(unsigned long irq_nr, int nokick)
+void __set_lost(unsigned long irq_nr, int nokick)
 {
         if (!test_and_set_bit(irq_nr, ppc_lost_interrupts)) {
                 atomic_inc(&ppc_n_lost_interrupts);
@@ -92,8 +86,7 @@ __set_lost(unsigned long irq_nr, int nokick)
         }
 }
 
-static void
-pmac_mask_and_ack_irq(unsigned int irq_nr)
+static void pmac_mask_and_ack_irq(unsigned int irq_nr)
 {
         unsigned long bit = 1UL << (irq_nr & 0x1f);
         int i = irq_nr >> 5;
@@ -224,8 +217,7 @@ static irqreturn_t gatwick_action(int cpl, void *dev_id, struct pt_regs *regs)
         return IRQ_NONE;
 }
 
-int
-pmac_get_irq(struct pt_regs *regs)
+static int pmac_get_irq(struct pt_regs *regs)
 {
         int irq;
         unsigned long bits = 0;
@@ -256,34 +248,40 @@ pmac_get_irq(struct pt_regs *regs)
 
 /* This routine will fix some missing interrupt values in the device tree
  * on the gatwick mac-io controller used by some PowerBooks
+ *
+ * Walking of OF nodes could use a bit more fixing up here, but it's not
+ * very important as this is all boot time code on static portions of the
+ * device-tree.
+ *
+ * However, the modifications done to "intrs" will have to be removed and
+ * replaced with proper updates of the "interrupts" properties or
+ * AAPL,interrupts, yet to be decided, once the dynamic parsing is there.
  */
-static void __init
-pmac_fix_gatwick_interrupts(struct device_node *gw, int irq_base)
+static void __init pmac_fix_gatwick_interrupts(struct device_node *gw,
+                                               int irq_base)
 {
         struct device_node *node;
         int count;
 
         memset(gatwick_int_pool, 0, sizeof(gatwick_int_pool));
-        node = gw->child;
         count = 0;
-        while(node)
-        {
+        for (node = NULL; (node = of_get_next_child(gw, node)) != NULL;) {
                 /* Fix SCC */
-                if (strcasecmp(node->name, "escc") == 0)
-                        if (node->child) {
-                                if (node->child->n_intrs < 3) {
-                                        node->child->intrs = &gatwick_int_pool[count];
-                                        count += 3;
-                                }
-                                node->child->n_intrs = 3;
-                                node->child->intrs[0].line = 15+irq_base;
-                                node->child->intrs[1].line =  4+irq_base;
-                                node->child->intrs[2].line =  5+irq_base;
-                                printk(KERN_INFO "irq: fixed SCC on second controller (%d,%d,%d)\n",
-                                        node->child->intrs[0].line,
-                                        node->child->intrs[1].line,
-                                        node->child->intrs[2].line);
+                if ((strcasecmp(node->name, "escc") == 0) && node->child) {
+                        if (node->child->n_intrs < 3) {
+                                node->child->intrs = &gatwick_int_pool[count];
+                                count += 3;
                         }
+                        node->child->n_intrs = 3;
+                        node->child->intrs[0].line = 15+irq_base;
+                        node->child->intrs[1].line =  4+irq_base;
+                        node->child->intrs[2].line =  5+irq_base;
+                        printk(KERN_INFO "irq: fixed SCC on gatwick"
+                               " (%d,%d,%d)\n",
+                               node->child->intrs[0].line,
+                               node->child->intrs[1].line,
+                               node->child->intrs[2].line);
+                }
                 /* Fix media-bay & left SWIM */
                 if (strcasecmp(node->name, "media-bay") == 0) {
                         struct device_node* ya_node;
@@ -292,12 +290,11 @@ pmac_fix_gatwick_interrupts(struct device_node *gw, int irq_base)
                                 node->intrs = &gatwick_int_pool[count++];
                         node->n_intrs = 1;
                         node->intrs[0].line = 29+irq_base;
-                        printk(KERN_INFO "irq: fixed media-bay on second controller (%d)\n",
-                                        node->intrs[0].line);
+                        printk(KERN_INFO "irq: fixed media-bay on gatwick"
+                               " (%d)\n", node->intrs[0].line);
 
                         ya_node = node->child;
-                        while(ya_node)
-                        {
+                        while(ya_node) {
                                 if (strcasecmp(ya_node->name, "floppy") == 0) {
                                         if (ya_node->n_intrs < 2) {
                                                 ya_node->intrs = &gatwick_int_pool[count];
@@ -323,7 +320,6 @@ pmac_fix_gatwick_interrupts(struct device_node *gw, int irq_base)
                                 ya_node = ya_node->sibling;
                         }
                 }
-                node = node->sibling;
         }
         if (count > 10) {
                 printk("WARNING !! Gatwick interrupt pool overflow\n");
@@ -338,45 +334,41 @@ pmac_fix_gatwick_interrupts(struct device_node *gw, int irq_base)
  * controller.  If we find this second ohare, set it up and fix the
  * interrupt value in the device tree for the ethernet chip.
  */
-static int __init enable_second_ohare(void)
+static void __init enable_second_ohare(struct device_node *np)
 {
         unsigned char bus, devfn;
         unsigned short cmd;
-        unsigned long addr;
-        struct device_node *irqctrler = find_devices("pci106b,7");
         struct device_node *ether;
 
-        if (irqctrler == NULL || irqctrler->n_addrs <= 0)
-                return -1;
-        addr = (unsigned long) ioremap(irqctrler->addrs[0].address, 0x40);
-        pmac_irq_hw[1] = (volatile struct pmac_irq_hw *)(addr + 0x20);
-        max_irqs = 64;
-        if (pci_device_from_OF_node(irqctrler, &bus, &devfn) == 0) {
-                struct pci_controller* hose = pci_find_hose_for_OF_device(irqctrler);
-                if (!hose)
-                    printk(KERN_ERR "Can't find PCI hose for OHare2 !\n");
-                else {
-                    early_read_config_word(hose, bus, devfn, PCI_COMMAND, &cmd);
-                    cmd |= PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER;
-                    cmd &= ~PCI_COMMAND_IO;
-                    early_write_config_word(hose, bus, devfn, PCI_COMMAND, cmd);
+        /* This code doesn't strictly belong here, it could be part of
+         * either the PCI initialisation or the feature code. It's kept
+         * here for historical reasons.
+         */
+        if (pci_device_from_OF_node(np, &bus, &devfn) == 0) {
+                struct pci_controller* hose =
+                        pci_find_hose_for_OF_device(np);
+                if (!hose) {
+                        printk(KERN_ERR "Can't find PCI hose for OHare2 !\n");
+                        return;
                 }
+                early_read_config_word(hose, bus, devfn, PCI_COMMAND, &cmd);
+                cmd |= PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER;
+                cmd &= ~PCI_COMMAND_IO;
+                early_write_config_word(hose, bus, devfn, PCI_COMMAND, cmd);
         }
 
         /* Fix interrupt for the modem/ethernet combo controller. The number
-           in the device tree (27) is bogus (correct for the ethernet-only
-           board but not the combo ethernet/modem board).
-           The real interrupt is 28 on the second controller -> 28+32 = 60.
-        */
-        ether = find_devices("pci1011,14");
+         * in the device tree (27) is bogus (correct for the ethernet-only
+         * board but not the combo ethernet/modem board).
+         * The real interrupt is 28 on the second controller -> 28+32 = 60.
+         */
+        ether = of_find_node_by_name(NULL, "pci1011,14");
         if (ether && ether->n_intrs > 0) {
                 ether->intrs[0].line = 60;
                 printk(KERN_INFO "irq: Fixed ethernet IRQ to %d\n",
                        ether->intrs[0].line);
         }
-
-        /* Return the interrupt number of the cascade */
-        return irqctrler->intrs[0].line;
+        of_node_put(ether);
 }
 
 #ifdef CONFIG_XMON
@@ -394,189 +386,233 @@ static struct irqaction gatwick_cascade_action = {
         .mask           = CPU_MASK_NONE,
         .name           = "cascade",
 };
-#endif /* CONFIG_PPC32 */
 
-static int pmac_u3_cascade(struct pt_regs *regs, void *data)
+static void __init pmac_pic_probe_oldstyle(void)
 {
-        return mpic_get_one_irq((struct mpic *)data, regs);
-}
-
-void __init pmac_pic_init(void)
-{
-        struct device_node *irqctrler  = NULL;
-        struct device_node *irqctrler2 = NULL;
-        struct device_node *np;
-#ifdef CONFIG_PPC32
         int i;
-        unsigned long addr;
         int irq_cascade = -1;
-#endif
-        struct mpic *mpic1, *mpic2;
+        struct device_node *master = NULL;
+        struct device_node *slave = NULL;
+        u8 __iomem *addr;
+        struct resource r;
 
-        /* We first try to detect Apple's new Core99 chipset, since mac-io
-         * is quite different on those machines and contains an IBM MPIC2.
-         */
-        np = find_type_devices("open-pic");
-        while (np) {
-                if (np->parent && !strcmp(np->parent->name, "u3"))
-                        irqctrler2 = np;
-                else
-                        irqctrler = np;
-                np = np->next;
-        }
-        if (irqctrler != NULL && irqctrler->n_addrs > 0) {
-                unsigned char senses[128];
-
-                printk(KERN_INFO "PowerMac using OpenPIC irq controller at 0x%08x\n",
-                       (unsigned int)irqctrler->addrs[0].address);
-                pmac_call_feature(PMAC_FTR_ENABLE_MPIC, irqctrler, 0, 0);
-
-                prom_get_irq_senses(senses, 0, 128);
-                mpic1 = mpic_alloc(irqctrler->addrs[0].address,
-                                   MPIC_PRIMARY | MPIC_WANTS_RESET,
-                                   0, 0, 128, 252, senses, 128, " OpenPIC  ");
-                BUG_ON(mpic1 == NULL);
-                mpic_init(mpic1);               
-
-                if (irqctrler2 != NULL && irqctrler2->n_intrs > 0 &&
-                    irqctrler2->n_addrs > 0) {
-                        printk(KERN_INFO "Slave OpenPIC at 0x%08x hooked on IRQ %d\n",
-                               (u32)irqctrler2->addrs[0].address,
-                               irqctrler2->intrs[0].line);
-
-                        pmac_call_feature(PMAC_FTR_ENABLE_MPIC, irqctrler2, 0, 0);
-                        prom_get_irq_senses(senses, 128, 128 + 124);
-
-                        /* We don't need to set MPIC_BROKEN_U3 here since we don't have
-                         * hypertransport interrupts routed to it
-                         */
-                        mpic2 = mpic_alloc(irqctrler2->addrs[0].address,
-                                           MPIC_BIG_ENDIAN | MPIC_WANTS_RESET,
-                                           0, 128, 124, 0, senses, 124,
-                                           " U3-MPIC  ");
-                        BUG_ON(mpic2 == NULL);
-                        mpic_init(mpic2);
-                        mpic_setup_cascade(irqctrler2->intrs[0].line,
-                                           pmac_u3_cascade, mpic2);
-                }
-#if defined(CONFIG_XMON) && defined(CONFIG_PPC32)
-                {
-                        struct device_node* pswitch;
-                        int nmi_irq;
-
-                        pswitch = find_devices("programmer-switch");
-                        if (pswitch && pswitch->n_intrs) {
-                                nmi_irq = pswitch->intrs[0].line;
-                                mpic_irq_set_priority(nmi_irq, 9);
-                                setup_irq(nmi_irq, &xmon_action);
-                        }
-                }
-#endif  /* defined(CONFIG_XMON) && defined(CONFIG_PPC32) */
-                return;
-        }
-        irqctrler = NULL;
+        /* Set our get_irq function */
+        ppc_md.get_irq = pmac_get_irq;
 
-#ifdef CONFIG_PPC32
-        /* Get the level/edge settings, assume if it's not
-         * a Grand Central nor an OHare, then it's an Heathrow
-         * (or Paddington).
+        /*
+         * Find the interrupt controller type & node
          */
-        ppc_md.get_irq = pmac_get_irq;
-        if (find_devices("gc"))
+
+        if ((master = of_find_node_by_name(NULL, "gc")) != NULL) {
+                max_irqs = max_real_irqs = 32;
                 level_mask[0] = GC_LEVEL_MASK;
-        else if (find_devices("ohare")) {
+        } else if ((master = of_find_node_by_name(NULL, "ohare")) != NULL) {
+                max_irqs = max_real_irqs = 32;
                 level_mask[0] = OHARE_LEVEL_MASK;
+
                 /* We might have a second cascaded ohare */
-                level_mask[1] = OHARE_LEVEL_MASK;
-        } else {
+                slave = of_find_node_by_name(NULL, "pci106b,7");
+                if (slave) {
+                        max_irqs = 64;
+                        level_mask[1] = OHARE_LEVEL_MASK;
+                        enable_second_ohare(slave);
+                }
+        } else if ((master = of_find_node_by_name(NULL, "mac-io")) != NULL) {
+                max_irqs = max_real_irqs = 64;
                 level_mask[0] = HEATHROW_LEVEL_MASK;
                 level_mask[1] = 0;
+
                 /* We might have a second cascaded heathrow */
-                level_mask[2] = HEATHROW_LEVEL_MASK;
-                level_mask[3] = 0;
-        }
+                slave = of_find_node_by_name(master, "mac-io");
+
+                /* Check ordering of master & slave */
+                if (device_is_compatible(master, "gatwick")) {
+                        struct device_node *tmp;
+                        BUG_ON(slave == NULL);
+                        tmp = master;
+                        master = slave;
+                        slave = tmp;
+                }
 
-        /*
-         * G3 powermacs and 1999 G3 PowerBooks have 64 interrupts,
-         * 1998 G3 Series PowerBooks have 128,
-         * other powermacs have 32.
-         * The combo ethernet/modem card for the Powerstar powerbooks
-         * (2400/3400/3500, ohare based) has a second ohare chip
-         * effectively making a total of 64.
-         */
-        max_irqs = max_real_irqs = 32;
-        irqctrler = find_devices("mac-io");
-        if (irqctrler)
-        {
-                max_real_irqs = 64;
-                if (irqctrler->next)
+                /* We found a slave */
+                if (slave) {
                         max_irqs = 128;
-                else
-                        max_irqs = 64;
+                        level_mask[2] = HEATHROW_LEVEL_MASK;
+                        level_mask[3] = 0;
+                        pmac_fix_gatwick_interrupts(slave, max_real_irqs);
+                }
         }
+        BUG_ON(master == NULL);
+
+        /* Set the handler for the main PIC */
         for ( i = 0; i < max_real_irqs ; i++ )
                 irq_desc[i].handler = &pmac_pic;
 
-        /* get addresses of first controller */
-        if (irqctrler) {
-                if  (irqctrler->n_addrs > 0) {
-                        addr = (unsigned long)
-                                ioremap(irqctrler->addrs[0].address, 0x40);
-                        for (i = 0; i < 2; ++i)
-                                pmac_irq_hw[i] = (volatile struct pmac_irq_hw*)
-                                        (addr + (2 - i) * 0x10);
-                }
+        /* Get addresses of first controller if we have a node for it */
+        BUG_ON(of_address_to_resource(master, 0, &r));
 
-                /* get addresses of second controller */
-                irqctrler = irqctrler->next;
-                if (irqctrler && irqctrler->n_addrs > 0) {
-                        addr = (unsigned long)
-                                ioremap(irqctrler->addrs[0].address, 0x40);
-                        for (i = 2; i < 4; ++i)
-                                pmac_irq_hw[i] = (volatile struct pmac_irq_hw*)
-                                        (addr + (4 - i) * 0x10);
-                        irq_cascade = irqctrler->intrs[0].line;
-                        if (device_is_compatible(irqctrler, "gatwick"))
-                                pmac_fix_gatwick_interrupts(irqctrler, max_real_irqs);
-                }
-        } else {
-                /* older powermacs have a GC (grand central) or ohare at
-                   f3000000, with interrupt control registers at f3000020. */
-                addr = (unsigned long) ioremap(0xf3000000, 0x40);
-                pmac_irq_hw[0] = (volatile struct pmac_irq_hw *) (addr + 0x20);
+        /* Map interrupts of primary controller */
+        addr = (u8 __iomem *) ioremap(r.start, 0x40);
+        i = 0;
+        pmac_irq_hw[i++] = (volatile struct pmac_irq_hw __iomem *)
+                (addr + 0x20);
+        if (max_real_irqs > 32)
+                pmac_irq_hw[i++] = (volatile struct pmac_irq_hw __iomem *)
+                        (addr + 0x10);
+        of_node_put(master);
+
+        printk(KERN_INFO "irq: Found primary Apple PIC %s for %d irqs\n",
+               master->full_name, max_real_irqs);
+
+        /* Map interrupts of cascaded controller */
+        if (slave && !of_address_to_resource(slave, 0, &r)) {
+                addr = (u8 __iomem *)ioremap(r.start, 0x40);
+                pmac_irq_hw[i++] = (volatile struct pmac_irq_hw __iomem *)
+                        (addr + 0x20);
+                if (max_irqs > 64)
+                        pmac_irq_hw[i++] =
+                                (volatile struct pmac_irq_hw __iomem *)
+                                (addr + 0x10);
+                irq_cascade = slave->intrs[0].line;
+
+                printk(KERN_INFO "irq: Found slave Apple PIC %s for %d irqs"
+                       " cascade: %d\n", slave->full_name,
+                       max_irqs - max_real_irqs, irq_cascade);
         }
-
-        /* PowerBooks 3400 and 3500 can have a second controller in a second
-           ohare chip, on the combo ethernet/modem card */
-        if (machine_is_compatible("AAPL,3400/2400")
-             || machine_is_compatible("AAPL,3500"))
-                irq_cascade = enable_second_ohare();
+        of_node_put(slave);
 
         /* disable all interrupts in all controllers */
         for (i = 0; i * 32 < max_irqs; ++i)
                 out_le32(&pmac_irq_hw[i]->enable, 0);
+
         /* mark level interrupts */
         for (i = 0; i < max_irqs; i++)
                 if (level_mask[i >> 5] & (1UL << (i & 0x1f)))
                         irq_desc[i].status = IRQ_LEVEL;
 
-        /* get interrupt line of secondary interrupt controller */
-        if (irq_cascade >= 0) {
-                printk(KERN_INFO "irq: secondary controller on irq %d\n",
-                        (int)irq_cascade);
+        /* Setup handlers for secondary controller and hook cascade irq*/
+        if (slave) {
                 for ( i = max_real_irqs ; i < max_irqs ; i++ )
                         irq_desc[i].handler = &gatwick_pic;
                 setup_irq(irq_cascade, &gatwick_cascade_action);
         }
-        printk("System has %d possible interrupts\n", max_irqs);
-        if (max_irqs != max_real_irqs)
-                printk(KERN_DEBUG "%d interrupts on main controller\n",
-                        max_real_irqs);
-
+        printk(KERN_INFO "irq: System has %d possible interrupts\n", max_irqs);
 #ifdef CONFIG_XMON
         setup_irq(20, &xmon_action);
-#endif  /* CONFIG_XMON */
-#endif  /* CONFIG_PPC32 */
+#endif
+}
+#endif /* CONFIG_PPC32 */
+
+static int pmac_u3_cascade(struct pt_regs *regs, void *data)
+{
+        return mpic_get_one_irq((struct mpic *)data, regs);
+}
+
+static void __init pmac_pic_setup_mpic_nmi(struct mpic *mpic)
+{
+#if defined(CONFIG_XMON) && defined(CONFIG_PPC32)
+        struct device_node* pswitch;
+        int nmi_irq;
+
+        pswitch = of_find_node_by_name(NULL, "programmer-switch");
+        if (pswitch && pswitch->n_intrs) {
+                nmi_irq = pswitch->intrs[0].line;
+                mpic_irq_set_priority(nmi_irq, 9);
+                setup_irq(nmi_irq, &xmon_action);
+        }
+        of_node_put(pswitch);
+#endif  /* defined(CONFIG_XMON) && defined(CONFIG_PPC32) */
+}
+
+static int __init pmac_pic_probe_mpic(void)
+{
+        struct mpic *mpic1, *mpic2;
+        struct device_node *np, *master = NULL, *slave = NULL;
+        unsigned char senses[128];
+        struct resource r;
+
+        /* We can have up to 2 MPICs cascaded */
+        for (np = NULL; (np = of_find_node_by_type(np, "open-pic"))
+                     != NULL;) {
+                if (master == NULL &&
+                    get_property(np, "interrupt-parent", NULL) != NULL)
+                        master = of_node_get(np);
+                else if (slave == NULL)
+                        slave = of_node_get(np);
+                if (master && slave)
+                        break;
+        }
+
+        /* Check for bogus setups */
+        if (master == NULL && slave != NULL) {
+                master = slave;
+                slave = NULL;
+        }
+
+        /* Not found, default to good old pmac pic */
+        if (master == NULL)
+                return -ENODEV;
+
+        /* Set master handler */
+        ppc_md.get_irq = mpic_get_irq;
+
+        /* Setup master */
+        BUG_ON(of_address_to_resource(master, 0, &r));
+        pmac_call_feature(PMAC_FTR_ENABLE_MPIC, master, 0, 0);
+        prom_get_irq_senses(senses, 0, 128);
+        mpic1 = mpic_alloc(r.start, MPIC_PRIMARY | MPIC_WANTS_RESET,
+                           0, 0, 128, 252, senses, 128, " OpenPIC  ");
+        BUG_ON(mpic1 == NULL);
+        mpic_init(mpic1);
+
+        /* Install NMI if any */
+        pmac_pic_setup_mpic_nmi(mpic1);
+
+        of_node_put(master);
+
+        /* No slave, let's go out */
+        if (slave == NULL || slave->n_intrs < 1)
+                return 0;
+
+        /* Setup slave, failures are non-fatal */
+        if (of_address_to_resource(slave, 0, &r)) {
+                printk(KERN_ERR "Can't get address of MPIC %s\n",
+                       slave->full_name);
+                return 0;
+        }
+        pmac_call_feature(PMAC_FTR_ENABLE_MPIC, slave, 0, 0);
+        prom_get_irq_senses(senses, 128, 128 + 124);
+
+        /* We don't need to set MPIC_BROKEN_U3 here since we don't have
+         * hypertransport interrupts routed to it, at least not on currently
+         * supported machines, that may change.
+         */
+        mpic2 = mpic_alloc(r.start, MPIC_BIG_ENDIAN | MPIC_WANTS_RESET,
+                           0, 128, 124, 0, senses, 124, " U3-MPIC  ");
+        if (mpic2 == NULL) {
+                printk(KERN_ERR "Can't create slave MPIC %s\n",
+                       slave->full_name);
+                return 0;
+        }
+        mpic_init(mpic2);
+        mpic_setup_cascade(slave->intrs[0].line, pmac_u3_cascade, mpic2);
+
+        of_node_put(slave);
+        return 0;
+}
+
+
+void __init pmac_pic_init(void)
+{
+        /* We first try to detect Apple's new Core99 chipset, since mac-io
+         * is quite different on those machines and contains an IBM MPIC2.
+         */
+        if (pmac_pic_probe_mpic() == 0)
+                return;
+
+#ifdef CONFIG_PPC32
+        pmac_pic_probe_oldstyle();
+#endif
 }
 
 #if defined(CONFIG_PM) && defined(CONFIG_PPC32)
diff --git a/arch/powerpc/platforms/powermac/pmac.h b/arch/powerpc/platforms/powermac/pmac.h
index 2ad25e13423e..21c7b0f8f329 100644
--- a/arch/powerpc/platforms/powermac/pmac.h
+++ b/arch/powerpc/platforms/powermac/pmac.h
@@ -42,10 +42,6 @@ extern void pmac_ide_init_hwif_ports(hw_regs_t *hw,
         unsigned long data_port, unsigned long ctrl_port, int *irq);
 
 extern int pmac_nvram_init(void);
-
-extern struct hw_interrupt_type pmac_pic;
-
-void pmac_pic_init(void);
-int pmac_get_irq(struct pt_regs *regs);
+extern void pmac_pic_init(void);
 
 #endif /* __PMAC_H__ */
diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
index c0638e47c298..18c5620f87fa 100644
--- a/arch/powerpc/platforms/powermac/setup.c
+++ b/arch/powerpc/platforms/powermac/setup.c
@@ -75,7 +75,6 @@
 #include <asm/iommu.h>
 #include <asm/smu.h>
 #include <asm/pmc.h>
-#include <asm/mpic.h>
 #include <asm/lmb.h>
 #include <asm/udbg.h>
 
@@ -751,7 +750,7 @@ struct machdep_calls __initdata pmac_md = {
         .init_early             = pmac_init_early,
         .show_cpuinfo           = pmac_show_cpuinfo,
         .init_IRQ               = pmac_pic_init,
-        .get_irq                = mpic_get_irq, /* changed later */
+        .get_irq                = NULL, /* changed later */
         .pcibios_fixup          = pmac_pcibios_fixup,
         .restart                = pmac_restart,
         .power_off              = pmac_power_off,
diff --git a/arch/powerpc/platforms/powermac/time.c b/arch/powerpc/platforms/powermac/time.c
index feb0a94e7819..5d9afa1fa02d 100644
--- a/arch/powerpc/platforms/powermac/time.c
+++ b/arch/powerpc/platforms/powermac/time.c
@@ -258,15 +258,20 @@ int __init via_calibrate_decr(void)
         volatile unsigned char __iomem *via;
         int count = VIA_TIMER_FREQ_6 / 100;
         unsigned int dstart, dend;
+        struct resource rsrc;
 
-        vias = find_devices("via-cuda");
+        vias = of_find_node_by_name(NULL, "via-cuda");
         if (vias == 0)
-                vias = find_devices("via-pmu");
+                vias = of_find_node_by_name(NULL, "via-pmu");
         if (vias == 0)
-                vias = find_devices("via");
-        if (vias == 0 || vias->n_addrs == 0)
+                vias = of_find_node_by_name(NULL, "via");
+        if (vias == 0 || of_address_to_resource(vias, 0, &rsrc))
                 return 0;
-        via = ioremap(vias->addrs[0].address, vias->addrs[0].size);
+        via = ioremap(rsrc.start, rsrc.end - rsrc.start + 1);
+        if (via == NULL) {
+                printk(KERN_ERR "Failed to map VIA for timer calibration !\n");
+                return 0;
+        }
 
         /* set timer 1 for continuous interrupts */
         out_8(&via[ACR], (via[ACR] & ~T1MODE) | T1MODE_CONT);