diff options
author | Jeremy Kerr <jk@ozlabs.org> | 2006-07-12 01:39:43 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-07-31 01:55:04 -0400 |
commit | 954a46e2d5aec6f59976ddeb1d232b486e59b54a (patch) | |
tree | 4e34abf431de3d6a31036c1fdf33fa4dadeb2951 /arch/powerpc/platforms/pseries/xics.c | |
parent | a7f67bdf2c9f24509b8e81e0f35573b611987c80 (diff) |
[POWERPC] pseries: Constify & voidify get_property()
Now that get_property() returns a void *, there's no need to cast its
return value. Also, treat the return value as const, so we can
constify get_property later.
pseries platform changes.
Built for pseries_defconfig
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/platforms/pseries/xics.c')
-rw-r--r-- | arch/powerpc/platforms/pseries/xics.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c index 716972aa9777..756421049441 100644 --- a/arch/powerpc/platforms/pseries/xics.c +++ b/arch/powerpc/platforms/pseries/xics.c | |||
@@ -604,14 +604,14 @@ static void __init xics_init_one_node(struct device_node *np, | |||
604 | unsigned int *indx) | 604 | unsigned int *indx) |
605 | { | 605 | { |
606 | unsigned int ilen; | 606 | unsigned int ilen; |
607 | u32 *ireg; | 607 | const u32 *ireg; |
608 | 608 | ||
609 | /* This code does the theorically broken assumption that the interrupt | 609 | /* This code does the theorically broken assumption that the interrupt |
610 | * server numbers are the same as the hard CPU numbers. | 610 | * server numbers are the same as the hard CPU numbers. |
611 | * This happens to be the case so far but we are playing with fire... | 611 | * This happens to be the case so far but we are playing with fire... |
612 | * should be fixed one of these days. -BenH. | 612 | * should be fixed one of these days. -BenH. |
613 | */ | 613 | */ |
614 | ireg = (u32 *)get_property(np, "ibm,interrupt-server-ranges", NULL); | 614 | ireg = get_property(np, "ibm,interrupt-server-ranges", NULL); |
615 | 615 | ||
616 | /* Do that ever happen ? we'll know soon enough... but even good'old | 616 | /* Do that ever happen ? we'll know soon enough... but even good'old |
617 | * f80 does have that property .. | 617 | * f80 does have that property .. |
@@ -623,7 +623,7 @@ static void __init xics_init_one_node(struct device_node *np, | |||
623 | */ | 623 | */ |
624 | *indx = *ireg; | 624 | *indx = *ireg; |
625 | } | 625 | } |
626 | ireg = (u32 *)get_property(np, "reg", &ilen); | 626 | ireg = get_property(np, "reg", &ilen); |
627 | if (!ireg) | 627 | if (!ireg) |
628 | panic("xics_init_IRQ: can't find interrupt reg property"); | 628 | panic("xics_init_IRQ: can't find interrupt reg property"); |
629 | 629 | ||
@@ -649,7 +649,7 @@ static void __init xics_setup_8259_cascade(void) | |||
649 | { | 649 | { |
650 | struct device_node *np, *old, *found = NULL; | 650 | struct device_node *np, *old, *found = NULL; |
651 | int cascade, naddr; | 651 | int cascade, naddr; |
652 | u32 *addrp; | 652 | const u32 *addrp; |
653 | unsigned long intack = 0; | 653 | unsigned long intack = 0; |
654 | 654 | ||
655 | for_each_node_by_type(np, "interrupt-controller") | 655 | for_each_node_by_type(np, "interrupt-controller") |
@@ -675,7 +675,7 @@ static void __init xics_setup_8259_cascade(void) | |||
675 | break; | 675 | break; |
676 | if (strcmp(np->name, "pci") != 0) | 676 | if (strcmp(np->name, "pci") != 0) |
677 | continue; | 677 | continue; |
678 | addrp = (u32 *)get_property(np, "8259-interrupt-acknowledge", NULL); | 678 | addrp = get_property(np, "8259-interrupt-acknowledge", NULL); |
679 | if (addrp == NULL) | 679 | if (addrp == NULL) |
680 | continue; | 680 | continue; |
681 | naddr = prom_n_addr_cells(np); | 681 | naddr = prom_n_addr_cells(np); |
@@ -694,7 +694,8 @@ void __init xics_init_IRQ(void) | |||
694 | { | 694 | { |
695 | int i; | 695 | int i; |
696 | struct device_node *np; | 696 | struct device_node *np; |
697 | u32 *ireg, ilen, indx = 0; | 697 | u32 ilen, indx = 0; |
698 | const u32 *ireg; | ||
698 | int found = 0; | 699 | int found = 0; |
699 | 700 | ||
700 | ppc64_boot_msg(0x20, "XICS Init"); | 701 | ppc64_boot_msg(0x20, "XICS Init"); |
@@ -719,18 +720,17 @@ void __init xics_init_IRQ(void) | |||
719 | for (np = of_find_node_by_type(NULL, "cpu"); | 720 | for (np = of_find_node_by_type(NULL, "cpu"); |
720 | np; | 721 | np; |
721 | np = of_find_node_by_type(np, "cpu")) { | 722 | np = of_find_node_by_type(np, "cpu")) { |
722 | ireg = (u32 *)get_property(np, "reg", &ilen); | 723 | ireg = get_property(np, "reg", &ilen); |
723 | if (ireg && ireg[0] == get_hard_smp_processor_id(boot_cpuid)) { | 724 | if (ireg && ireg[0] == get_hard_smp_processor_id(boot_cpuid)) { |
724 | ireg = (u32 *)get_property(np, | 725 | ireg = get_property(np, |
725 | "ibm,ppc-interrupt-gserver#s", | 726 | "ibm,ppc-interrupt-gserver#s", &ilen); |
726 | &ilen); | ||
727 | i = ilen / sizeof(int); | 727 | i = ilen / sizeof(int); |
728 | if (ireg && i > 0) { | 728 | if (ireg && i > 0) { |
729 | default_server = ireg[0]; | 729 | default_server = ireg[0]; |
730 | /* take last element */ | 730 | /* take last element */ |
731 | default_distrib_server = ireg[i-1]; | 731 | default_distrib_server = ireg[i-1]; |
732 | } | 732 | } |
733 | ireg = (u32 *)get_property(np, | 733 | ireg = get_property(np, |
734 | "ibm,interrupt-server#-size", NULL); | 734 | "ibm,interrupt-server#-size", NULL); |
735 | if (ireg) | 735 | if (ireg) |
736 | interrupt_server_size = *ireg; | 736 | interrupt_server_size = *ireg; |