diff options
author | Michael Ellerman <michael@ellerman.id.au> | 2006-03-21 04:46:02 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-03-21 23:04:20 -0500 |
commit | 260de22faac4d336ca122ebd0f1e59279d0b1dfd (patch) | |
tree | be1c202f2bba96546ae2430d9433f7bd7d2a4783 /arch/powerpc/platforms/iseries/setup.c | |
parent | 57cfb814f698d30894bc28e22125550193ebe549 (diff) |
[PATCH] powerpc: iseries: mf related cleanups
Some cleanups in the iSeries code.
- Make mf_display_progress() check mf_initialized rather than the caller.
- Set mf_initialized in mf_init() rather than in setup.c
- Then move mf_initialized into mf.c, the only place it's used.
- Move the mf related logic from iSeries_progress() to mf_display_progress()
- Use a #define to size the pending_event_prealloc array
- Use that define in the initialsation loop rather than sizeof jiggery pokery
- Remove stupid comment(s)
- Mark stuff static and/or __init
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/platforms/iseries/setup.c')
-rw-r--r-- | arch/powerpc/platforms/iseries/setup.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/arch/powerpc/platforms/iseries/setup.c b/arch/powerpc/platforms/iseries/setup.c index b08c3686f903..190891ce9cb4 100644 --- a/arch/powerpc/platforms/iseries/setup.c +++ b/arch/powerpc/platforms/iseries/setup.c | |||
@@ -89,8 +89,6 @@ extern unsigned long embedded_sysmap_end; | |||
89 | extern unsigned long iSeries_recal_tb; | 89 | extern unsigned long iSeries_recal_tb; |
90 | extern unsigned long iSeries_recal_titan; | 90 | extern unsigned long iSeries_recal_titan; |
91 | 91 | ||
92 | static int mf_initialized; | ||
93 | |||
94 | static unsigned long cmd_mem_limit; | 92 | static unsigned long cmd_mem_limit; |
95 | 93 | ||
96 | struct MemoryBlock { | 94 | struct MemoryBlock { |
@@ -347,8 +345,6 @@ static void __init iSeries_init_early(void) | |||
347 | HvCallEvent_setLpEventQueueInterruptProc(0, 0); | 345 | HvCallEvent_setLpEventQueueInterruptProc(0, 0); |
348 | 346 | ||
349 | mf_init(); | 347 | mf_init(); |
350 | mf_initialized = 1; | ||
351 | mb(); | ||
352 | 348 | ||
353 | /* If we were passed an initrd, set the ROOT_DEV properly if the values | 349 | /* If we were passed an initrd, set the ROOT_DEV properly if the values |
354 | * look sensible. If not, clear initrd reference. | 350 | * look sensible. If not, clear initrd reference. |
@@ -585,12 +581,7 @@ static void iSeries_halt(void) | |||
585 | static void __init iSeries_progress(char * st, unsigned short code) | 581 | static void __init iSeries_progress(char * st, unsigned short code) |
586 | { | 582 | { |
587 | printk("Progress: [%04x] - %s\n", (unsigned)code, st); | 583 | printk("Progress: [%04x] - %s\n", (unsigned)code, st); |
588 | if (!piranha_simulator && mf_initialized) { | 584 | mf_display_progress(code); |
589 | if (code != 0xffff) | ||
590 | mf_display_progress(code); | ||
591 | else | ||
592 | mf_clear_src(); | ||
593 | } | ||
594 | } | 585 | } |
595 | 586 | ||
596 | static void __init iSeries_fixup_klimit(void) | 587 | static void __init iSeries_fixup_klimit(void) |