diff options
author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2006-11-11 01:24:51 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-12-04 00:00:04 -0500 |
commit | f90bb153b1493719d18b4529a46ebfe43220ea6c (patch) | |
tree | 0d19d85be3f9603b9b3c5dc16aa45185ce8f9bc1 /arch/powerpc/platforms/chrp | |
parent | 34ba8a5cd0b0d57f7775023e6e3fec473a7291cc (diff) |
[POWERPC] Make pci_read_irq_line the default
This patch reworks the way IRQs are fixed up on PCI for arch powerpc.
It makes pci_read_irq_line() called by default in the PCI code for
devices that are probed, and add an optional per-device fixup in
ppc_md for platforms that really need to correct what they obtain
from pci_read_irq_line().
It also removes ppc_md.irq_bus_setup which was only used by pSeries
and should not be needed anymore.
I've also removed the pSeries s7a workaround as it can't work with
the current interrupt code anyway. I'm trying to get one of these
machines working so I can test a proper fix for that problem.
I also haven't updated the old-style fixup code from 85xx_cds.c
because it's actually buggy :) It assigns pci_dev->irq hard coded
numbers which is no good with the new IRQ mapping code. It should
at least use irq_create_mapping(NULL, hard_coded_number); and possibly
also set_irq_type() to set them as level low.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/platforms/chrp')
-rw-r--r-- | arch/powerpc/platforms/chrp/chrp.h | 1 | ||||
-rw-r--r-- | arch/powerpc/platforms/chrp/pci.c | 9 | ||||
-rw-r--r-- | arch/powerpc/platforms/chrp/setup.c | 1 |
3 files changed, 0 insertions, 11 deletions
diff --git a/arch/powerpc/platforms/chrp/chrp.h b/arch/powerpc/platforms/chrp/chrp.h index 996c28744e96..63f0aee4c158 100644 --- a/arch/powerpc/platforms/chrp/chrp.h +++ b/arch/powerpc/platforms/chrp/chrp.h | |||
@@ -9,4 +9,3 @@ extern long chrp_time_init(void); | |||
9 | 9 | ||
10 | extern void chrp_find_bridges(void); | 10 | extern void chrp_find_bridges(void); |
11 | extern void chrp_event_scan(unsigned long); | 11 | extern void chrp_event_scan(unsigned long); |
12 | extern void chrp_pcibios_fixup(void); | ||
diff --git a/arch/powerpc/platforms/chrp/pci.c b/arch/powerpc/platforms/chrp/pci.c index 0f4340506c75..ddb4a116ea89 100644 --- a/arch/powerpc/platforms/chrp/pci.c +++ b/arch/powerpc/platforms/chrp/pci.c | |||
@@ -156,15 +156,6 @@ hydra_init(void) | |||
156 | return 1; | 156 | return 1; |
157 | } | 157 | } |
158 | 158 | ||
159 | void __init | ||
160 | chrp_pcibios_fixup(void) | ||
161 | { | ||
162 | struct pci_dev *dev = NULL; | ||
163 | |||
164 | for_each_pci_dev(dev) | ||
165 | pci_read_irq_line(dev); | ||
166 | } | ||
167 | |||
168 | #define PRG_CL_RESET_VALID 0x00010000 | 159 | #define PRG_CL_RESET_VALID 0x00010000 |
169 | 160 | ||
170 | static void __init | 161 | static void __init |
diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c index 49b8dabcbc99..e6807d6d75bf 100644 --- a/arch/powerpc/platforms/chrp/setup.c +++ b/arch/powerpc/platforms/chrp/setup.c | |||
@@ -600,7 +600,6 @@ define_machine(chrp) { | |||
600 | .init = chrp_init2, | 600 | .init = chrp_init2, |
601 | .show_cpuinfo = chrp_show_cpuinfo, | 601 | .show_cpuinfo = chrp_show_cpuinfo, |
602 | .init_IRQ = chrp_init_IRQ, | 602 | .init_IRQ = chrp_init_IRQ, |
603 | .pcibios_fixup = chrp_pcibios_fixup, | ||
604 | .restart = rtas_restart, | 603 | .restart = rtas_restart, |
605 | .power_off = rtas_power_off, | 604 | .power_off = rtas_power_off, |
606 | .halt = rtas_halt, | 605 | .halt = rtas_halt, |