diff options
author | Paul Mackerras <paulus@samba.org> | 2009-05-13 23:29:14 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-05-15 10:38:55 -0400 |
commit | ef923214a4816c289e4af2d67a9ebb1a31e4ac61 (patch) | |
tree | bf850f4f53a4f8391b6b9c0335e58364668586d9 /arch/powerpc/kernel/power6-pmu.c | |
parent | 2e569d36729c8105ae066a9b105068305442cc77 (diff) |
perf_counter: powerpc: use u64 for event codes internally
Although the perf_counter API allows 63-bit raw event codes,
internally in the powerpc back-end we had been using 32-bit
event codes. This expands them to 64 bits so that we can add
bits for specifying threshold start/stop events and instruction
sampling modes later.
This also corrects the return value of can_go_on_limited_pmc;
we were returning an event code rather than just a 0/1 value in
some circumstances. That didn't particularly matter while event
codes were 32-bit, but now that event codes are 64-bit it
might, so this fixes it.
[ Impact: extend PowerPC perfcounter interfaces from u32 to u64 ]
Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <18955.36874.472452.353104@drongo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/powerpc/kernel/power6-pmu.c')
-rw-r--r-- | arch/powerpc/kernel/power6-pmu.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/powerpc/kernel/power6-pmu.c b/arch/powerpc/kernel/power6-pmu.c index d44049f0ae27..ab7c615c458d 100644 --- a/arch/powerpc/kernel/power6-pmu.c +++ b/arch/powerpc/kernel/power6-pmu.c | |||
@@ -134,7 +134,7 @@ static u32 marked_bus_events[16] = { | |||
134 | * Returns 1 if event counts things relating to marked instructions | 134 | * Returns 1 if event counts things relating to marked instructions |
135 | * and thus needs the MMCRA_SAMPLE_ENABLE bit set, or 0 if not. | 135 | * and thus needs the MMCRA_SAMPLE_ENABLE bit set, or 0 if not. |
136 | */ | 136 | */ |
137 | static int power6_marked_instr_event(unsigned int event) | 137 | static int power6_marked_instr_event(u64 event) |
138 | { | 138 | { |
139 | int pmc, psel, ptype; | 139 | int pmc, psel, ptype; |
140 | int bit, byte, unit; | 140 | int bit, byte, unit; |
@@ -172,7 +172,7 @@ static int power6_marked_instr_event(unsigned int event) | |||
172 | /* | 172 | /* |
173 | * Assign PMC numbers and compute MMCR1 value for a set of events | 173 | * Assign PMC numbers and compute MMCR1 value for a set of events |
174 | */ | 174 | */ |
175 | static int p6_compute_mmcr(unsigned int event[], int n_ev, | 175 | static int p6_compute_mmcr(u64 event[], int n_ev, |
176 | unsigned int hwc[], u64 mmcr[]) | 176 | unsigned int hwc[], u64 mmcr[]) |
177 | { | 177 | { |
178 | u64 mmcr1 = 0; | 178 | u64 mmcr1 = 0; |
@@ -265,7 +265,7 @@ static int p6_compute_mmcr(unsigned int event[], int n_ev, | |||
265 | * 20-23, 24-27, 28-31 ditto for bytes 1, 2, 3 | 265 | * 20-23, 24-27, 28-31 ditto for bytes 1, 2, 3 |
266 | * 32-34 select field: nest (subunit) event selector | 266 | * 32-34 select field: nest (subunit) event selector |
267 | */ | 267 | */ |
268 | static int p6_get_constraint(unsigned int event, u64 *maskp, u64 *valp) | 268 | static int p6_get_constraint(u64 event, u64 *maskp, u64 *valp) |
269 | { | 269 | { |
270 | int pmc, byte, sh, subunit; | 270 | int pmc, byte, sh, subunit; |
271 | u64 mask = 0, value = 0; | 271 | u64 mask = 0, value = 0; |
@@ -298,7 +298,7 @@ static int p6_get_constraint(unsigned int event, u64 *maskp, u64 *valp) | |||
298 | return 0; | 298 | return 0; |
299 | } | 299 | } |
300 | 300 | ||
301 | static int p6_limited_pmc_event(unsigned int event) | 301 | static int p6_limited_pmc_event(u64 event) |
302 | { | 302 | { |
303 | int pmc = (event >> PM_PMC_SH) & PM_PMC_MSK; | 303 | int pmc = (event >> PM_PMC_SH) & PM_PMC_MSK; |
304 | 304 | ||
@@ -337,7 +337,7 @@ static const unsigned int event_alternatives[][MAX_ALT] = { | |||
337 | * This could be made more efficient with a binary search on | 337 | * This could be made more efficient with a binary search on |
338 | * a presorted list, if necessary | 338 | * a presorted list, if necessary |
339 | */ | 339 | */ |
340 | static int find_alternatives_list(unsigned int event) | 340 | static int find_alternatives_list(u64 event) |
341 | { | 341 | { |
342 | int i, j; | 342 | int i, j; |
343 | unsigned int alt; | 343 | unsigned int alt; |
@@ -356,12 +356,12 @@ static int find_alternatives_list(unsigned int event) | |||
356 | return -1; | 356 | return -1; |
357 | } | 357 | } |
358 | 358 | ||
359 | static int p6_get_alternatives(unsigned int event, unsigned int flags, | 359 | static int p6_get_alternatives(u64 event, unsigned int flags, u64 alt[]) |
360 | unsigned int alt[]) | ||
361 | { | 360 | { |
362 | int i, j, nlim; | 361 | int i, j, nlim; |
363 | unsigned int aevent, psel, pmc; | 362 | unsigned int psel, pmc; |
364 | unsigned int nalt = 1; | 363 | unsigned int nalt = 1; |
364 | u64 aevent; | ||
365 | 365 | ||
366 | alt[0] = event; | 366 | alt[0] = event; |
367 | nlim = p6_limited_pmc_event(event); | 367 | nlim = p6_limited_pmc_event(event); |