diff options
author | Paul Mackerras <paulus@samba.org> | 2009-05-13 23:29:14 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-05-15 10:38:55 -0400 |
commit | ef923214a4816c289e4af2d67a9ebb1a31e4ac61 (patch) | |
tree | bf850f4f53a4f8391b6b9c0335e58364668586d9 /arch/powerpc/kernel/power5-pmu.c | |
parent | 2e569d36729c8105ae066a9b105068305442cc77 (diff) |
perf_counter: powerpc: use u64 for event codes internally
Although the perf_counter API allows 63-bit raw event codes,
internally in the powerpc back-end we had been using 32-bit
event codes. This expands them to 64 bits so that we can add
bits for specifying threshold start/stop events and instruction
sampling modes later.
This also corrects the return value of can_go_on_limited_pmc;
we were returning an event code rather than just a 0/1 value in
some circumstances. That didn't particularly matter while event
codes were 32-bit, but now that event codes are 64-bit it
might, so this fixes it.
[ Impact: extend PowerPC perfcounter interfaces from u32 to u64 ]
Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <18955.36874.472452.353104@drongo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/powerpc/kernel/power5-pmu.c')
-rw-r--r-- | arch/powerpc/kernel/power5-pmu.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/powerpc/kernel/power5-pmu.c b/arch/powerpc/kernel/power5-pmu.c index 6e667dc86470..d5344968ee9c 100644 --- a/arch/powerpc/kernel/power5-pmu.c +++ b/arch/powerpc/kernel/power5-pmu.c | |||
@@ -139,7 +139,7 @@ static u64 unit_cons[PM_LASTUNIT+1][2] = { | |||
139 | [PM_GRS] = { 0x30002000000000ull, 0x30000400000000ull }, | 139 | [PM_GRS] = { 0x30002000000000ull, 0x30000400000000ull }, |
140 | }; | 140 | }; |
141 | 141 | ||
142 | static int power5_get_constraint(unsigned int event, u64 *maskp, u64 *valp) | 142 | static int power5_get_constraint(u64 event, u64 *maskp, u64 *valp) |
143 | { | 143 | { |
144 | int pmc, byte, unit, sh; | 144 | int pmc, byte, unit, sh; |
145 | int bit, fmask; | 145 | int bit, fmask; |
@@ -224,7 +224,7 @@ static const unsigned int event_alternatives[][MAX_ALT] = { | |||
224 | * Scan the alternatives table for a match and return the | 224 | * Scan the alternatives table for a match and return the |
225 | * index into the alternatives table if found, else -1. | 225 | * index into the alternatives table if found, else -1. |
226 | */ | 226 | */ |
227 | static int find_alternative(unsigned int event) | 227 | static int find_alternative(u64 event) |
228 | { | 228 | { |
229 | int i, j; | 229 | int i, j; |
230 | 230 | ||
@@ -250,7 +250,7 @@ static const unsigned char bytedecode_alternatives[4][4] = { | |||
250 | * PMCSEL values on other counters. This returns the alternative | 250 | * PMCSEL values on other counters. This returns the alternative |
251 | * event code for those that do, or -1 otherwise. | 251 | * event code for those that do, or -1 otherwise. |
252 | */ | 252 | */ |
253 | static int find_alternative_bdecode(unsigned int event) | 253 | static u64 find_alternative_bdecode(u64 event) |
254 | { | 254 | { |
255 | int pmc, altpmc, pp, j; | 255 | int pmc, altpmc, pp, j; |
256 | 256 | ||
@@ -269,10 +269,10 @@ static int find_alternative_bdecode(unsigned int event) | |||
269 | return -1; | 269 | return -1; |
270 | } | 270 | } |
271 | 271 | ||
272 | static int power5_get_alternatives(unsigned int event, unsigned int flags, | 272 | static int power5_get_alternatives(u64 event, unsigned int flags, u64 alt[]) |
273 | unsigned int alt[]) | ||
274 | { | 273 | { |
275 | int i, j, ae, nalt = 1; | 274 | int i, j, nalt = 1; |
275 | u64 ae; | ||
276 | 276 | ||
277 | alt[0] = event; | 277 | alt[0] = event; |
278 | nalt = 1; | 278 | nalt = 1; |
@@ -338,7 +338,7 @@ static unsigned char direct_event_is_marked[0x28] = { | |||
338 | * Returns 1 if event counts things relating to marked instructions | 338 | * Returns 1 if event counts things relating to marked instructions |
339 | * and thus needs the MMCRA_SAMPLE_ENABLE bit set, or 0 if not. | 339 | * and thus needs the MMCRA_SAMPLE_ENABLE bit set, or 0 if not. |
340 | */ | 340 | */ |
341 | static int power5_marked_instr_event(unsigned int event) | 341 | static int power5_marked_instr_event(u64 event) |
342 | { | 342 | { |
343 | int pmc, psel; | 343 | int pmc, psel; |
344 | int bit, byte, unit; | 344 | int bit, byte, unit; |
@@ -382,7 +382,7 @@ static int power5_marked_instr_event(unsigned int event) | |||
382 | return (mask >> (byte * 8 + bit)) & 1; | 382 | return (mask >> (byte * 8 + bit)) & 1; |
383 | } | 383 | } |
384 | 384 | ||
385 | static int power5_compute_mmcr(unsigned int event[], int n_ev, | 385 | static int power5_compute_mmcr(u64 event[], int n_ev, |
386 | unsigned int hwc[], u64 mmcr[]) | 386 | unsigned int hwc[], u64 mmcr[]) |
387 | { | 387 | { |
388 | u64 mmcr1 = 0; | 388 | u64 mmcr1 = 0; |