[PATCH] more for_each_cpu() conversions

When we stop allocating percpu memory for not-possible CPUs we must not touch
the percpu data for not-possible CPUs at all.  The correct way of doing this
is to test cpu_possible() or to use for_each_cpu().

This patch is a kernel-wide sweep of all instances of NR_CPUS.  I found very
few instances of this bug, if any.  But the patch converts lots of open-coded
test to use the preferred helper macros.

Cc: Mikael Starvik <starvik@axis.com>
Cc: David Howells <dhowells@redhat.com>
Acked-by: Kyle McMartin <kyle@parisc-linux.org>
Cc: Anton Blanchard <anton@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: William Lee Irwin III <wli@holomorphy.com>
Cc: Andi Kleen <ak@muc.de>
Cc: Christian Zankel <chris@zankel.net>
Cc: Philippe Elie <phil.el@wanadoo.fr>
Cc: Nathan Scott <nathans@sgi.com>
Cc: Jens Axboe <axboe@suse.de>
Cc: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 10 insertions, 15 deletions

diff --git a/arch/parisc/kernel/smp.c b/arch/parisc/kernel/smp.c
index 25564b7ca6bb..d6ac1c60a471 100644
--- a/arch/parisc/kernel/smp.c
+++ b/arch/parisc/kernel/smp.c
@@ -298,8 +298,8 @@ send_IPI_allbutself(enum ipi_message_type op)
 {
         int i;
         
-        for (i = 0; i < NR_CPUS; i++) {
-                if (cpu_online(i) && i != smp_processor_id())
+        for_each_online_cpu(i) {
+                if (i != smp_processor_id())
                         send_IPI_single(i, op);
         }
 }
@@ -643,14 +643,13 @@ int sys_cpus(int argc, char **argv)
         if ( argc == 1 ){
         
 #ifdef DUMP_MORE_STATE
-                for(i=0; i<NR_CPUS; i++) {
+                for_each_online_cpu(i) {
                         int cpus_per_line = 4;
-                        if(cpu_online(i)) {
-                                if (j++ % cpus_per_line)
-                                        printk(" %3d",i);
-                                else
-                                        printk("\n %3d",i);
-                        }
+
+                        if (j++ % cpus_per_line)
+                                printk(" %3d",i);
+                        else
+                                printk("\n %3d",i);
                 }
                 printk("\n"); 
 #else
@@ -659,9 +658,7 @@ int sys_cpus(int argc, char **argv)
         } else if((argc==2) && !(strcmp(argv[1],"-l"))) {
                 printk("\nCPUSTATE  TASK CPUNUM CPUID HARDCPU(HPA)\n");
 #ifdef DUMP_MORE_STATE
-                for(i=0;i<NR_CPUS;i++) {
-                        if (!cpu_online(i))
-                                continue;
+                for_each_online_cpu(i) {
                         if (cpu_data[i].cpuid != NO_PROC_ID) {
                                 switch(cpu_data[i].state) {
                                         case STATE_RENDEZVOUS:
@@ -695,9 +692,7 @@ int sys_cpus(int argc, char **argv)
         } else if ((argc==2) && !(strcmp(argv[1],"-s"))) { 
 #ifdef DUMP_MORE_STATE
                 printk("\nCPUSTATE   CPUID\n");
-                for (i=0;i<NR_CPUS;i++) {
-                        if (!cpu_online(i))
-                                continue;
+                for_each_online_cpu(i) {
                         if (cpu_data[i].cpuid != NO_PROC_ID) {
                                 switch(cpu_data[i].state) {
                                         case STATE_RENDEZVOUS: