diff options
author | Zhaolei <zhaolei@cn.fujitsu.com> | 2008-10-17 07:12:35 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-10-27 12:18:25 -0400 |
commit | b517531ce53794f2a2eae1fff1d1216b9db4da9f (patch) | |
tree | 9b7c842a92b43ba9f9d2eae2a491cf902469f494 /arch/mips | |
parent | ecab1f4479abb88d739bc1aac5545e8399fbad66 (diff) |
MIPS: Fix debugfs_create_*'s error checking method for mips/kernel/
debugfs_create_*() returns NULL on error. Make its callers return -ENODEV
on error.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips')
-rw-r--r-- | arch/mips/kernel/setup.c | 4 | ||||
-rw-r--r-- | arch/mips/kernel/unaligned.c | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index 16f8edfe5cdc..4430a1f8fdf1 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c | |||
@@ -601,8 +601,8 @@ static int __init debugfs_mips(void) | |||
601 | struct dentry *d; | 601 | struct dentry *d; |
602 | 602 | ||
603 | d = debugfs_create_dir("mips", NULL); | 603 | d = debugfs_create_dir("mips", NULL); |
604 | if (IS_ERR(d)) | 604 | if (!d) |
605 | return PTR_ERR(d); | 605 | return -ENOMEM; |
606 | mips_debugfs_dir = d; | 606 | mips_debugfs_dir = d; |
607 | return 0; | 607 | return 0; |
608 | } | 608 | } |
diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c index c327b21bca81..20709669e592 100644 --- a/arch/mips/kernel/unaligned.c +++ b/arch/mips/kernel/unaligned.c | |||
@@ -560,12 +560,12 @@ static int __init debugfs_unaligned(void) | |||
560 | return -ENODEV; | 560 | return -ENODEV; |
561 | d = debugfs_create_u32("unaligned_instructions", S_IRUGO, | 561 | d = debugfs_create_u32("unaligned_instructions", S_IRUGO, |
562 | mips_debugfs_dir, &unaligned_instructions); | 562 | mips_debugfs_dir, &unaligned_instructions); |
563 | if (IS_ERR(d)) | 563 | if (!d) |
564 | return PTR_ERR(d); | 564 | return -ENOMEM; |
565 | d = debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR, | 565 | d = debugfs_create_u32("unaligned_action", S_IRUGO | S_IWUSR, |
566 | mips_debugfs_dir, &unaligned_action); | 566 | mips_debugfs_dir, &unaligned_action); |
567 | if (IS_ERR(d)) | 567 | if (!d) |
568 | return PTR_ERR(d); | 568 | return -ENOMEM; |
569 | return 0; | 569 | return 0; |
570 | } | 570 | } |
571 | __initcall(debugfs_unaligned); | 571 | __initcall(debugfs_unaligned); |