diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2008-04-30 15:31:03 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-05-12 11:46:55 -0400 |
commit | 7ff83f21d23d17b63bbb984fee5d12aa5a8066b3 (patch) | |
tree | db3849b324fb0854860a72e192d52d0aec6aff3b /arch/mips | |
parent | 1ff1a78cbb6fb6ceafac1b2cbdd72c939a7c9bae (diff) |
[MIPS] XXS1500 code style cleanup
Fix several errors and warnings given by checkpatch.pl:
- use of C99 // comments;
- using simple_strtol() where strict_strtol() could be used.
In addition to these changes, also do the following:
- remove needless parentheses;
- remove unneeded numeric literal type cast;
- insert spaces between operator and its operands;
- remove excess new lines;
- remove space after the type cast's closing parenthesis;
- insert missing space before closing brace in the structure initializer;
- fix typos, capitalize acronyms, etc. in the comments;
- update MontaVista copyright;
- remove Pete Popov's old email address...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips')
-rw-r--r-- | arch/mips/au1000/xxs1500/Makefile | 3 | ||||
-rw-r--r-- | arch/mips/au1000/xxs1500/board_setup.c | 39 | ||||
-rw-r--r-- | arch/mips/au1000/xxs1500/init.c | 11 | ||||
-rw-r--r-- | arch/mips/au1000/xxs1500/irqmap.c | 2 |
4 files changed, 26 insertions, 29 deletions
diff --git a/arch/mips/au1000/xxs1500/Makefile b/arch/mips/au1000/xxs1500/Makefile index 44d7f7056ae7..db3c526f64d8 100644 --- a/arch/mips/au1000/xxs1500/Makefile +++ b/arch/mips/au1000/xxs1500/Makefile | |||
@@ -1,7 +1,6 @@ | |||
1 | # | 1 | # |
2 | # Copyright 2003 MontaVista Software Inc. | 2 | # Copyright 2003 MontaVista Software Inc. |
3 | # Author: MontaVista Software, Inc. | 3 | # Author: MontaVista Software, Inc. <source@mvista.com> |
4 | # ppopov@mvista.com or source@mvista.com | ||
5 | # | 4 | # |
6 | # Makefile for MyCable XXS1500 board. | 5 | # Makefile for MyCable XXS1500 board. |
7 | # | 6 | # |
diff --git a/arch/mips/au1000/xxs1500/board_setup.c b/arch/mips/au1000/xxs1500/board_setup.c index 79d1798621bf..4c587acac5c3 100644 --- a/arch/mips/au1000/xxs1500/board_setup.c +++ b/arch/mips/au1000/xxs1500/board_setup.c | |||
@@ -1,7 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2000-2003 MontaVista Software Inc. | 2 | * Copyright 2000-2003, 2008 MontaVista Software Inc. |
3 | * Author: MontaVista Software, Inc. | 3 | * Author: MontaVista Software, Inc. <source@mvista.com> |
4 | * ppopov@mvista.com or source@mvista.com | ||
5 | * | 4 | * |
6 | * This program is free software; you can redistribute it and/or modify it | 5 | * This program is free software; you can redistribute it and/or modify it |
7 | * under the terms of the GNU General Public License as published by the | 6 | * under the terms of the GNU General Public License as published by the |
@@ -39,40 +38,40 @@ void __init board_setup(void) | |||
39 | { | 38 | { |
40 | u32 pin_func; | 39 | u32 pin_func; |
41 | 40 | ||
42 | // set multiple use pins (UART3/GPIO) to UART (it's used as UART too) | 41 | /* Set multiple use pins (UART3/GPIO) to UART (it's used as UART too) */ |
43 | pin_func = au_readl(SYS_PINFUNC) & (u32)(~SYS_PF_UR3); | 42 | pin_func = au_readl(SYS_PINFUNC) & ~SYS_PF_UR3; |
44 | pin_func |= SYS_PF_UR3; | 43 | pin_func |= SYS_PF_UR3; |
45 | au_writel(pin_func, SYS_PINFUNC); | 44 | au_writel(pin_func, SYS_PINFUNC); |
46 | 45 | ||
47 | // enable UART | 46 | /* Enable UART */ |
48 | au_writel(0x01, UART3_ADDR+UART_MOD_CNTRL); // clock enable (CE) | 47 | au_writel(0x01, UART3_ADDR + UART_MOD_CNTRL); /* clock enable (CE) */ |
49 | mdelay(10); | 48 | mdelay(10); |
50 | au_writel(0x03, UART3_ADDR+UART_MOD_CNTRL); // CE and "enable" | 49 | au_writel(0x03, UART3_ADDR + UART_MOD_CNTRL); /* CE and "enable" */ |
51 | mdelay(10); | 50 | mdelay(10); |
52 | 51 | ||
53 | // enable DTR = USB power up | 52 | /* Enable DTR = USB power up */ |
54 | au_writel(0x01, UART3_ADDR+UART_MCR); //? UART_MCR_DTR is 0x01??? | 53 | au_writel(0x01, UART3_ADDR + UART_MCR); /* UART_MCR_DTR is 0x01??? */ |
55 | 54 | ||
56 | #ifdef CONFIG_PCMCIA_XXS1500 | 55 | #ifdef CONFIG_PCMCIA_XXS1500 |
57 | /* setup pcmcia signals */ | 56 | /* Setup PCMCIA signals */ |
58 | au_writel(0, SYS_PININPUTEN); | 57 | au_writel(0, SYS_PININPUTEN); |
59 | 58 | ||
60 | /* gpio 0, 1, and 4 are inputs */ | 59 | /* GPIO 0, 1, and 4 are inputs */ |
61 | au_writel(1 | (1<<1) | (1<<4), SYS_TRIOUTCLR); | 60 | au_writel(1 | (1 << 1) | (1 << 4), SYS_TRIOUTCLR); |
62 | 61 | ||
63 | /* enable GPIO2 if not already enabled */ | 62 | /* Enable GPIO2 if not already enabled */ |
64 | au_writel(1, GPIO2_ENABLE); | 63 | au_writel(1, GPIO2_ENABLE); |
65 | /* gpio2 208/9/10/11 are inputs */ | 64 | /* GPIO2 208/9/10/11 are inputs */ |
66 | au_writel((1<<8) | (1<<9) | (1<<10) | (1<<11), GPIO2_DIR); | 65 | au_writel((1 << 8) | (1 << 9) | (1 << 10) | (1 << 11), GPIO2_DIR); |
67 | 66 | ||
68 | /* turn off power */ | 67 | /* Turn off power */ |
69 | au_writel((au_readl(GPIO2_PINSTATE) & ~(1<<14))|(1<<30), GPIO2_OUTPUT); | 68 | au_writel((au_readl(GPIO2_PINSTATE) & ~(1 << 14)) | (1 << 30), |
69 | GPIO2_OUTPUT); | ||
70 | #endif | 70 | #endif |
71 | 71 | ||
72 | |||
73 | #ifdef CONFIG_PCI | 72 | #ifdef CONFIG_PCI |
74 | #if defined(__MIPSEB__) | 73 | #if defined(__MIPSEB__) |
75 | au_writel(0xf | (2<<6) | (1<<4), Au1500_PCI_CFG); | 74 | au_writel(0xf | (2 << 6) | (1 << 4), Au1500_PCI_CFG); |
76 | #else | 75 | #else |
77 | au_writel(0xf, Au1500_PCI_CFG); | 76 | au_writel(0xf, Au1500_PCI_CFG); |
78 | #endif | 77 | #endif |
diff --git a/arch/mips/au1000/xxs1500/init.c b/arch/mips/au1000/xxs1500/init.c index 24fc6e132dc0..b849bf501c04 100644 --- a/arch/mips/au1000/xxs1500/init.c +++ b/arch/mips/au1000/xxs1500/init.c | |||
@@ -2,9 +2,8 @@ | |||
2 | * BRIEF MODULE DESCRIPTION | 2 | * BRIEF MODULE DESCRIPTION |
3 | * XXS1500 board setup | 3 | * XXS1500 board setup |
4 | * | 4 | * |
5 | * Copyright 2003 MontaVista Software Inc. | 5 | * Copyright 2003, 2008 MontaVista Software Inc. |
6 | * Author: MontaVista Software, Inc. | 6 | * Author: MontaVista Software, Inc. <source@mvista.com> |
7 | * ppopov@mvista.com or source@mvista.com | ||
8 | * | 7 | * |
9 | * This program is free software; you can redistribute it and/or modify it | 8 | * This program is free software; you can redistribute it and/or modify it |
10 | * under the terms of the GNU General Public License as published by the | 9 | * under the terms of the GNU General Public License as published by the |
@@ -45,8 +44,8 @@ void __init prom_init(void) | |||
45 | unsigned long memsize; | 44 | unsigned long memsize; |
46 | 45 | ||
47 | prom_argc = fw_arg0; | 46 | prom_argc = fw_arg0; |
48 | prom_argv = (char **) fw_arg1; | 47 | prom_argv = (char **)fw_arg1; |
49 | prom_envp = (char **) fw_arg2; | 48 | prom_envp = (char **)fw_arg2; |
50 | 49 | ||
51 | prom_init_cmdline(); | 50 | prom_init_cmdline(); |
52 | 51 | ||
@@ -54,6 +53,6 @@ void __init prom_init(void) | |||
54 | if (!memsize_str) | 53 | if (!memsize_str) |
55 | memsize = 0x04000000; | 54 | memsize = 0x04000000; |
56 | else | 55 | else |
57 | memsize = simple_strtol(memsize_str, NULL, 0); | 56 | memsize = strict_strtol(memsize_str, 0, NULL); |
58 | add_memory_region(0, memsize, BOOT_MEM_RAM); | 57 | add_memory_region(0, memsize, BOOT_MEM_RAM); |
59 | } | 58 | } |
diff --git a/arch/mips/au1000/xxs1500/irqmap.c b/arch/mips/au1000/xxs1500/irqmap.c index dd6e3d1eb4d4..edf06ed11870 100644 --- a/arch/mips/au1000/xxs1500/irqmap.c +++ b/arch/mips/au1000/xxs1500/irqmap.c | |||
@@ -31,7 +31,7 @@ | |||
31 | #include <asm/mach-au1x00/au1000.h> | 31 | #include <asm/mach-au1x00/au1000.h> |
32 | 32 | ||
33 | struct au1xxx_irqmap __initdata au1xxx_irq_map[] = { | 33 | struct au1xxx_irqmap __initdata au1xxx_irq_map[] = { |
34 | { AU1500_GPIO_204, INTC_INT_HIGH_LEVEL, 0}, | 34 | { AU1500_GPIO_204, INTC_INT_HIGH_LEVEL, 0 }, |
35 | { AU1500_GPIO_201, INTC_INT_LOW_LEVEL, 0 }, | 35 | { AU1500_GPIO_201, INTC_INT_LOW_LEVEL, 0 }, |
36 | { AU1500_GPIO_202, INTC_INT_LOW_LEVEL, 0 }, | 36 | { AU1500_GPIO_202, INTC_INT_LOW_LEVEL, 0 }, |
37 | { AU1500_GPIO_203, INTC_INT_LOW_LEVEL, 0 }, | 37 | { AU1500_GPIO_203, INTC_INT_LOW_LEVEL, 0 }, |