diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2007-02-12 03:55:31 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:44 -0500 |
commit | 5dfe4c964a0dd7bb3a1d64a4166835a153146207 (patch) | |
tree | 2fb2fd8c09922be4f40a5a9ac50b537b1d780e27 /arch/mips | |
parent | 540473208f8ac71c25a87e1a2670c3c18dd4d6db (diff) |
[PATCH] mark struct file_operations const 2
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.
[akpm@osdl.org: sparc64 fix]
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/mips')
-rw-r--r-- | arch/mips/kernel/rtlx.c | 2 | ||||
-rw-r--r-- | arch/mips/kernel/vpe.c | 2 | ||||
-rw-r--r-- | arch/mips/sibyte/sb1250/bcm1250_tbprof.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/arch/mips/kernel/rtlx.c b/arch/mips/kernel/rtlx.c index f29e93c6ccfc..d92c48e0d7a6 100644 --- a/arch/mips/kernel/rtlx.c +++ b/arch/mips/kernel/rtlx.c | |||
@@ -478,7 +478,7 @@ static ssize_t file_write(struct file *file, const char __user * buffer, | |||
478 | return rtlx_write(minor, (void *)buffer, count, 1); | 478 | return rtlx_write(minor, (void *)buffer, count, 1); |
479 | } | 479 | } |
480 | 480 | ||
481 | static struct file_operations rtlx_fops = { | 481 | static const struct file_operations rtlx_fops = { |
482 | .owner = THIS_MODULE, | 482 | .owner = THIS_MODULE, |
483 | .open = file_open, | 483 | .open = file_open, |
484 | .release = file_release, | 484 | .release = file_release, |
diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c index 4e832da48c69..9aca871a307f 100644 --- a/arch/mips/kernel/vpe.c +++ b/arch/mips/kernel/vpe.c | |||
@@ -1208,7 +1208,7 @@ static ssize_t vpe_write(struct file *file, const char __user * buffer, | |||
1208 | return ret; | 1208 | return ret; |
1209 | } | 1209 | } |
1210 | 1210 | ||
1211 | static struct file_operations vpe_fops = { | 1211 | static const struct file_operations vpe_fops = { |
1212 | .owner = THIS_MODULE, | 1212 | .owner = THIS_MODULE, |
1213 | .open = vpe_open, | 1213 | .open = vpe_open, |
1214 | .release = vpe_release, | 1214 | .release = vpe_release, |
diff --git a/arch/mips/sibyte/sb1250/bcm1250_tbprof.c b/arch/mips/sibyte/sb1250/bcm1250_tbprof.c index d1a906e683b2..212547c57310 100644 --- a/arch/mips/sibyte/sb1250/bcm1250_tbprof.c +++ b/arch/mips/sibyte/sb1250/bcm1250_tbprof.c | |||
@@ -374,7 +374,7 @@ static long sbprof_tb_ioctl(struct file *filp, | |||
374 | return error; | 374 | return error; |
375 | } | 375 | } |
376 | 376 | ||
377 | static struct file_operations sbprof_tb_fops = { | 377 | static const struct file_operations sbprof_tb_fops = { |
378 | .owner = THIS_MODULE, | 378 | .owner = THIS_MODULE, |
379 | .open = sbprof_tb_open, | 379 | .open = sbprof_tb_open, |
380 | .release = sbprof_tb_release, | 380 | .release = sbprof_tb_release, |