diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2008-07-13 11:15:04 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-07-15 13:44:38 -0400 |
commit | 7b22609442a32050e37cec5f6735376af61e68a1 (patch) | |
tree | db340f9fc91d480c16ebdbdc4e0b9fa90995e756 /arch/mips/txx9 | |
parent | 4c642f3f5e9f3f1a2fcce2c3fa1a94bf80142202 (diff) |
[MIPS] TXx9: cleanup and fix some sparse warnings
* Do not return void value
* Make some functions static
* Do not include unnecessary bootinfo.h
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/txx9')
-rw-r--r-- | arch/mips/txx9/generic/setup.c | 2 | ||||
-rw-r--r-- | arch/mips/txx9/jmr3927/setup.c | 3 | ||||
-rw-r--r-- | arch/mips/txx9/rbtx4927/setup.c | 16 | ||||
-rw-r--r-- | arch/mips/txx9/rbtx4938/setup.c | 13 |
4 files changed, 7 insertions, 27 deletions
diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c index 452cb9ea12c0..5afc5d5cab03 100644 --- a/arch/mips/txx9/generic/setup.c +++ b/arch/mips/txx9/generic/setup.c | |||
@@ -140,7 +140,7 @@ void __init prom_init(void) | |||
140 | 140 | ||
141 | strcpy(txx9_system_type, txx9_board_vec->system); | 141 | strcpy(txx9_system_type, txx9_board_vec->system); |
142 | 142 | ||
143 | return txx9_board_vec->prom_init(); | 143 | txx9_board_vec->prom_init(); |
144 | } | 144 | } |
145 | 145 | ||
146 | void __init prom_free_prom_memory(void) | 146 | void __init prom_free_prom_memory(void) |
diff --git a/arch/mips/txx9/jmr3927/setup.c b/arch/mips/txx9/jmr3927/setup.c index 61edc4ac1dbc..5e35ef73c5a5 100644 --- a/arch/mips/txx9/jmr3927/setup.c +++ b/arch/mips/txx9/jmr3927/setup.c | |||
@@ -38,8 +38,6 @@ | |||
38 | #ifdef CONFIG_SERIAL_TXX9 | 38 | #ifdef CONFIG_SERIAL_TXX9 |
39 | #include <linux/serial_core.h> | 39 | #include <linux/serial_core.h> |
40 | #endif | 40 | #endif |
41 | |||
42 | #include <asm/bootinfo.h> | ||
43 | #include <asm/txx9tmr.h> | 41 | #include <asm/txx9tmr.h> |
44 | #include <asm/txx9pio.h> | 42 | #include <asm/txx9pio.h> |
45 | #include <asm/reboot.h> | 43 | #include <asm/reboot.h> |
@@ -95,7 +93,6 @@ static void __init jmr3927_time_init(void) | |||
95 | #define DO_WRITE_THROUGH | 93 | #define DO_WRITE_THROUGH |
96 | #define DO_ENABLE_CACHE | 94 | #define DO_ENABLE_CACHE |
97 | 95 | ||
98 | extern char * __init prom_getcmdline(void); | ||
99 | static void jmr3927_board_init(void); | 96 | static void jmr3927_board_init(void); |
100 | 97 | ||
101 | static void __init jmr3927_mem_setup(void) | 98 | static void __init jmr3927_mem_setup(void) |
diff --git a/arch/mips/txx9/rbtx4927/setup.c b/arch/mips/txx9/rbtx4927/setup.c index aba11f376a51..1657fd935da8 100644 --- a/arch/mips/txx9/rbtx4927/setup.c +++ b/arch/mips/txx9/rbtx4927/setup.c | |||
@@ -50,8 +50,6 @@ | |||
50 | #include <linux/pm.h> | 50 | #include <linux/pm.h> |
51 | #include <linux/platform_device.h> | 51 | #include <linux/platform_device.h> |
52 | #include <linux/delay.h> | 52 | #include <linux/delay.h> |
53 | |||
54 | #include <asm/bootinfo.h> | ||
55 | #include <asm/io.h> | 53 | #include <asm/io.h> |
56 | #include <asm/processor.h> | 54 | #include <asm/processor.h> |
57 | #include <asm/reboot.h> | 55 | #include <asm/reboot.h> |
@@ -65,14 +63,6 @@ | |||
65 | #include <linux/serial_core.h> | 63 | #include <linux/serial_core.h> |
66 | #endif | 64 | #endif |
67 | 65 | ||
68 | /* These functions are used for rebooting or halting the machine*/ | ||
69 | extern void toshiba_rbtx4927_restart(char *command); | ||
70 | extern void toshiba_rbtx4927_halt(void); | ||
71 | extern void toshiba_rbtx4927_power_off(void); | ||
72 | extern void toshiba_rbtx4927_irq_setup(void); | ||
73 | |||
74 | char *prom_getcmdline(void); | ||
75 | |||
76 | static int tx4927_ccfg_toeon = 1; | 66 | static int tx4927_ccfg_toeon = 1; |
77 | 67 | ||
78 | #ifdef CONFIG_PCI | 68 | #ifdef CONFIG_PCI |
@@ -189,7 +179,7 @@ static void __noreturn wait_forever(void) | |||
189 | (*cpu_wait)(); | 179 | (*cpu_wait)(); |
190 | } | 180 | } |
191 | 181 | ||
192 | void toshiba_rbtx4927_restart(char *command) | 182 | static void toshiba_rbtx4927_restart(char *command) |
193 | { | 183 | { |
194 | printk(KERN_NOTICE "System Rebooting...\n"); | 184 | printk(KERN_NOTICE "System Rebooting...\n"); |
195 | 185 | ||
@@ -209,7 +199,7 @@ void toshiba_rbtx4927_restart(char *command) | |||
209 | /* no return */ | 199 | /* no return */ |
210 | } | 200 | } |
211 | 201 | ||
212 | void toshiba_rbtx4927_halt(void) | 202 | static void toshiba_rbtx4927_halt(void) |
213 | { | 203 | { |
214 | printk(KERN_NOTICE "System Halted\n"); | 204 | printk(KERN_NOTICE "System Halted\n"); |
215 | local_irq_disable(); | 205 | local_irq_disable(); |
@@ -217,7 +207,7 @@ void toshiba_rbtx4927_halt(void) | |||
217 | /* no return */ | 207 | /* no return */ |
218 | } | 208 | } |
219 | 209 | ||
220 | void toshiba_rbtx4927_power_off(void) | 210 | static void toshiba_rbtx4927_power_off(void) |
221 | { | 211 | { |
222 | toshiba_rbtx4927_halt(); | 212 | toshiba_rbtx4927_halt(); |
223 | /* no return */ | 213 | /* no return */ |
diff --git a/arch/mips/txx9/rbtx4938/setup.c b/arch/mips/txx9/rbtx4938/setup.c index 2ef71adea827..aaa987ae0f83 100644 --- a/arch/mips/txx9/rbtx4938/setup.c +++ b/arch/mips/txx9/rbtx4938/setup.c | |||
@@ -23,7 +23,6 @@ | |||
23 | #include <asm/time.h> | 23 | #include <asm/time.h> |
24 | #include <asm/txx9tmr.h> | 24 | #include <asm/txx9tmr.h> |
25 | #include <asm/io.h> | 25 | #include <asm/io.h> |
26 | #include <asm/bootinfo.h> | ||
27 | #include <asm/txx9/generic.h> | 26 | #include <asm/txx9/generic.h> |
28 | #include <asm/txx9/pci.h> | 27 | #include <asm/txx9/pci.h> |
29 | #include <asm/txx9/rbtx4938.h> | 28 | #include <asm/txx9/rbtx4938.h> |
@@ -34,15 +33,9 @@ | |||
34 | #include <asm/txx9/spi.h> | 33 | #include <asm/txx9/spi.h> |
35 | #include <asm/txx9pio.h> | 34 | #include <asm/txx9pio.h> |
36 | 35 | ||
37 | extern char * __init prom_getcmdline(void); | ||
38 | /* These functions are used for rebooting or halting the machine*/ | ||
39 | extern void rbtx4938_machine_restart(char *command); | ||
40 | extern void rbtx4938_machine_halt(void); | ||
41 | extern void rbtx4938_machine_power_off(void); | ||
42 | |||
43 | static int tx4938_ccfg_toeon = 1; | 36 | static int tx4938_ccfg_toeon = 1; |
44 | 37 | ||
45 | void rbtx4938_machine_halt(void) | 38 | static void rbtx4938_machine_halt(void) |
46 | { | 39 | { |
47 | printk(KERN_NOTICE "System Halted\n"); | 40 | printk(KERN_NOTICE "System Halted\n"); |
48 | local_irq_disable(); | 41 | local_irq_disable(); |
@@ -53,13 +46,13 @@ void rbtx4938_machine_halt(void) | |||
53 | ".set\tmips0"); | 46 | ".set\tmips0"); |
54 | } | 47 | } |
55 | 48 | ||
56 | void rbtx4938_machine_power_off(void) | 49 | static void rbtx4938_machine_power_off(void) |
57 | { | 50 | { |
58 | rbtx4938_machine_halt(); | 51 | rbtx4938_machine_halt(); |
59 | /* no return */ | 52 | /* no return */ |
60 | } | 53 | } |
61 | 54 | ||
62 | void rbtx4938_machine_restart(char *command) | 55 | static void rbtx4938_machine_restart(char *command) |
63 | { | 56 | { |
64 | local_irq_disable(); | 57 | local_irq_disable(); |
65 | 58 | ||