MIPS: APRP: Code formatting clean-ups.

Clean-up code according to the 'checkpatch.pl' script.

Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
Reviewed-by: Qais Yousef <Qais.Yousef@imgtec.com>
Patchwork: http://patchwork.linux-mips.org/patch/6097/
Reviewed-by: John Crispin <blogic@openwrt.org>

2 files changed, 63 insertions, 76 deletions

diff --git a/arch/mips/mti-malta/malta-amon.c b/arch/mips/mti-malta/malta-amon.c
index 917df6d643ce..0319ad8b39a8 100644
--- a/arch/mips/mti-malta/malta-amon.c
+++ b/arch/mips/mti-malta/malta-amon.c
@@ -1,30 +1,20 @@
 /*
- * Copyright (C) 2007  MIPS Technologies, Inc.
- *      All rights reserved.
-
- *  This program is free software; you can distribute it and/or modify it
- *  under the terms of the GNU General Public License (Version 2) as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope it will be useful, but WITHOUT
- *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
- *  for more details.
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License.  See the file "COPYING" in the main directory of this archive
+ * for more details.
  *
- *  You should have received a copy of the GNU General Public License along
- *  with this program; if not, write to the Free Software Foundation, Inc.,
- *  59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
+ * Copyright (C) 2007 MIPS Technologies, Inc.  All rights reserved.
+ * Copyright (C) 2013 Imagination Technologies Ltd.
  *
- * Arbitrary Monitor interface
+ * Arbitrary Monitor Interface
  */
-
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/smp.h>
 
 #include <asm/addrspace.h>
-#include <asm/mips-boards/launch.h>
 #include <asm/mipsmtregs.h>
+#include <asm/mips-boards/launch.h>
 #include <asm/vpe.h>
 
 int amon_cpu_avail(int cpu)
diff --git a/arch/mips/mti-malta/malta-int.c b/arch/mips/mti-malta/malta-int.c
index 59a3fa5ce4e8..ca3e3a46a42f 100644
--- a/arch/mips/mti-malta/malta-int.c
+++ b/arch/mips/mti-malta/malta-int.c
@@ -1,26 +1,16 @@
 /*
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License.  See the file "COPYING" in the main directory of this archive
+ * for more details.
+ *
  * Carsten Langgaard, carstenl@mips.com
  * Copyright (C) 2000, 2001, 2004 MIPS Technologies, Inc.
  * Copyright (C) 2001 Ralf Baechle
  * Copyright (C) 2013 Imagination Technologies Ltd.
  *
- *  This program is free software; you can distribute it and/or modify it
- *  under the terms of the GNU General Public License (Version 2) as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope it will be useful, but WITHOUT
- *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
- *  for more details.
- *
- *  You should have received a copy of the GNU General Public License along
- *  with this program; if not, write to the Free Software Foundation, Inc.,
- *  59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
- *
  * Routines for generic manipulation of the interrupts found on the MIPS
- * Malta board.
- * The interrupt controller is located in the South Bridge a PIIX4 device
- * with two internal 82C95 interrupt controllers.
+ * Malta board. The interrupt controller is located in the South Bridge
+ * a PIIX4 device with two internal 82C95 interrupt controllers.
  */
 #include <linux/init.h>
 #include <linux/irq.h>
@@ -92,7 +82,7 @@ static inline int mips_pcibios_iack(void)
                 BONITO_PCIMAP_CFG = 0;
                 break;
         default:
-                printk(KERN_WARNING "Unknown system controller.\n");
+                pr_emerg("Unknown system controller.\n");
                 return -1;
         }
         return irq;
@@ -156,11 +146,11 @@ static void corehi_irqdispatch(void)
         unsigned int intrcause, datalo, datahi;
         struct pt_regs *regs = get_irq_regs();
 
-        printk(KERN_EMERG "CoreHI interrupt, shouldn't happen, we die here!\n");
-        printk(KERN_EMERG "epc   : %08lx\nStatus: %08lx\n"
-                        "Cause : %08lx\nbadVaddr : %08lx\n",
-                        regs->cp0_epc, regs->cp0_status,
-                        regs->cp0_cause, regs->cp0_badvaddr);
+        pr_emerg("CoreHI interrupt, shouldn't happen, we die here!\n");
+        pr_emerg("epc    : %08lx\nStatus: %08lx\n"
+                 "Cause : %08lx\nbadVaddr : %08lx\n",
+                 regs->cp0_epc, regs->cp0_status,
+                 regs->cp0_cause, regs->cp0_badvaddr);
 
         /* Read all the registers and then print them as there is a
            problem with interspersed printk's upsetting the Bonito controller.
@@ -178,8 +168,8 @@ static void corehi_irqdispatch(void)
                 intrcause = GT_READ(GT_INTRCAUSE_OFS);
                 datalo = GT_READ(GT_CPUERR_ADDRLO_OFS);
                 datahi = GT_READ(GT_CPUERR_ADDRHI_OFS);
-                printk(KERN_EMERG "GT_INTRCAUSE = %08x\n", intrcause);
-                printk(KERN_EMERG "GT_CPUERR_ADDR = %02x%08x\n",
+                pr_emerg("GT_INTRCAUSE = %08x\n", intrcause);
+                pr_emerg("GT_CPUERR_ADDR = %02x%08x\n",
                                 datahi, datalo);
                 break;
         case MIPS_REVISION_SCON_BONITO:
@@ -191,14 +181,14 @@ static void corehi_irqdispatch(void)
                 intedge = BONITO_INTEDGE;
                 intsteer = BONITO_INTSTEER;
                 pcicmd = BONITO_PCICMD;
-                printk(KERN_EMERG "BONITO_INTISR = %08x\n", intisr);
-                printk(KERN_EMERG "BONITO_INTEN = %08x\n", inten);
-                printk(KERN_EMERG "BONITO_INTPOL = %08x\n", intpol);
-                printk(KERN_EMERG "BONITO_INTEDGE = %08x\n", intedge);
-                printk(KERN_EMERG "BONITO_INTSTEER = %08x\n", intsteer);
-                printk(KERN_EMERG "BONITO_PCICMD = %08x\n", pcicmd);
-                printk(KERN_EMERG "BONITO_PCIBADADDR = %08x\n", pcibadaddr);
-                printk(KERN_EMERG "BONITO_PCIMSTAT = %08x\n", pcimstat);
+                pr_emerg("BONITO_INTISR = %08x\n", intisr);
+                pr_emerg("BONITO_INTEN = %08x\n", inten);
+                pr_emerg("BONITO_INTPOL = %08x\n", intpol);
+                pr_emerg("BONITO_INTEDGE = %08x\n", intedge);
+                pr_emerg("BONITO_INTSTEER = %08x\n", intsteer);
+                pr_emerg("BONITO_PCICMD = %08x\n", pcicmd);
+                pr_emerg("BONITO_PCIBADADDR = %08x\n", pcibadaddr);
+                pr_emerg("BONITO_PCIMSTAT = %08x\n", pcimstat);
                 break;
         }
 
@@ -377,13 +367,13 @@ static struct irqaction corehi_irqaction = {
         .flags = IRQF_NO_THREAD,
 };
 
-static msc_irqmap_t __initdata msc_irqmap[] = {
+static msc_irqmap_t msc_irqmap[] __initdata = {
         {MSC01C_INT_TMR,                MSC01_IRQ_EDGE, 0},
         {MSC01C_INT_PCI,                MSC01_IRQ_LEVEL, 0},
 };
-static int __initdata msc_nr_irqs = ARRAY_SIZE(msc_irqmap);
+static int msc_nr_irqs __initdata = ARRAY_SIZE(msc_irqmap);
 
-static msc_irqmap_t __initdata msc_eicirqmap[] = {
+static msc_irqmap_t msc_eicirqmap[] __initdata = {
         {MSC01E_INT_SW0,                MSC01_IRQ_LEVEL, 0},
         {MSC01E_INT_SW1,                MSC01_IRQ_LEVEL, 0},
         {MSC01E_INT_I8259A,             MSC01_IRQ_LEVEL, 0},
@@ -396,7 +386,7 @@ static msc_irqmap_t __initdata msc_eicirqmap[] = {
         {MSC01E_INT_CPUCTR,             MSC01_IRQ_LEVEL, 0}
 };
 
-static int __initdata msc_nr_eicirqs = ARRAY_SIZE(msc_eicirqmap);
+static int msc_nr_eicirqs __initdata = ARRAY_SIZE(msc_eicirqmap);
 
 /*
  * This GIC specific tabular array defines the association between External
@@ -443,9 +433,12 @@ int __init gcmp_probe(unsigned long addr, unsigned long size)
         if (gcmp_present >= 0)
                 return gcmp_present;
 
-        _gcmp_base = (unsigned long) ioremap_nocache(GCMP_BASE_ADDR, GCMP_ADDRSPACE_SZ);
-        _msc01_biu_base = (unsigned long) ioremap_nocache(MSC01_BIU_REG_BASE, MSC01_BIU_ADDRSPACE_SZ);
-        gcmp_present = (GCMPGCB(GCMPB) & GCMP_GCB_GCMPB_GCMPBASE_MSK) == GCMP_BASE_ADDR;
+        _gcmp_base = (unsigned long) ioremap_nocache(GCMP_BASE_ADDR,
+                GCMP_ADDRSPACE_SZ);
+        _msc01_biu_base = (unsigned long) ioremap_nocache(MSC01_BIU_REG_BASE,
+                MSC01_BIU_ADDRSPACE_SZ);
+        gcmp_present = ((GCMPGCB(GCMPB) & GCMP_GCB_GCMPB_GCMPBASE_MSK) ==
+                GCMP_BASE_ADDR);
 
         if (gcmp_present)
                 pr_debug("GCMP present\n");
@@ -455,9 +448,8 @@ int __init gcmp_probe(unsigned long addr, unsigned long size)
 /* Return the number of IOCU's present */
 int __init gcmp_niocu(void)
 {
-  return gcmp_present ?
-    (GCMPGCB(GC) & GCMP_GCB_GC_NUMIOCU_MSK) >> GCMP_GCB_GC_NUMIOCU_SHF :
-    0;
+        return gcmp_present ? ((GCMPGCB(GC) & GCMP_GCB_GC_NUMIOCU_MSK) >>
+                GCMP_GCB_GC_NUMIOCU_SHF) : 0;
 }
 
 /* Set GCMP region attributes */
@@ -606,11 +598,14 @@ void __init arch_init_irq(void)
                         set_vi_handler(MIPSCPU_INT_IPI1, malta_ipi_irqdispatch);
                 }
                 /* Argh.. this really needs sorting out.. */
-                printk("CPU%d: status register was %08x\n", smp_processor_id(), read_c0_status());
+                pr_info("CPU%d: status register was %08x\n",
+                        smp_processor_id(), read_c0_status());
                 write_c0_status(read_c0_status() | STATUSF_IP3 | STATUSF_IP4);
-                printk("CPU%d: status register now %08x\n", smp_processor_id(), read_c0_status());
+                pr_info("CPU%d: status register now %08x\n",
+                        smp_processor_id(), read_c0_status());
                 write_c0_status(0x1100dc00);
-                printk("CPU%d: status register frc %08x\n", smp_processor_id(), read_c0_status());
+                pr_info("CPU%d: status register frc %08x\n",
+                        smp_processor_id(), read_c0_status());
                 for (i = 0; i < nr_cpu_ids; i++) {
                         arch_init_ipiirq(MIPS_GIC_IRQ_BASE +
                                          GIC_RESCHED_INT(i), &irq_resched);
@@ -628,11 +623,15 @@ void __init arch_init_irq(void)
                         cpu_ipi_call_irq = MSC01E_INT_SW1;
                 } else {
                         if (cpu_has_vint) {
-                                set_vi_handler (MIPS_CPU_IPI_RESCHED_IRQ, ipi_resched_dispatch);
-                                set_vi_handler (MIPS_CPU_IPI_CALL_IRQ, ipi_call_dispatch);
+                                set_vi_handler (MIPS_CPU_IPI_RESCHED_IRQ,
+                                        ipi_resched_dispatch);
+                                set_vi_handler (MIPS_CPU_IPI_CALL_IRQ,
+                                        ipi_call_dispatch);
                         }
-                        cpu_ipi_resched_irq = MIPS_CPU_IRQ_BASE + MIPS_CPU_IPI_RESCHED_IRQ;
-                        cpu_ipi_call_irq = MIPS_CPU_IRQ_BASE + MIPS_CPU_IPI_CALL_IRQ;
+                        cpu_ipi_resched_irq = MIPS_CPU_IRQ_BASE +
+                                MIPS_CPU_IPI_RESCHED_IRQ;
+                        cpu_ipi_call_irq = MIPS_CPU_IRQ_BASE +
+                                MIPS_CPU_IPI_CALL_IRQ;
                 }
                 arch_init_ipiirq(cpu_ipi_resched_irq, &irq_resched);
                 arch_init_ipiirq(cpu_ipi_call_irq, &irq_call);
@@ -642,9 +641,7 @@ void __init arch_init_irq(void)
 
 void malta_be_init(void)
 {
-        if (gcmp_present) {
-                /* Could change CM error mask register */
-        }
+        /* Could change CM error mask register. */
 }
 
 
@@ -724,14 +721,14 @@ int malta_be_handler(struct pt_regs *regs, int is_fixup)
                         if (cause < 16) {
                                 unsigned long cca_bits = (cm_error >> 15) & 7;
                                 unsigned long tr_bits = (cm_error >> 12) & 7;
-                                unsigned long mcmd_bits = (cm_error >> 7) & 0x1f;
+                                unsigned long cmd_bits = (cm_error >> 7) & 0x1f;
                                 unsigned long stag_bits = (cm_error >> 3) & 15;
                                 unsigned long sport_bits = (cm_error >> 0) & 7;
 
                                 snprintf(buf, sizeof(buf),
                                          "CCA=%lu TR=%s MCmd=%s STag=%lu "
                                          "SPort=%lu\n",
-                                         cca_bits, tr[tr_bits], mcmd[mcmd_bits],
+                                         cca_bits, tr[tr_bits], mcmd[cmd_bits],
                                          stag_bits, sport_bits);
                         } else {
                                 /* glob state & sresp together */
@@ -740,7 +737,7 @@ int malta_be_handler(struct pt_regs *regs, int is_fixup)
                                 unsigned long c1_bits = (cm_error >> 12) & 7;
                                 unsigned long c0_bits = (cm_error >> 9) & 7;
                                 unsigned long sc_bit = (cm_error >> 8) & 1;
-                                unsigned long mcmd_bits = (cm_error >> 3) & 0x1f;
+                                unsigned long cmd_bits = (cm_error >> 3) & 0x1f;
                                 unsigned long sport_bits = (cm_error >> 0) & 7;
                                 snprintf(buf, sizeof(buf),
                                          "C3=%s C2=%s C1=%s C0=%s SC=%s "
@@ -748,16 +745,16 @@ int malta_be_handler(struct pt_regs *regs, int is_fixup)
                                          core[c3_bits], core[c2_bits],
                                          core[c1_bits], core[c0_bits],
                                          sc_bit ? "True" : "False",
-                                         mcmd[mcmd_bits], sport_bits);
+                                         mcmd[cmd_bits], sport_bits);
                         }
 
                         ocause = (cm_other & GCMP_GCB_GMEO_ERROR_2ND_MSK) >>
                                  GCMP_GCB_GMEO_ERROR_2ND_SHF;
 
-                        printk("CM_ERROR=%08lx %s <%s>\n", cm_error,
+                        pr_err("CM_ERROR=%08lx %s <%s>\n", cm_error,
                                causes[cause], buf);
-                        printk("CM_ADDR =%08lx\n", cm_addr);
-                        printk("CM_OTHER=%08lx %s\n", cm_other, causes[ocause]);
+                        pr_err("CM_ADDR =%08lx\n", cm_addr);
+                        pr_err("CM_OTHER=%08lx %s\n", cm_other, causes[ocause]);
 
                         /* reprime cause register */
                         GCMPGCB(GCMEC) = 0;