diff options
author | Ralf Baechle <ralf@linux-mips.org> | 2009-03-30 08:49:44 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2009-03-30 08:49:44 -0400 |
commit | b72b7092f8f5f0729cc9f0868997351f21dbc5cd (patch) | |
tree | e384dbc5a43d4a2288360a8ccf6a48f7ba9dfcb4 /arch/mips/mm | |
parent | ae03550500654e95c47229775bfec33ed0effe40 (diff) |
MIPS: Use BUG_ON() where possible.
Based on original patch by Stoyan Gaydarov <stoyboyker@gmail.com> which
missed a few places.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/mm')
-rw-r--r-- | arch/mips/mm/highmem.c | 9 | ||||
-rw-r--r-- | arch/mips/mm/init.c | 3 | ||||
-rw-r--r-- | arch/mips/mm/ioremap.c | 9 |
3 files changed, 7 insertions, 14 deletions
diff --git a/arch/mips/mm/highmem.c b/arch/mips/mm/highmem.c index 8f2cd8eda741..060d28dca8a8 100644 --- a/arch/mips/mm/highmem.c +++ b/arch/mips/mm/highmem.c | |||
@@ -17,8 +17,7 @@ void *__kmap(struct page *page) | |||
17 | 17 | ||
18 | void __kunmap(struct page *page) | 18 | void __kunmap(struct page *page) |
19 | { | 19 | { |
20 | if (in_interrupt()) | 20 | BUG_ON(in_interrupt()); |
21 | BUG(); | ||
22 | if (!PageHighMem(page)) | 21 | if (!PageHighMem(page)) |
23 | return; | 22 | return; |
24 | kunmap_high(page); | 23 | kunmap_high(page); |
@@ -46,8 +45,7 @@ void *__kmap_atomic(struct page *page, enum km_type type) | |||
46 | idx = type + KM_TYPE_NR*smp_processor_id(); | 45 | idx = type + KM_TYPE_NR*smp_processor_id(); |
47 | vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); | 46 | vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); |
48 | #ifdef CONFIG_DEBUG_HIGHMEM | 47 | #ifdef CONFIG_DEBUG_HIGHMEM |
49 | if (!pte_none(*(kmap_pte-idx))) | 48 | BUG_ON(!pte_none(*(kmap_pte - idx))); |
50 | BUG(); | ||
51 | #endif | 49 | #endif |
52 | set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); | 50 | set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); |
53 | local_flush_tlb_one((unsigned long)vaddr); | 51 | local_flush_tlb_one((unsigned long)vaddr); |
@@ -66,8 +64,7 @@ void __kunmap_atomic(void *kvaddr, enum km_type type) | |||
66 | return; | 64 | return; |
67 | } | 65 | } |
68 | 66 | ||
69 | if (vaddr != __fix_to_virt(FIX_KMAP_BEGIN+idx)) | 67 | BUG_ON(vaddr != __fix_to_virt(FIX_KMAP_BEGIN + idx)); |
70 | BUG(); | ||
71 | 68 | ||
72 | /* | 69 | /* |
73 | * force other mappings to Oops if they'll try to access | 70 | * force other mappings to Oops if they'll try to access |
diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c index 137c14bafd6b..d9348946a19e 100644 --- a/arch/mips/mm/init.c +++ b/arch/mips/mm/init.c | |||
@@ -307,8 +307,7 @@ void __init fixrange_init(unsigned long start, unsigned long end, | |||
307 | if (pmd_none(*pmd)) { | 307 | if (pmd_none(*pmd)) { |
308 | pte = (pte_t *) alloc_bootmem_low_pages(PAGE_SIZE); | 308 | pte = (pte_t *) alloc_bootmem_low_pages(PAGE_SIZE); |
309 | set_pmd(pmd, __pmd((unsigned long)pte)); | 309 | set_pmd(pmd, __pmd((unsigned long)pte)); |
310 | if (pte != pte_offset_kernel(pmd, 0)) | 310 | BUG_ON(pte != pte_offset_kernel(pmd, 0)); |
311 | BUG(); | ||
312 | } | 311 | } |
313 | vaddr += PMD_SIZE; | 312 | vaddr += PMD_SIZE; |
314 | } | 313 | } |
diff --git a/arch/mips/mm/ioremap.c b/arch/mips/mm/ioremap.c index 59945b9ee23c..0c43248347bd 100644 --- a/arch/mips/mm/ioremap.c +++ b/arch/mips/mm/ioremap.c | |||
@@ -27,8 +27,7 @@ static inline void remap_area_pte(pte_t * pte, unsigned long address, | |||
27 | end = address + size; | 27 | end = address + size; |
28 | if (end > PMD_SIZE) | 28 | if (end > PMD_SIZE) |
29 | end = PMD_SIZE; | 29 | end = PMD_SIZE; |
30 | if (address >= end) | 30 | BUG_ON(address >= end); |
31 | BUG(); | ||
32 | pfn = phys_addr >> PAGE_SHIFT; | 31 | pfn = phys_addr >> PAGE_SHIFT; |
33 | do { | 32 | do { |
34 | if (!pte_none(*pte)) { | 33 | if (!pte_none(*pte)) { |
@@ -52,8 +51,7 @@ static inline int remap_area_pmd(pmd_t * pmd, unsigned long address, | |||
52 | if (end > PGDIR_SIZE) | 51 | if (end > PGDIR_SIZE) |
53 | end = PGDIR_SIZE; | 52 | end = PGDIR_SIZE; |
54 | phys_addr -= address; | 53 | phys_addr -= address; |
55 | if (address >= end) | 54 | BUG_ON(address >= end); |
56 | BUG(); | ||
57 | do { | 55 | do { |
58 | pte_t * pte = pte_alloc_kernel(pmd, address); | 56 | pte_t * pte = pte_alloc_kernel(pmd, address); |
59 | if (!pte) | 57 | if (!pte) |
@@ -75,8 +73,7 @@ static int remap_area_pages(unsigned long address, phys_t phys_addr, | |||
75 | phys_addr -= address; | 73 | phys_addr -= address; |
76 | dir = pgd_offset(&init_mm, address); | 74 | dir = pgd_offset(&init_mm, address); |
77 | flush_cache_all(); | 75 | flush_cache_all(); |
78 | if (address >= end) | 76 | BUG_ON(address >= end); |
79 | BUG(); | ||
80 | do { | 77 | do { |
81 | pud_t *pud; | 78 | pud_t *pud; |
82 | pmd_t *pmd; | 79 | pmd_t *pmd; |