diff options
| author | David Daney <ddaney@caviumnetworks.com> | 2009-03-27 13:07:02 -0400 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2009-03-30 08:49:39 -0400 |
| commit | 0e6826c73c9aa785ec58b52613df7699fb31af9a (patch) | |
| tree | a85de8026984bbe94bf8ebc49873fcf0367782d9 /arch/mips/include/asm/spinlock.h | |
| parent | f5fd02a33e9a53480c7c489d3210b144d24da24e (diff) | |
MIPS: __raw_spin_lock() may spin forever on ticket wrap.
If the lock is not acquired and has to spin *and* the second attempt
to acquire the lock fails, the delay time is not masked by the ticket
range mask. If the ticket number wraps around to zero, the result is
that the lock sampling delay is essentially infinite (due to casting
-1 to an unsigned int).
The fix: Always mask the difference between my_ticket and the current
ticket value before calculating the delay.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/include/asm/spinlock.h')
| -rw-r--r-- | arch/mips/include/asm/spinlock.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/mips/include/asm/spinlock.h b/arch/mips/include/asm/spinlock.h index 0884947ebe27..10e82441b496 100644 --- a/arch/mips/include/asm/spinlock.h +++ b/arch/mips/include/asm/spinlock.h | |||
| @@ -76,7 +76,7 @@ static inline void __raw_spin_lock(raw_spinlock_t *lock) | |||
| 76 | "2: \n" | 76 | "2: \n" |
| 77 | " .subsection 2 \n" | 77 | " .subsection 2 \n" |
| 78 | "4: andi %[ticket], %[ticket], 0x1fff \n" | 78 | "4: andi %[ticket], %[ticket], 0x1fff \n" |
| 79 | "5: sll %[ticket], 5 \n" | 79 | " sll %[ticket], 5 \n" |
| 80 | " \n" | 80 | " \n" |
| 81 | "6: bnez %[ticket], 6b \n" | 81 | "6: bnez %[ticket], 6b \n" |
| 82 | " subu %[ticket], 1 \n" | 82 | " subu %[ticket], 1 \n" |
| @@ -85,7 +85,7 @@ static inline void __raw_spin_lock(raw_spinlock_t *lock) | |||
| 85 | " andi %[ticket], %[ticket], 0x1fff \n" | 85 | " andi %[ticket], %[ticket], 0x1fff \n" |
| 86 | " beq %[ticket], %[my_ticket], 2b \n" | 86 | " beq %[ticket], %[my_ticket], 2b \n" |
| 87 | " subu %[ticket], %[my_ticket], %[ticket] \n" | 87 | " subu %[ticket], %[my_ticket], %[ticket] \n" |
| 88 | " b 5b \n" | 88 | " b 4b \n" |
| 89 | " subu %[ticket], %[ticket], 1 \n" | 89 | " subu %[ticket], %[ticket], 1 \n" |
| 90 | " .previous \n" | 90 | " .previous \n" |
| 91 | " .set pop \n" | 91 | " .set pop \n" |
| @@ -113,7 +113,7 @@ static inline void __raw_spin_lock(raw_spinlock_t *lock) | |||
| 113 | " ll %[ticket], %[ticket_ptr] \n" | 113 | " ll %[ticket], %[ticket_ptr] \n" |
| 114 | " \n" | 114 | " \n" |
| 115 | "4: andi %[ticket], %[ticket], 0x1fff \n" | 115 | "4: andi %[ticket], %[ticket], 0x1fff \n" |
| 116 | "5: sll %[ticket], 5 \n" | 116 | " sll %[ticket], 5 \n" |
| 117 | " \n" | 117 | " \n" |
| 118 | "6: bnez %[ticket], 6b \n" | 118 | "6: bnez %[ticket], 6b \n" |
| 119 | " subu %[ticket], 1 \n" | 119 | " subu %[ticket], 1 \n" |
| @@ -122,7 +122,7 @@ static inline void __raw_spin_lock(raw_spinlock_t *lock) | |||
| 122 | " andi %[ticket], %[ticket], 0x1fff \n" | 122 | " andi %[ticket], %[ticket], 0x1fff \n" |
| 123 | " beq %[ticket], %[my_ticket], 2b \n" | 123 | " beq %[ticket], %[my_ticket], 2b \n" |
| 124 | " subu %[ticket], %[my_ticket], %[ticket] \n" | 124 | " subu %[ticket], %[my_ticket], %[ticket] \n" |
| 125 | " b 5b \n" | 125 | " b 4b \n" |
| 126 | " subu %[ticket], %[ticket], 1 \n" | 126 | " subu %[ticket], %[ticket], 1 \n" |
| 127 | " .previous \n" | 127 | " .previous \n" |
| 128 | " .set pop \n" | 128 | " .set pop \n" |