diff options
author | David Daney <david.daney@cavium.com> | 2012-08-10 19:00:31 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2012-08-17 04:57:26 -0400 |
commit | 87161ccdc61862c8b49e75c21209d7f79dc758e9 (patch) | |
tree | 0d4b4be9fb7b4feadd9cacc9e61a3d852c7b0524 /arch/mips/include/asm/mach-cavium-octeon | |
parent | d9875690d9b89a866022ff49e3fcea892345ad92 (diff) |
MIPS: Octeon: Fix broken interrupt controller code.
Since 3.6.0-rc1, We are getting many messages like:
WARNING: at kernel/irq/irqdomain.c:444 irq_domain_associate_many+0x23c/0x260()
Modules linked in:
Call Trace:
[<ffffffff814cb698>] dump_stack+0x8/0x34
[<ffffffff81133d00>] warn_slowpath_common+0x78/0xa8
[<ffffffff81187e44>] irq_domain_associate_many+0x23c/0x260
[<ffffffff81187f38>] irq_create_mapping+0xd0/0x220
[<ffffffff81188104>] irq_create_of_mapping+0x7c/0x158
[<ffffffff813e5f08>] irq_of_parse_and_map+0x28/0x40
.
.
.
Both the CIU and GPIO interrupt domains were somewhat screwed up.
For the CIU domain, we need to call irq_domain_associate() for each of
the preassigned irq numbers. For the GPIO domain, we were applying
the register bit offset in octeon_irq_gpio_xlat, but it should be done
in octeon_irq_gpio_map instead.
Also: Reserve all 8 'core' irqs for the 'core' irq_chip so that they
don't get used by the other domains. Remove unused OCTEON_IRQ_*
symbols.
Signed-off-by: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/4190/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/include/asm/mach-cavium-octeon')
-rw-r--r-- | arch/mips/include/asm/mach-cavium-octeon/irq.h | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/arch/mips/include/asm/mach-cavium-octeon/irq.h b/arch/mips/include/asm/mach-cavium-octeon/irq.h index 418992042f6f..c22a3078bf11 100644 --- a/arch/mips/include/asm/mach-cavium-octeon/irq.h +++ b/arch/mips/include/asm/mach-cavium-octeon/irq.h | |||
@@ -21,14 +21,10 @@ enum octeon_irq { | |||
21 | OCTEON_IRQ_TIMER, | 21 | OCTEON_IRQ_TIMER, |
22 | /* sources in CIU_INTX_EN0 */ | 22 | /* sources in CIU_INTX_EN0 */ |
23 | OCTEON_IRQ_WORKQ0, | 23 | OCTEON_IRQ_WORKQ0, |
24 | OCTEON_IRQ_GPIO0 = OCTEON_IRQ_WORKQ0 + 16, | 24 | OCTEON_IRQ_WDOG0 = OCTEON_IRQ_WORKQ0 + 16, |
25 | OCTEON_IRQ_WDOG0 = OCTEON_IRQ_GPIO0 + 16, | ||
26 | OCTEON_IRQ_WDOG15 = OCTEON_IRQ_WDOG0 + 15, | 25 | OCTEON_IRQ_WDOG15 = OCTEON_IRQ_WDOG0 + 15, |
27 | OCTEON_IRQ_MBOX0 = OCTEON_IRQ_WDOG0 + 16, | 26 | OCTEON_IRQ_MBOX0 = OCTEON_IRQ_WDOG0 + 16, |
28 | OCTEON_IRQ_MBOX1, | 27 | OCTEON_IRQ_MBOX1, |
29 | OCTEON_IRQ_UART0, | ||
30 | OCTEON_IRQ_UART1, | ||
31 | OCTEON_IRQ_UART2, | ||
32 | OCTEON_IRQ_PCI_INT0, | 28 | OCTEON_IRQ_PCI_INT0, |
33 | OCTEON_IRQ_PCI_INT1, | 29 | OCTEON_IRQ_PCI_INT1, |
34 | OCTEON_IRQ_PCI_INT2, | 30 | OCTEON_IRQ_PCI_INT2, |
@@ -38,8 +34,6 @@ enum octeon_irq { | |||
38 | OCTEON_IRQ_PCI_MSI2, | 34 | OCTEON_IRQ_PCI_MSI2, |
39 | OCTEON_IRQ_PCI_MSI3, | 35 | OCTEON_IRQ_PCI_MSI3, |
40 | 36 | ||
41 | OCTEON_IRQ_TWSI, | ||
42 | OCTEON_IRQ_TWSI2, | ||
43 | OCTEON_IRQ_RML, | 37 | OCTEON_IRQ_RML, |
44 | OCTEON_IRQ_TIMER0, | 38 | OCTEON_IRQ_TIMER0, |
45 | OCTEON_IRQ_TIMER1, | 39 | OCTEON_IRQ_TIMER1, |
@@ -47,8 +41,6 @@ enum octeon_irq { | |||
47 | OCTEON_IRQ_TIMER3, | 41 | OCTEON_IRQ_TIMER3, |
48 | OCTEON_IRQ_USB0, | 42 | OCTEON_IRQ_USB0, |
49 | OCTEON_IRQ_USB1, | 43 | OCTEON_IRQ_USB1, |
50 | OCTEON_IRQ_MII0, | ||
51 | OCTEON_IRQ_MII1, | ||
52 | OCTEON_IRQ_BOOTDMA, | 44 | OCTEON_IRQ_BOOTDMA, |
53 | #ifndef CONFIG_PCI_MSI | 45 | #ifndef CONFIG_PCI_MSI |
54 | OCTEON_IRQ_LAST = 127 | 46 | OCTEON_IRQ_LAST = 127 |