diff options
author | Julia Lawall <julia@diku.dk> | 2008-07-17 15:16:34 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-20 20:24:40 -0400 |
commit | 93026e217b46b70f9719caf69e716fa3bbe1d20c (patch) | |
tree | 25b927d68c9aff1cb306cf46d4c2460c12da9547 /arch/m68k/mm | |
parent | 7b6b948fc0d60a704c15b1cd72345a98e759dd62 (diff) |
arch/m68k/mm/sun3mmu.c: Eliminate NULL test and memset after alloc_bootmem
As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b,
alloc_bootmem and related functions never return NULL and always return a
zeroed region of memory. Thus a NULL test or memset after calls to these
functions is unnecessary.
This was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E;
statement S;
@@
E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
.. when != E
(
- BUG_ON (E == NULL);
|
- if (E == NULL) S
)
@@
expression E,E1;
@@
E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
.. when != E
- memset(E,0,E1);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/m68k/mm')
-rw-r--r-- | arch/m68k/mm/sun3mmu.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/m68k/mm/sun3mmu.c b/arch/m68k/mm/sun3mmu.c index 6a6513aa1ce8..edceefc18870 100644 --- a/arch/m68k/mm/sun3mmu.c +++ b/arch/m68k/mm/sun3mmu.c | |||
@@ -53,7 +53,6 @@ void __init paging_init(void) | |||
53 | wp_works_ok = 0; | 53 | wp_works_ok = 0; |
54 | #endif | 54 | #endif |
55 | empty_zero_page = alloc_bootmem_pages(PAGE_SIZE); | 55 | empty_zero_page = alloc_bootmem_pages(PAGE_SIZE); |
56 | memset(empty_zero_page, 0, PAGE_SIZE); | ||
57 | 56 | ||
58 | address = PAGE_OFFSET; | 57 | address = PAGE_OFFSET; |
59 | pg_dir = swapper_pg_dir; | 58 | pg_dir = swapper_pg_dir; |