diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2010-09-22 13:13:16 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2011-01-21 05:55:26 -0500 |
commit | 863018a7a24a29c0862c62e70c89244fdd5a08bf (patch) | |
tree | 951f3e7bc9a6829183f322c34deb0e250e52a2d9 /arch/m32r/platforms/m32700ut/setup.c | |
parent | 30139785e615c97497864a89511db02839fa7bf5 (diff) |
m32r: Cleanup direct irq_desc access
The irq descriptors are already initialized by the generic
code. Remove the redundant init code and set the irq chip with the
proper accessor function.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Cc: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'arch/m32r/platforms/m32700ut/setup.c')
-rw-r--r-- | arch/m32r/platforms/m32700ut/setup.c | 74 |
1 files changed, 16 insertions, 58 deletions
diff --git a/arch/m32r/platforms/m32700ut/setup.c b/arch/m32r/platforms/m32700ut/setup.c index 80b1a026795a..433bcbca2c3a 100644 --- a/arch/m32r/platforms/m32700ut/setup.c +++ b/arch/m32r/platforms/m32700ut/setup.c | |||
@@ -299,101 +299,65 @@ void __init init_IRQ(void) | |||
299 | { | 299 | { |
300 | #if defined(CONFIG_SMC91X) | 300 | #if defined(CONFIG_SMC91X) |
301 | /* INT#0: LAN controller on M32700UT-LAN (SMC91C111)*/ | 301 | /* INT#0: LAN controller on M32700UT-LAN (SMC91C111)*/ |
302 | irq_desc[M32700UT_LAN_IRQ_LAN].status = IRQ_DISABLED; | 302 | set_irq_chip(M32700UT_LAN_IRQ_LAN, &m32700ut_lanpld_irq_type); |
303 | irq_desc[M32700UT_LAN_IRQ_LAN].chip = &m32700ut_lanpld_irq_type; | ||
304 | irq_desc[M32700UT_LAN_IRQ_LAN].action = 0; | ||
305 | irq_desc[M32700UT_LAN_IRQ_LAN].depth = 1; /* disable nested irq */ | ||
306 | lanpld_icu_data[irq2lanpldirq(M32700UT_LAN_IRQ_LAN)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD02; /* "H" edge sense */ | 303 | lanpld_icu_data[irq2lanpldirq(M32700UT_LAN_IRQ_LAN)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD02; /* "H" edge sense */ |
307 | disable_m32700ut_lanpld_irq(M32700UT_LAN_IRQ_LAN); | 304 | disable_m32700ut_lanpld_irq(M32700UT_LAN_IRQ_LAN); |
308 | #endif /* CONFIG_SMC91X */ | 305 | #endif /* CONFIG_SMC91X */ |
309 | 306 | ||
310 | /* MFT2 : system timer */ | 307 | /* MFT2 : system timer */ |
311 | irq_desc[M32R_IRQ_MFT2].status = IRQ_DISABLED; | 308 | set_irq_chip(M32R_IRQ_MFT2, &m32700ut_irq_type); |
312 | irq_desc[M32R_IRQ_MFT2].chip = &m32700ut_irq_type; | ||
313 | irq_desc[M32R_IRQ_MFT2].action = 0; | ||
314 | irq_desc[M32R_IRQ_MFT2].depth = 1; | ||
315 | icu_data[M32R_IRQ_MFT2].icucr = M32R_ICUCR_IEN; | 309 | icu_data[M32R_IRQ_MFT2].icucr = M32R_ICUCR_IEN; |
316 | disable_m32700ut_irq(M32R_IRQ_MFT2); | 310 | disable_m32700ut_irq(M32R_IRQ_MFT2); |
317 | 311 | ||
318 | /* SIO0 : receive */ | 312 | /* SIO0 : receive */ |
319 | irq_desc[M32R_IRQ_SIO0_R].status = IRQ_DISABLED; | 313 | set_irq_chip(M32R_IRQ_SIO0_R, &m32700ut_irq_type); |
320 | irq_desc[M32R_IRQ_SIO0_R].chip = &m32700ut_irq_type; | ||
321 | irq_desc[M32R_IRQ_SIO0_R].action = 0; | ||
322 | irq_desc[M32R_IRQ_SIO0_R].depth = 1; | ||
323 | icu_data[M32R_IRQ_SIO0_R].icucr = 0; | 314 | icu_data[M32R_IRQ_SIO0_R].icucr = 0; |
324 | disable_m32700ut_irq(M32R_IRQ_SIO0_R); | 315 | disable_m32700ut_irq(M32R_IRQ_SIO0_R); |
325 | 316 | ||
326 | /* SIO0 : send */ | 317 | /* SIO0 : send */ |
327 | irq_desc[M32R_IRQ_SIO0_S].status = IRQ_DISABLED; | 318 | set_irq_chip(M32R_IRQ_SIO0_S, &m32700ut_irq_type); |
328 | irq_desc[M32R_IRQ_SIO0_S].chip = &m32700ut_irq_type; | ||
329 | irq_desc[M32R_IRQ_SIO0_S].action = 0; | ||
330 | irq_desc[M32R_IRQ_SIO0_S].depth = 1; | ||
331 | icu_data[M32R_IRQ_SIO0_S].icucr = 0; | 319 | icu_data[M32R_IRQ_SIO0_S].icucr = 0; |
332 | disable_m32700ut_irq(M32R_IRQ_SIO0_S); | 320 | disable_m32700ut_irq(M32R_IRQ_SIO0_S); |
333 | 321 | ||
334 | /* SIO1 : receive */ | 322 | /* SIO1 : receive */ |
335 | irq_desc[M32R_IRQ_SIO1_R].status = IRQ_DISABLED; | 323 | set_irq_chip(M32R_IRQ_SIO1_R, &m32700ut_irq_type); |
336 | irq_desc[M32R_IRQ_SIO1_R].chip = &m32700ut_irq_type; | ||
337 | irq_desc[M32R_IRQ_SIO1_R].action = 0; | ||
338 | irq_desc[M32R_IRQ_SIO1_R].depth = 1; | ||
339 | icu_data[M32R_IRQ_SIO1_R].icucr = 0; | 324 | icu_data[M32R_IRQ_SIO1_R].icucr = 0; |
340 | disable_m32700ut_irq(M32R_IRQ_SIO1_R); | 325 | disable_m32700ut_irq(M32R_IRQ_SIO1_R); |
341 | 326 | ||
342 | /* SIO1 : send */ | 327 | /* SIO1 : send */ |
343 | irq_desc[M32R_IRQ_SIO1_S].status = IRQ_DISABLED; | 328 | set_irq_chip(M32R_IRQ_SIO1_S, &m32700ut_irq_type); |
344 | irq_desc[M32R_IRQ_SIO1_S].chip = &m32700ut_irq_type; | ||
345 | irq_desc[M32R_IRQ_SIO1_S].action = 0; | ||
346 | irq_desc[M32R_IRQ_SIO1_S].depth = 1; | ||
347 | icu_data[M32R_IRQ_SIO1_S].icucr = 0; | 329 | icu_data[M32R_IRQ_SIO1_S].icucr = 0; |
348 | disable_m32700ut_irq(M32R_IRQ_SIO1_S); | 330 | disable_m32700ut_irq(M32R_IRQ_SIO1_S); |
349 | 331 | ||
350 | /* DMA1 : */ | 332 | /* DMA1 : */ |
351 | irq_desc[M32R_IRQ_DMA1].status = IRQ_DISABLED; | 333 | set_irq_chip(M32R_IRQ_DMA1, &m32700ut_irq_type); |
352 | irq_desc[M32R_IRQ_DMA1].chip = &m32700ut_irq_type; | ||
353 | irq_desc[M32R_IRQ_DMA1].action = 0; | ||
354 | irq_desc[M32R_IRQ_DMA1].depth = 1; | ||
355 | icu_data[M32R_IRQ_DMA1].icucr = 0; | 334 | icu_data[M32R_IRQ_DMA1].icucr = 0; |
356 | disable_m32700ut_irq(M32R_IRQ_DMA1); | 335 | disable_m32700ut_irq(M32R_IRQ_DMA1); |
357 | 336 | ||
358 | #ifdef CONFIG_SERIAL_M32R_PLDSIO | 337 | #ifdef CONFIG_SERIAL_M32R_PLDSIO |
359 | /* INT#1: SIO0 Receive on PLD */ | 338 | /* INT#1: SIO0 Receive on PLD */ |
360 | irq_desc[PLD_IRQ_SIO0_RCV].status = IRQ_DISABLED; | 339 | set_irq_chip(PLD_IRQ_SIO0_RCV, &m32700ut_pld_irq_type); |
361 | irq_desc[PLD_IRQ_SIO0_RCV].chip = &m32700ut_pld_irq_type; | ||
362 | irq_desc[PLD_IRQ_SIO0_RCV].action = 0; | ||
363 | irq_desc[PLD_IRQ_SIO0_RCV].depth = 1; /* disable nested irq */ | ||
364 | pld_icu_data[irq2pldirq(PLD_IRQ_SIO0_RCV)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD03; | 340 | pld_icu_data[irq2pldirq(PLD_IRQ_SIO0_RCV)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD03; |
365 | disable_m32700ut_pld_irq(PLD_IRQ_SIO0_RCV); | 341 | disable_m32700ut_pld_irq(PLD_IRQ_SIO0_RCV); |
366 | 342 | ||
367 | /* INT#1: SIO0 Send on PLD */ | 343 | /* INT#1: SIO0 Send on PLD */ |
368 | irq_desc[PLD_IRQ_SIO0_SND].status = IRQ_DISABLED; | 344 | set_irq_chip(PLD_IRQ_SIO0_SND, &m32700ut_pld_irq_type); |
369 | irq_desc[PLD_IRQ_SIO0_SND].chip = &m32700ut_pld_irq_type; | ||
370 | irq_desc[PLD_IRQ_SIO0_SND].action = 0; | ||
371 | irq_desc[PLD_IRQ_SIO0_SND].depth = 1; /* disable nested irq */ | ||
372 | pld_icu_data[irq2pldirq(PLD_IRQ_SIO0_SND)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD03; | 345 | pld_icu_data[irq2pldirq(PLD_IRQ_SIO0_SND)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD03; |
373 | disable_m32700ut_pld_irq(PLD_IRQ_SIO0_SND); | 346 | disable_m32700ut_pld_irq(PLD_IRQ_SIO0_SND); |
374 | #endif /* CONFIG_SERIAL_M32R_PLDSIO */ | 347 | #endif /* CONFIG_SERIAL_M32R_PLDSIO */ |
375 | 348 | ||
376 | /* INT#1: CFC IREQ on PLD */ | 349 | /* INT#1: CFC IREQ on PLD */ |
377 | irq_desc[PLD_IRQ_CFIREQ].status = IRQ_DISABLED; | 350 | set_irq_chip(PLD_IRQ_CFIREQ, &m32700ut_pld_irq_type); |
378 | irq_desc[PLD_IRQ_CFIREQ].chip = &m32700ut_pld_irq_type; | ||
379 | irq_desc[PLD_IRQ_CFIREQ].action = 0; | ||
380 | irq_desc[PLD_IRQ_CFIREQ].depth = 1; /* disable nested irq */ | ||
381 | pld_icu_data[irq2pldirq(PLD_IRQ_CFIREQ)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD01; /* 'L' level sense */ | 351 | pld_icu_data[irq2pldirq(PLD_IRQ_CFIREQ)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD01; /* 'L' level sense */ |
382 | disable_m32700ut_pld_irq(PLD_IRQ_CFIREQ); | 352 | disable_m32700ut_pld_irq(PLD_IRQ_CFIREQ); |
383 | 353 | ||
384 | /* INT#1: CFC Insert on PLD */ | 354 | /* INT#1: CFC Insert on PLD */ |
385 | irq_desc[PLD_IRQ_CFC_INSERT].status = IRQ_DISABLED; | 355 | set_irq_chip(PLD_IRQ_CFC_INSERT, &m32700ut_pld_irq_type); |
386 | irq_desc[PLD_IRQ_CFC_INSERT].chip = &m32700ut_pld_irq_type; | ||
387 | irq_desc[PLD_IRQ_CFC_INSERT].action = 0; | ||
388 | irq_desc[PLD_IRQ_CFC_INSERT].depth = 1; /* disable nested irq */ | ||
389 | pld_icu_data[irq2pldirq(PLD_IRQ_CFC_INSERT)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD00; /* 'L' edge sense */ | 356 | pld_icu_data[irq2pldirq(PLD_IRQ_CFC_INSERT)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD00; /* 'L' edge sense */ |
390 | disable_m32700ut_pld_irq(PLD_IRQ_CFC_INSERT); | 357 | disable_m32700ut_pld_irq(PLD_IRQ_CFC_INSERT); |
391 | 358 | ||
392 | /* INT#1: CFC Eject on PLD */ | 359 | /* INT#1: CFC Eject on PLD */ |
393 | irq_desc[PLD_IRQ_CFC_EJECT].status = IRQ_DISABLED; | 360 | set_irq_chip(PLD_IRQ_CFC_EJECT, &m32700ut_pld_irq_type); |
394 | irq_desc[PLD_IRQ_CFC_EJECT].chip = &m32700ut_pld_irq_type; | ||
395 | irq_desc[PLD_IRQ_CFC_EJECT].action = 0; | ||
396 | irq_desc[PLD_IRQ_CFC_EJECT].depth = 1; /* disable nested irq */ | ||
397 | pld_icu_data[irq2pldirq(PLD_IRQ_CFC_EJECT)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD02; /* 'H' edge sense */ | 361 | pld_icu_data[irq2pldirq(PLD_IRQ_CFC_EJECT)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD02; /* 'H' edge sense */ |
398 | disable_m32700ut_pld_irq(PLD_IRQ_CFC_EJECT); | 362 | disable_m32700ut_pld_irq(PLD_IRQ_CFC_EJECT); |
399 | 363 | ||
@@ -413,13 +377,10 @@ void __init init_IRQ(void) | |||
413 | 377 | ||
414 | #if defined(CONFIG_USB) | 378 | #if defined(CONFIG_USB) |
415 | outw(USBCR_OTGS, USBCR); /* USBCR: non-OTG */ | 379 | outw(USBCR_OTGS, USBCR); /* USBCR: non-OTG */ |
380 | set_irq_chip(M32700UT_LCD_IRQ_USB_INT1, &m32700ut_lcdpld_irq_type); | ||
416 | 381 | ||
417 | irq_desc[M32700UT_LCD_IRQ_USB_INT1].status = IRQ_DISABLED; | 382 | lcdpld_icu_data[irq2lcdpldirq(M32700UT_LCD_IRQ_USB_INT1)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD01; /* "L" level sense */ |
418 | irq_desc[M32700UT_LCD_IRQ_USB_INT1].chip = &m32700ut_lcdpld_irq_type; | 383 | disable_m32700ut_lcdpld_irq(M32700UT_LCD_IRQ_USB_INT1); |
419 | irq_desc[M32700UT_LCD_IRQ_USB_INT1].action = 0; | ||
420 | irq_desc[M32700UT_LCD_IRQ_USB_INT1].depth = 1; | ||
421 | lcdpld_icu_data[irq2lcdpldirq(M32700UT_LCD_IRQ_USB_INT1)].icucr = PLD_ICUCR_IEN|PLD_ICUCR_ISMOD01; /* "L" level sense */ | ||
422 | disable_m32700ut_lcdpld_irq(M32700UT_LCD_IRQ_USB_INT1); | ||
423 | #endif | 384 | #endif |
424 | /* | 385 | /* |
425 | * INT2# is used for BAT, USB, AUDIO | 386 | * INT2# is used for BAT, USB, AUDIO |
@@ -432,10 +393,7 @@ void __init init_IRQ(void) | |||
432 | /* | 393 | /* |
433 | * INT3# is used for AR | 394 | * INT3# is used for AR |
434 | */ | 395 | */ |
435 | irq_desc[M32R_IRQ_INT3].status = IRQ_DISABLED; | 396 | set_irq_chip(M32R_IRQ_INT3, &m32700ut_irq_type); |
436 | irq_desc[M32R_IRQ_INT3].chip = &m32700ut_irq_type; | ||
437 | irq_desc[M32R_IRQ_INT3].action = 0; | ||
438 | irq_desc[M32R_IRQ_INT3].depth = 1; | ||
439 | icu_data[M32R_IRQ_INT3].icucr = M32R_ICUCR_IEN|M32R_ICUCR_ISMOD10; | 397 | icu_data[M32R_IRQ_INT3].icucr = M32R_ICUCR_IEN|M32R_ICUCR_ISMOD10; |
440 | disable_m32700ut_irq(M32R_IRQ_INT3); | 398 | disable_m32700ut_irq(M32R_IRQ_INT3); |
441 | #endif /* CONFIG_VIDEO_M32R_AR */ | 399 | #endif /* CONFIG_VIDEO_M32R_AR */ |