diff options
author | Marcelo Tosatti <mtosatti@redhat.com> | 2008-04-11 13:53:26 -0400 |
---|---|---|
committer | Avi Kivity <avi@qumranet.com> | 2008-04-27 05:04:11 -0400 |
commit | 3d80840d96127401ba6aeadd813c3a15b84e70fe (patch) | |
tree | b3e083c651f09fee362d88f0d1fc140194f2431d /arch/ia64 | |
parent | 3564990af1b9f77a63692c1079e9c41af229f066 (diff) |
KVM: hlt emulation should take in-kernel APIC/PIT timers into account
Timers that fire between guest hlt and vcpu_block's add_wait_queue() are
ignored, possibly resulting in hangs.
Also make sure that atomic_inc and waitqueue_active tests happen in the
specified order, otherwise the following race is open:
CPU0 CPU1
if (waitqueue_active(wq))
add_wait_queue()
if (!atomic_read(pit_timer->pending))
schedule()
atomic_inc(pit_timer->pending)
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Diffstat (limited to 'arch/ia64')
-rw-r--r-- | arch/ia64/kvm/kvm-ia64.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/arch/ia64/kvm/kvm-ia64.c b/arch/ia64/kvm/kvm-ia64.c index 9c56b6429cb6..ca1cfb124d4f 100644 --- a/arch/ia64/kvm/kvm-ia64.c +++ b/arch/ia64/kvm/kvm-ia64.c | |||
@@ -1778,6 +1778,11 @@ int kvm_cpu_has_interrupt(struct kvm_vcpu *vcpu) | |||
1778 | return 0; | 1778 | return 0; |
1779 | } | 1779 | } |
1780 | 1780 | ||
1781 | int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) | ||
1782 | { | ||
1783 | return 0; | ||
1784 | } | ||
1785 | |||
1781 | gfn_t unalias_gfn(struct kvm *kvm, gfn_t gfn) | 1786 | gfn_t unalias_gfn(struct kvm *kvm, gfn_t gfn) |
1782 | { | 1787 | { |
1783 | return gfn; | 1788 | return gfn; |