diff options
author | Lennert Buytenhek <buytenh@wantstofly.org> | 2006-07-10 07:45:27 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-07-10 16:24:25 -0400 |
commit | 06c67befeeb16f2995c11b0e04a348103ddbfab1 (patch) | |
tree | aad64fa9d2d03b1479885d1c703ccc5890b12afe /arch/ia64/pci/pci.c | |
parent | 49c0dab7e6000888b616bedcbbc8cd4710331610 (diff) |
[PATCH] make valid_mmap_phys_addr_range() take a pfn
Newer ARMs have a 40 bit physical address space, but mapping physical
memory above 4G needs a special page table format which we (currently?) do
not use for userspace mappings, so what happens instead is that mapping an
address >= 4G will happily discard the upper bits and wrap.
There is a valid_mmap_phys_addr_range() arch hook where we could check for
>= 4G addresses and deny the mapping, but this hook takes an unsigned long
address:
static inline int valid_mmap_phys_addr_range(unsigned long addr, size_t size);
And drivers/char/mem.c:mmap_mem() calls it like this:
static int mmap_mem(struct file * file, struct vm_area_struct * vma)
{
size_t size = vma->vm_end - vma->vm_start;
if (!valid_mmap_phys_addr_range(vma->vm_pgoff << PAGE_SHIFT, size))
So that's not much help either.
This patch makes the hook take a pfn instead of a phys address.
Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/ia64/pci/pci.c')
-rw-r--r-- | arch/ia64/pci/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 276512fd8922..60b45e79f080 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c | |||
@@ -650,7 +650,7 @@ pci_mmap_legacy_page_range(struct pci_bus *bus, struct vm_area_struct *vma) | |||
650 | * Avoid attribute aliasing. See Documentation/ia64/aliasing.txt | 650 | * Avoid attribute aliasing. See Documentation/ia64/aliasing.txt |
651 | * for more details. | 651 | * for more details. |
652 | */ | 652 | */ |
653 | if (!valid_mmap_phys_addr_range(vma->vm_pgoff << PAGE_SHIFT, size)) | 653 | if (!valid_mmap_phys_addr_range(vma->vm_pgoff, size)) |
654 | return -EINVAL; | 654 | return -EINVAL; |
655 | prot = phys_mem_access_prot(NULL, vma->vm_pgoff, size, | 655 | prot = phys_mem_access_prot(NULL, vma->vm_pgoff, size, |
656 | vma->vm_page_prot); | 656 | vma->vm_page_prot); |