diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2015-06-01 02:23:53 -0400 |
---|---|---|
committer | Tony Luck <tony.luck@intel.com> | 2015-06-02 13:07:03 -0400 |
commit | 5eda7861e347ffe927ecde5abd74d7b13ae938fa (patch) | |
tree | cd5018b6c1b4a2ccf584faaa2f74e642d973a28b /arch/ia64/kernel/smpboot.c | |
parent | c65b99f046843d2455aa231747b5a07a999a9f3d (diff) |
ia64: make cpu_callin_map non-volatile.
cpumask_test_cpu() doesn't take volatile, unlike the obsoleted
cpu_isset. The only place ia64 really cares is the spin waiting for a
bit; udelay() is probably a barrier but insert barrier() to be sure.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch/ia64/kernel/smpboot.c')
-rw-r--r-- | arch/ia64/kernel/smpboot.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c index 15051e9c2c6f..b054c5c6e713 100644 --- a/arch/ia64/kernel/smpboot.c +++ b/arch/ia64/kernel/smpboot.c | |||
@@ -127,7 +127,7 @@ int smp_num_siblings = 1; | |||
127 | volatile int ia64_cpu_to_sapicid[NR_CPUS]; | 127 | volatile int ia64_cpu_to_sapicid[NR_CPUS]; |
128 | EXPORT_SYMBOL(ia64_cpu_to_sapicid); | 128 | EXPORT_SYMBOL(ia64_cpu_to_sapicid); |
129 | 129 | ||
130 | static volatile cpumask_t cpu_callin_map; | 130 | static cpumask_t cpu_callin_map; |
131 | 131 | ||
132 | struct smp_boot_data smp_boot_data __initdata; | 132 | struct smp_boot_data smp_boot_data __initdata; |
133 | 133 | ||
@@ -477,6 +477,7 @@ do_boot_cpu (int sapicid, int cpu, struct task_struct *idle) | |||
477 | for (timeout = 0; timeout < 100000; timeout++) { | 477 | for (timeout = 0; timeout < 100000; timeout++) { |
478 | if (cpumask_test_cpu(cpu, &cpu_callin_map)) | 478 | if (cpumask_test_cpu(cpu, &cpu_callin_map)) |
479 | break; /* It has booted */ | 479 | break; /* It has booted */ |
480 | barrier(); /* Make sure we re-read cpu_callin_map */ | ||
480 | udelay(100); | 481 | udelay(100); |
481 | } | 482 | } |
482 | Dprintk("\n"); | 483 | Dprintk("\n"); |