aboutsummaryrefslogtreecommitdiffstats
path: root/arch/ia64/kernel/iosapic.c
diff options
context:
space:
mode:
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>2007-07-18 02:47:34 -0400
committerTony Luck <tony.luck@intel.com>2007-07-19 17:03:55 -0400
commitbf903d0a4503db8ac166ca6135a59bc5f9b91a45 (patch)
tree117a4dc0b1a1642b260651e2b81c366c886578e9 /arch/ia64/kernel/iosapic.c
parente5bd762bda0d9aba8739a35f898479dc12e288a1 (diff)
[IA64] Delete iosapic_free_rte()
> arch/ia64/kernel/iosapic.c:597: warning: 'iosapic_free_rte' defined but not used > > This isn't spurious, the only call to iosapic_free_rte() has been removed, but there > is still a call to iosapic_alloc_rte() ... which means we must have a memory leak. I did it on purpose (and gave the warning a miss...) and I consider iosapic_free_rte() is no longer needed. I decided to remain iosapic_rte_info to keep gsi-to-irq binding after device disable. Indeed it needs some extra memory, but it is only "sizeof(iosapic_rte_info) * <the number of removed devices>" bytes and has no memory leak becasue re-enabled devices use the iosapic_rte_info which they used before disabling. Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch/ia64/kernel/iosapic.c')
-rw-r--r--arch/ia64/kernel/iosapic.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c
index c101c8bff27b..91e6dc1e7baf 100644
--- a/arch/ia64/kernel/iosapic.c
+++ b/arch/ia64/kernel/iosapic.c
@@ -593,14 +593,6 @@ static struct iosapic_rte_info *iosapic_alloc_rte (void)
593 return rte; 593 return rte;
594} 594}
595 595
596static void iosapic_free_rte (struct iosapic_rte_info *rte)
597{
598 if (rte->flags & RTE_PREALLOCATED)
599 list_add_tail(&rte->rte_list, &free_rte_list);
600 else
601 kfree(rte);
602}
603
604static inline int irq_is_shared (int irq) 596static inline int irq_is_shared (int irq)
605{ 597{
606 return (iosapic_intr_info[irq].count > 1); 598 return (iosapic_intr_info[irq].count > 1);