diff options
author | Jiri Slaby <jslaby@suse.cz> | 2012-03-05 08:52:30 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 15:48:26 -0500 |
commit | 98e3a9e6dd99f1b8ac2a03b8b4942eec16ef911b (patch) | |
tree | 7c1c4e0e3d37c5e3f9105298f020f825f15e4dce /arch/ia64/hp | |
parent | d88405d44fd30fcbe77a9db540afd8823b30afdc (diff) |
TTY: simserial, stop using serial_state->{line,icount}
* instead of line, use tty->index or an iterator
* icount is not made public, only the tx path increments it
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/ia64/hp')
-rw-r--r-- | arch/ia64/hp/sim/simserial.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c index 45df0f427864..3698a2fe221d 100644 --- a/arch/ia64/hp/sim/simserial.c +++ b/arch/ia64/hp/sim/simserial.c | |||
@@ -176,7 +176,6 @@ static void transmit_chars(struct tty_struct *tty, struct serial_state *info, | |||
176 | 176 | ||
177 | console->write(console, &c, 1); | 177 | console->write(console, &c, 1); |
178 | 178 | ||
179 | info->icount.tx++; | ||
180 | info->x_char = 0; | 179 | info->x_char = 0; |
181 | 180 | ||
182 | goto out; | 181 | goto out; |
@@ -478,7 +477,7 @@ static void rs_close(struct tty_struct *tty, struct file * filp) | |||
478 | } | 477 | } |
479 | if (--info->tport.count < 0) { | 478 | if (--info->tport.count < 0) { |
480 | printk(KERN_ERR "rs_close: bad serial port count for ttys%d: %d\n", | 479 | printk(KERN_ERR "rs_close: bad serial port count for ttys%d: %d\n", |
481 | info->line, info->tport.count); | 480 | tty->index, info->tport.count); |
482 | info->tport.count = 0; | 481 | info->tport.count = 0; |
483 | } | 482 | } |
484 | if (info->tport.count) { | 483 | if (info->tport.count) { |
@@ -669,19 +668,14 @@ static int rs_open(struct tty_struct *tty, struct file * filp) | |||
669 | * /proc fs routines.... | 668 | * /proc fs routines.... |
670 | */ | 669 | */ |
671 | 670 | ||
672 | static inline void line_info(struct seq_file *m, struct serial_state *state) | ||
673 | { | ||
674 | seq_printf(m, "%d: uart:16550 port:3F8 irq:%d\n", | ||
675 | state->line, state->irq); | ||
676 | } | ||
677 | |||
678 | static int rs_proc_show(struct seq_file *m, void *v) | 671 | static int rs_proc_show(struct seq_file *m, void *v) |
679 | { | 672 | { |
680 | int i; | 673 | int i; |
681 | 674 | ||
682 | seq_printf(m, "simserinfo:1.0 driver:%s\n", serial_version); | 675 | seq_printf(m, "simserinfo:1.0 driver:%s\n", serial_version); |
683 | for (i = 0; i < NR_PORTS; i++) | 676 | for (i = 0; i < NR_PORTS; i++) |
684 | line_info(m, &rs_table[i]); | 677 | seq_printf(m, "%d: uart:16550 port:3F8 irq:%d\n", |
678 | i, rs_table[i].irq); | ||
685 | return 0; | 679 | return 0; |
686 | } | 680 | } |
687 | 681 | ||
@@ -786,8 +780,7 @@ static int __init simrs_init(void) | |||
786 | state->irq = retval; | 780 | state->irq = retval; |
787 | 781 | ||
788 | /* the port is imaginary */ | 782 | /* the port is imaginary */ |
789 | printk(KERN_INFO "ttyS%d at 0x03f8 (irq = %d) is a 16550\n", | 783 | printk(KERN_INFO "ttyS0 at 0x03f8 (irq = %d) is a 16550\n", state->irq); |
790 | state->line, state->irq); | ||
791 | 784 | ||
792 | retval = tty_register_driver(hp_simserial_driver); | 785 | retval = tty_register_driver(hp_simserial_driver); |
793 | if (retval) { | 786 | if (retval) { |