diff options
author | Andi Kleen <ak@suse.de> | 2007-02-13 07:26:23 -0500 |
---|---|---|
committer | Andi Kleen <andi@basil.nowhere.org> | 2007-02-13 07:26:23 -0500 |
commit | 8c40ad02e5b026902b8ce134f895b3b09803db39 (patch) | |
tree | f54320c2874e58d21c627063862af6953bf513e1 /arch/i386 | |
parent | 930f8b8bcde30b501fdf00fb7624aefb9bf35f47 (diff) |
[PATCH] i386: Small cleanup to TLB flush code
- Remove outdated comment
- Use cpu_relax() in a busy loop
Signed-off-by: Andi Kleen <ak@suse.de>
Diffstat (limited to 'arch/i386')
-rw-r--r-- | arch/i386/kernel/smp.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/i386/kernel/smp.c b/arch/i386/kernel/smp.c index ffc4f65c5189..9bd9637ae692 100644 --- a/arch/i386/kernel/smp.c +++ b/arch/i386/kernel/smp.c | |||
@@ -375,8 +375,7 @@ static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm, | |||
375 | /* | 375 | /* |
376 | * i'm not happy about this global shared spinlock in the | 376 | * i'm not happy about this global shared spinlock in the |
377 | * MM hot path, but we'll see how contended it is. | 377 | * MM hot path, but we'll see how contended it is. |
378 | * Temporarily this turns IRQs off, so that lockups are | 378 | * AK: x86-64 has a faster method that could be ported. |
379 | * detected by the NMI watchdog. | ||
380 | */ | 379 | */ |
381 | spin_lock(&tlbstate_lock); | 380 | spin_lock(&tlbstate_lock); |
382 | 381 | ||
@@ -401,7 +400,7 @@ static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm, | |||
401 | 400 | ||
402 | while (!cpus_empty(flush_cpumask)) | 401 | while (!cpus_empty(flush_cpumask)) |
403 | /* nothing. lockup detection does not belong here */ | 402 | /* nothing. lockup detection does not belong here */ |
404 | mb(); | 403 | cpu_relax(); |
405 | 404 | ||
406 | flush_mm = NULL; | 405 | flush_mm = NULL; |
407 | flush_va = 0; | 406 | flush_va = 0; |