diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-03 15:15:40 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-09 20:22:20 -0400 |
commit | 1855256c497ecfefc730df6032243f26855ce52c (patch) | |
tree | b73947f1a5e1b798e1dec068ac1cda25ae910bf6 /arch/i386/pci/common.c | |
parent | bbf25010f1a6b761914430f5fca081ec8c7accd1 (diff) |
drivers/firmware: const-ify DMI API and internals
Three main sets of changes:
1) dmi_get_system_info() return value should have been marked const,
since callers should not be changing that data.
2) const-ify DMI internals, since DMI firmware tables should,
whenever possible, be marked const to ensure we never ever write to
that data area.
3) const-ify DMI API, to enable marking tables const where possible
in low-level drivers.
And if we're really lucky, this might enable some additional
optimizations on the part of the compiler.
The bulk of the changes are #2 and #3, which are interrelated. #1 could
have been a separate patch, but it was so small compared to the others,
it was easier to roll it into this changeset.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'arch/i386/pci/common.c')
-rw-r--r-- | arch/i386/pci/common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/i386/pci/common.c b/arch/i386/pci/common.c index ebc6f3c66340..07d5223442bf 100644 --- a/arch/i386/pci/common.c +++ b/arch/i386/pci/common.c | |||
@@ -123,7 +123,7 @@ void __devinit pcibios_fixup_bus(struct pci_bus *b) | |||
123 | * on the kernel command line (which was parsed earlier). | 123 | * on the kernel command line (which was parsed earlier). |
124 | */ | 124 | */ |
125 | 125 | ||
126 | static int __devinit set_bf_sort(struct dmi_system_id *d) | 126 | static int __devinit set_bf_sort(const struct dmi_system_id *d) |
127 | { | 127 | { |
128 | if (pci_bf_sort == pci_bf_sort_default) { | 128 | if (pci_bf_sort == pci_bf_sort_default) { |
129 | pci_bf_sort = pci_dmi_bf; | 129 | pci_bf_sort = pci_dmi_bf; |
@@ -136,7 +136,7 @@ static int __devinit set_bf_sort(struct dmi_system_id *d) | |||
136 | * Enable renumbering of PCI bus# ranges to reach all PCI busses (Cardbus) | 136 | * Enable renumbering of PCI bus# ranges to reach all PCI busses (Cardbus) |
137 | */ | 137 | */ |
138 | #ifdef __i386__ | 138 | #ifdef __i386__ |
139 | static int __devinit assign_all_busses(struct dmi_system_id *d) | 139 | static int __devinit assign_all_busses(const struct dmi_system_id *d) |
140 | { | 140 | { |
141 | pci_probe |= PCI_ASSIGN_ALL_BUSSES; | 141 | pci_probe |= PCI_ASSIGN_ALL_BUSSES; |
142 | printk(KERN_INFO "%s detected: enabling PCI bus# renumbering" | 142 | printk(KERN_INFO "%s detected: enabling PCI bus# renumbering" |