aboutsummaryrefslogtreecommitdiffstats
path: root/arch/i386/mach-default
diff options
context:
space:
mode:
authorZachary Amsden <zach@vmware.com>2006-02-24 16:04:27 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2006-02-24 17:31:39 -0500
commit9c869edac591977314323a4eaad5f7633fca684f (patch)
tree9455f4e8e78cd62f87b19dd7abe2c65ca23d9ceb /arch/i386/mach-default
parentad329b1519c0091806046b0e49ab073ea590dc11 (diff)
[PATCH] Fix topology.c location
When compiling a non-default subarch, topology.c is missing from the kernel build. This causes builds with CONFIG_HOTPLUG_CPU to fail. In addition, on Intel processors with cpuid level > 4, it causes intel_cacheinfo.c to reference uninitialized data that should have been set up by the initcall in topology.c which calls register_cpu. This causes a kernel panic on boot on newer Intel processors. Moving topology.c to arch/i386/kernel fixes both of these problems. Thanks to Dan Hecht for finding and fixing this problem. Signed-off-by: Zachary Amsden <zach@vmware.com> Signed-off-by: Dan Hecht <dhect@vmware.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/i386/mach-default')
-rw-r--r--arch/i386/mach-default/Makefile2
-rw-r--r--arch/i386/mach-default/topology.c97
2 files changed, 1 insertions, 98 deletions
diff --git a/arch/i386/mach-default/Makefile b/arch/i386/mach-default/Makefile
index e95bb0237921..012fe34459e6 100644
--- a/arch/i386/mach-default/Makefile
+++ b/arch/i386/mach-default/Makefile
@@ -2,4 +2,4 @@
2# Makefile for the linux kernel. 2# Makefile for the linux kernel.
3# 3#
4 4
5obj-y := setup.o topology.o 5obj-y := setup.o
diff --git a/arch/i386/mach-default/topology.c b/arch/i386/mach-default/topology.c
deleted file mode 100644
index b64314069e78..000000000000
--- a/arch/i386/mach-default/topology.c
+++ /dev/null
@@ -1,97 +0,0 @@
1/*
2 * arch/i386/mach-generic/topology.c - Populate driverfs with topology information
3 *
4 * Written by: Matthew Dobson, IBM Corporation
5 * Original Code: Paul Dorwin, IBM Corporation, Patrick Mochel, OSDL
6 *
7 * Copyright (C) 2002, IBM Corp.
8 *
9 * All rights reserved.
10 *
11 * This program is free software; you can redistribute it and/or modify
12 * it under the terms of the GNU General Public License as published by
13 * the Free Software Foundation; either version 2 of the License, or
14 * (at your option) any later version.
15 *
16 * This program is distributed in the hope that it will be useful, but
17 * WITHOUT ANY WARRANTY; without even the implied warranty of
18 * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
19 * NON INFRINGEMENT. See the GNU General Public License for more
20 * details.
21 *
22 * You should have received a copy of the GNU General Public License
23 * along with this program; if not, write to the Free Software
24 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
25 *
26 * Send feedback to <colpatch@us.ibm.com>
27 */
28#include <linux/init.h>
29#include <linux/smp.h>
30#include <linux/nodemask.h>
31#include <asm/cpu.h>
32
33static struct i386_cpu cpu_devices[NR_CPUS];
34
35int arch_register_cpu(int num){
36 struct node *parent = NULL;
37
38#ifdef CONFIG_NUMA
39 int node = cpu_to_node(num);
40 if (node_online(node))
41 parent = &node_devices[node].node;
42#endif /* CONFIG_NUMA */
43
44 return register_cpu(&cpu_devices[num].cpu, num, parent);
45}
46
47#ifdef CONFIG_HOTPLUG_CPU
48
49void arch_unregister_cpu(int num) {
50 struct node *parent = NULL;
51
52#ifdef CONFIG_NUMA
53 int node = cpu_to_node(num);
54 if (node_online(node))
55 parent = &node_devices[node].node;
56#endif /* CONFIG_NUMA */
57
58 return unregister_cpu(&cpu_devices[num].cpu, parent);
59}
60EXPORT_SYMBOL(arch_register_cpu);
61EXPORT_SYMBOL(arch_unregister_cpu);
62#endif /*CONFIG_HOTPLUG_CPU*/
63
64
65
66#ifdef CONFIG_NUMA
67#include <linux/mmzone.h>
68#include <asm/node.h>
69
70struct i386_node node_devices[MAX_NUMNODES];
71
72static int __init topology_init(void)
73{
74 int i;
75
76 for_each_online_node(i)
77 arch_register_node(i);
78
79 for_each_present_cpu(i)
80 arch_register_cpu(i);
81 return 0;
82}
83
84#else /* !CONFIG_NUMA */
85
86static int __init topology_init(void)
87{
88 int i;
89
90 for_each_present_cpu(i)
91 arch_register_cpu(i);
92 return 0;
93}
94
95#endif /* CONFIG_NUMA */
96
97subsys_initcall(topology_init);