[PATCH] i386: Replace i386 open-coded cmdline parsing with

This patch replaces the open-coded early commandline parsing
throughout the i386 boot code with the generic mechanism (already used
by ppc, powerpc, ia64 and s390).  The code was inconsistent with
whether it deletes the option from the cmdline or not, meaning some of
these will get passed through the environment into init.

This transformation is mainly mechanical, but there are some notable
parts:

1) Grammar: s/linux never set's it up/linux never sets it up/

2) Remove hacked-in earlyprintk= option scanning.  When someone
   actually implements CONFIG_EARLY_PRINTK, then they can use
   early_param().
[AK: actually it is implemented, but I'm adding the early_param it in the next
x86-64 patch]

3) Move declaration of generic_apic_probe() from setup.c into asm/apic.h

4) Various parameters now moved into their appropriate files (thanks Andi).

5) All parse functions which examine arg need to check for NULL,
   except one where it has subtle humor value.

AK: readded acpi_sci handling which was completely dropped
AK: moved some more variables into acpi/boot.c

Cc: len.brown@intel.com

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andi Kleen <ak@suse.de>

6 files changed, 266 insertions, 235 deletions

diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
index ee003bc0e8b1..87e2ab50b694 100644
--- a/arch/i386/kernel/acpi/boot.c
+++ b/arch/i386/kernel/acpi/boot.c
@@ -36,6 +36,8 @@
 #include <asm/io.h>
 #include <asm/mpspec.h>
 
+int __initdata acpi_force = 0;
+
 #ifdef  CONFIG_X86_64
 
 extern void __init clustered_apic_check(void);
@@ -860,8 +862,6 @@ static void __init acpi_process_madt(void)
         return;
 }
 
-extern int acpi_force;
-
 #ifdef __i386__
 
 static int __init disable_acpi_irq(struct dmi_system_id *d)
@@ -1163,3 +1163,75 @@ int __init acpi_boot_init(void)
 
         return 0;
 }
+
+static int __init parse_acpi(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
+
+        /* "acpi=off" disables both ACPI table parsing and interpreter */
+        if (strcmp(arg, "off") == 0) {
+                disable_acpi();
+        }
+        /* acpi=force to over-ride black-list */
+        else if (strcmp(arg, "force") == 0) {
+                acpi_force = 1;
+                acpi_ht = 1;
+                acpi_disabled = 0;
+        }
+        /* acpi=strict disables out-of-spec workarounds */
+        else if (strcmp(arg, "strict") == 0) {
+                acpi_strict = 1;
+        }
+        /* Limit ACPI just to boot-time to enable HT */
+        else if (strcmp(arg, "ht") == 0) {
+                if (!acpi_force)
+                        disable_acpi();
+                acpi_ht = 1;
+        }
+        /* "acpi=noirq" disables ACPI interrupt routing */
+        else if (strcmp(arg, "noirq") == 0) {
+                acpi_noirq_set();
+        } else {
+                /* Core will printk when we return error. */
+                return -EINVAL;
+        }
+        return 0;
+}
+early_param("acpi", parse_acpi);
+
+/* FIXME: Using pci= for an ACPI parameter is a travesty. */
+static int __init parse_pci(char *arg)
+{
+        if (arg && strcmp(arg, "noacpi") == 0)
+                acpi_disable_pci();
+        return 0;
+}
+early_param("pci", parse_pci);
+
+#ifdef CONFIG_X86_IO_APIC
+static int __init parse_acpi_skip_timer_override(char *arg)
+{
+        acpi_skip_timer_override = 1;
+        return 0;
+}
+early_param("acpi_skip_timer_override", parse_acpi_skip_timer_override);
+#endif /* CONFIG_X86_IO_APIC */
+
+static int __init setup_acpi_sci(char *s)
+{
+        if (!s)
+                return -EINVAL;
+        if (!strcmp(s, "edge"))
+                acpi_sci_flags.trigger = 1;
+        else if (!strcmp(s, "level"))
+                acpi_sci_flags.trigger = 3;
+        else if (!strcmp(s, "high"))
+                acpi_sci_flags.polarity = 1;
+        else if (!strcmp(s, "low"))
+                acpi_sci_flags.polarity = 3;
+        else
+                return -EINVAL;
+        return 0;
+}
+early_param("acpi_sci", setup_acpi_sci);
diff --git a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c
index 1a34fc57800b..ce75e71b694f 100644
--- a/arch/i386/kernel/apic.c
+++ b/arch/i386/kernel/apic.c
@@ -1372,3 +1372,18 @@ int __init APIC_init_uniprocessor (void)
 
         return 0;
 }
+
+static int __init parse_lapic(char *arg)
+{
+        lapic_enable();
+        return 0;
+}
+early_param("lapic", parse_lapic);
+
+static int __init parse_nolapic(char *arg)
+{
+        lapic_disable();
+        return 0;
+}
+early_param("nolapic", parse_nolapic);
+
diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
index b713f27d7e86..fd0df75cfbda 100644
--- a/arch/i386/kernel/io_apic.c
+++ b/arch/i386/kernel/io_apic.c
@@ -66,7 +66,7 @@ int sis_apic_bug = -1;
  */
 int nr_ioapic_registers[MAX_IO_APICS];
 
-int disable_timer_pin_1 __initdata;
+static int disable_timer_pin_1 __initdata;
 
 /*
  * Rough estimation of how many shared IRQs there are, can
@@ -2691,3 +2691,25 @@ int io_apic_set_pci_routing (int ioapic, int pin, int irq, int edge_level, int a
 }
 
 #endif /* CONFIG_ACPI */
+
+static int __init parse_disable_timer_pin_1(char *arg)
+{
+        disable_timer_pin_1 = 1;
+        return 0;
+}
+early_param("disable_timer_pin_1", parse_disable_timer_pin_1);
+
+static int __init parse_enable_timer_pin_1(char *arg)
+{
+        disable_timer_pin_1 = -1;
+        return 0;
+}
+early_param("enable_timer_pin_1", parse_enable_timer_pin_1);
+
+static int __init parse_noapic(char *arg)
+{
+        /* disable IO-APIC */
+        disable_ioapic_setup();
+        return 0;
+}
+early_param("noapic", parse_noapic);
diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c
index 6b1ae6ba76f0..66c3dc99a655 100644
--- a/arch/i386/kernel/machine_kexec.c
+++ b/arch/i386/kernel/machine_kexec.c
@@ -9,6 +9,7 @@
 #include <linux/mm.h>
 #include <linux/kexec.h>
 #include <linux/delay.h>
+#include <linux/init.h>
 #include <asm/pgtable.h>
 #include <asm/pgalloc.h>
 #include <asm/tlbflush.h>
@@ -209,3 +210,25 @@ NORET_TYPE void machine_kexec(struct kimage *image)
         rnk = (relocate_new_kernel_t) reboot_code_buffer;
         (*rnk)(page_list, reboot_code_buffer, image->start, cpu_has_pae);
 }
+
+/* crashkernel=size@addr specifies the location to reserve for
+ * a crash kernel.  By reserving this memory we guarantee
+ * that linux never sets it up as a DMA target.
+ * Useful for holding code to do something appropriate
+ * after a kernel panic.
+ */
+static int __init parse_crashkernel(char *arg)
+{
+        unsigned long size, base;
+        size = memparse(arg, &arg);
+        if (*arg == '@') {
+                base = memparse(arg+1, &arg);
+                /* FIXME: Do I want a sanity check
+                 * to validate the memory range?
+                 */
+                crashk_res.start = base;
+                crashk_res.end   = base + size - 1;
+        }
+        return 0;
+}
+early_param("crashkernel", parse_crashkernel);
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index 71a540362b78..c6e31ed386f5 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -96,11 +96,6 @@ unsigned long mmu_cr4_features;
 #endif
 EXPORT_SYMBOL(acpi_disabled);
 
-#ifdef  CONFIG_ACPI
-int __initdata acpi_force = 0;
-extern acpi_interrupt_flags     acpi_sci_flags;
-#endif
-
 /* for MCA, but anyone else can use it if they want */
 unsigned int machine_id;
 #ifdef CONFIG_MCA
@@ -148,7 +143,6 @@ EXPORT_SYMBOL(ist_info);
 struct e820map e820;
 
 extern void early_cpu_init(void);
-extern void generic_apic_probe(char *);
 extern int root_mountflags;
 
 unsigned long saved_videomode;
@@ -700,238 +694,132 @@ static inline void copy_edd(void)
 }
 #endif
 
-static void __init parse_cmdline_early (char ** cmdline_p)
-{
-        char c = ' ', *to = command_line, *from = saved_command_line;
-        int len = 0;
-        int userdef = 0;
+static int __initdata user_defined_memmap = 0;
 
-        /* Save unparsed command line copy for /proc/cmdline */
-        saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+/*
+ * "mem=nopentium" disables the 4MB page tables.
+ * "mem=XXX[kKmM]" defines a memory region from HIGH_MEM
+ * to <mem>, overriding the bios size.
+ * "memmap=XXX[KkmM]@XXX[KkmM]" defines a memory region from
+ * <start> to <start>+<mem>, overriding the bios size.
+ *
+ * HPA tells me bootloaders need to parse mem=, so no new
+ * option should be mem=  [also see Documentation/i386/boot.txt]
+ */
+static int __init parse_mem(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
 
-        for (;;) {
-                if (c != ' ')
-                        goto next_char;
-                /*
-                 * "mem=nopentium" disables the 4MB page tables.
-                 * "mem=XXX[kKmM]" defines a memory region from HIGH_MEM
-                 * to <mem>, overriding the bios size.
-                 * "memmap=XXX[KkmM]@XXX[KkmM]" defines a memory region from
-                 * <start> to <start>+<mem>, overriding the bios size.
-                 *
-                 * HPA tells me bootloaders need to parse mem=, so no new
-                 * option should be mem=  [also see Documentation/i386/boot.txt]
+        if (strcmp(arg, "nopentium") == 0) {
+                clear_bit(X86_FEATURE_PSE, boot_cpu_data.x86_capability);
+                disable_pse = 1;
+        } else {
+                /* If the user specifies memory size, we
+                 * limit the BIOS-provided memory map to
+                 * that size. exactmap can be used to specify
+                 * the exact map. mem=number can be used to
+                 * trim the existing memory map.
                  */
-                if (!memcmp(from, "mem=", 4)) {
-                        if (to != command_line)
-                                to--;
-                        if (!memcmp(from+4, "nopentium", 9)) {
-                                from += 9+4;
-                                clear_bit(X86_FEATURE_PSE, boot_cpu_data.x86_capability);
-                                disable_pse = 1;
-                        } else {
-                                /* If the user specifies memory size, we
-                                 * limit the BIOS-provided memory map to
-                                 * that size. exactmap can be used to specify
-                                 * the exact map. mem=number can be used to
-                                 * trim the existing memory map.
-                                 */
-                                unsigned long long mem_size;
+                unsigned long long mem_size;
  
-                                mem_size = memparse(from+4, &from);
-                                limit_regions(mem_size);
-                                userdef=1;
-                        }
-                }
-
-                else if (!memcmp(from, "memmap=", 7)) {
-                        if (to != command_line)
-                                to--;
-                        if (!memcmp(from+7, "exactmap", 8)) {
-#ifdef CONFIG_CRASH_DUMP
-                                /* If we are doing a crash dump, we
-                                 * still need to know the real mem
-                                 * size before original memory map is
-                                 * reset.
-                                 */
-                                find_max_pfn();
-                                saved_max_pfn = max_pfn;
-#endif
-                                from += 8+7;
-                                e820.nr_map = 0;
-                                userdef = 1;
-                        } else {
-                                /* If the user specifies memory size, we
-                                 * limit the BIOS-provided memory map to
-                                 * that size. exactmap can be used to specify
-                                 * the exact map. mem=number can be used to
-                                 * trim the existing memory map.
-                                 */
-                                unsigned long long start_at, mem_size;
- 
-                                mem_size = memparse(from+7, &from);
-                                if (*from == '@') {
-                                        start_at = memparse(from+1, &from);
-                                        add_memory_region(start_at, mem_size, E820_RAM);
-                                } else if (*from == '#') {
-                                        start_at = memparse(from+1, &from);
-                                        add_memory_region(start_at, mem_size, E820_ACPI);
-                                } else if (*from == '$') {
-                                        start_at = memparse(from+1, &from);
-                                        add_memory_region(start_at, mem_size, E820_RESERVED);
-                                } else {
-                                        limit_regions(mem_size);
-                                        userdef=1;
-                                }
-                        }
-                }
-
-                else if (!memcmp(from, "noexec=", 7))
-                        noexec_setup(from + 7);
+                mem_size = memparse(arg, &arg);
+                limit_regions(mem_size);
+                user_defined_memmap = 1;
+        }
+        return 0;
+}
+early_param("mem", parse_mem);
 
+static int __init parse_memmap(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
 
-#ifdef  CONFIG_X86_SMP
-                /*
-                 * If the BIOS enumerates physical processors before logical,
-                 * maxcpus=N at enumeration-time can be used to disable HT.
+        if (strcmp(arg, "exactmap") == 0) {
+#ifdef CONFIG_CRASH_DUMP
+                /* If we are doing a crash dump, we
+                 * still need to know the real mem
+                 * size before original memory map is
+                 * reset.
                  */
-                else if (!memcmp(from, "maxcpus=", 8)) {
-                        extern unsigned int maxcpus;
-
-                        maxcpus = simple_strtoul(from + 8, NULL, 0);
-                }
+                find_max_pfn();
+                saved_max_pfn = max_pfn;
 #endif
-
-#ifdef CONFIG_ACPI
-                /* "acpi=off" disables both ACPI table parsing and interpreter */
-                else if (!memcmp(from, "acpi=off", 8)) {
-                        disable_acpi();
-                }
-
-                /* acpi=force to over-ride black-list */
-                else if (!memcmp(from, "acpi=force", 10)) {
-                        acpi_force = 1;
-                        acpi_ht = 1;
-                        acpi_disabled = 0;
-                }
-
-                /* acpi=strict disables out-of-spec workarounds */
-                else if (!memcmp(from, "acpi=strict", 11)) {
-                        acpi_strict = 1;
-                }
-
-                /* Limit ACPI just to boot-time to enable HT */
-                else if (!memcmp(from, "acpi=ht", 7)) {
-                        if (!acpi_force)
-                                disable_acpi();
-                        acpi_ht = 1;
-                }
-                
-                /* "pci=noacpi" disable ACPI IRQ routing and PCI scan */
-                else if (!memcmp(from, "pci=noacpi", 10)) {
-                        acpi_disable_pci();
-                }
-                /* "acpi=noirq" disables ACPI interrupt routing */
-                else if (!memcmp(from, "acpi=noirq", 10)) {
-                        acpi_noirq_set();
+                e820.nr_map = 0;
+                user_defined_memmap = 1;
+        } else {
+                /* If the user specifies memory size, we
+                 * limit the BIOS-provided memory map to
+                 * that size. exactmap can be used to specify
+                 * the exact map. mem=number can be used to
+                 * trim the existing memory map.
+                 */
+                unsigned long long start_at, mem_size;
+
+                mem_size = memparse(arg, &arg);
+                if (*arg == '@') {
+                        start_at = memparse(arg+1, &arg);
+                        add_memory_region(start_at, mem_size, E820_RAM);
+                } else if (*arg == '#') {
+                        start_at = memparse(arg+1, &arg);
+                        add_memory_region(start_at, mem_size, E820_ACPI);
+                } else if (*arg == '$') {
+                        start_at = memparse(arg+1, &arg);
+                        add_memory_region(start_at, mem_size, E820_RESERVED);
+                } else {
+                        limit_regions(mem_size);
+                        user_defined_memmap = 1;
                 }
+        }
+        return 0;
+}
+early_param("memmap", parse_memmap);
 
-                else if (!memcmp(from, "acpi_sci=edge", 13))
-                        acpi_sci_flags.trigger =  1;
-
-                else if (!memcmp(from, "acpi_sci=level", 14))
-                        acpi_sci_flags.trigger = 3;
-
-                else if (!memcmp(from, "acpi_sci=high", 13))
-                        acpi_sci_flags.polarity = 1;
-
-                else if (!memcmp(from, "acpi_sci=low", 12))
-                        acpi_sci_flags.polarity = 3;
-
-#ifdef CONFIG_X86_IO_APIC
-                else if (!memcmp(from, "acpi_skip_timer_override", 24))
-                        acpi_skip_timer_override = 1;
-
-                if (!memcmp(from, "disable_timer_pin_1", 19))
-                        disable_timer_pin_1 = 1;
-                if (!memcmp(from, "enable_timer_pin_1", 18))
-                        disable_timer_pin_1 = -1;
+#ifdef CONFIG_PROC_VMCORE
+/* elfcorehdr= specifies the location of elf core header
+ * stored by the crashed kernel.
+ */
+static int __init parse_elfcorehdr(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
 
-                /* disable IO-APIC */
-                else if (!memcmp(from, "noapic", 6))
-                        disable_ioapic_setup();
-#endif /* CONFIG_X86_IO_APIC */
-#endif /* CONFIG_ACPI */
+        elfcorehdr_addr = memparse(arg, &arg);
+        return 0;
+}
+early_param("elfcorehdr", parse_elfcorehdr);
+#endif /* CONFIG_PROC_VMCORE */
 
-#ifdef CONFIG_X86_LOCAL_APIC
-                /* enable local APIC */
-                else if (!memcmp(from, "lapic", 5))
-                        lapic_enable();
+/*
+ * highmem=size forces highmem to be exactly 'size' bytes.
+ * This works even on boxes that have no highmem otherwise.
+ * This also works to reduce highmem size on bigger boxes.
+ */
+static int __init parse_highmem(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
 
-                /* disable local APIC */
-                else if (!memcmp(from, "nolapic", 6))
-                        lapic_disable();
-#endif /* CONFIG_X86_LOCAL_APIC */
+        highmem_pages = memparse(arg, &arg) >> PAGE_SHIFT;
+        return 0;
+}
+early_param("highmem", parse_highmem);
 
-#ifdef CONFIG_KEXEC
-                /* crashkernel=size@addr specifies the location to reserve for
-                 * a crash kernel.  By reserving this memory we guarantee
-                 * that linux never set's it up as a DMA target.
-                 * Useful for holding code to do something appropriate
-                 * after a kernel panic.
-                 */
-                else if (!memcmp(from, "crashkernel=", 12)) {
-                        unsigned long size, base;
-                        size = memparse(from+12, &from);
-                        if (*from == '@') {
-                                base = memparse(from+1, &from);
-                                /* FIXME: Do I want a sanity check
-                                 * to validate the memory range?
-                                 */
-                                crashk_res.start = base;
-                                crashk_res.end   = base + size - 1;
-                        }
-                }
-#endif
-#ifdef CONFIG_PROC_VMCORE
-                /* elfcorehdr= specifies the location of elf core header
-                 * stored by the crashed kernel.
-                 */
-                else if (!memcmp(from, "elfcorehdr=", 11))
-                        elfcorehdr_addr = memparse(from+11, &from);
-#endif
+/*
+ * vmalloc=size forces the vmalloc area to be exactly 'size'
+ * bytes. This can be used to increase (or decrease) the
+ * vmalloc area - the default is 128m.
+ */
+static int __init parse_vmalloc(char *arg)
+{
+        if (!arg)
+                return -EINVAL;
 
-                /*
-                 * highmem=size forces highmem to be exactly 'size' bytes.
-                 * This works even on boxes that have no highmem otherwise.
-                 * This also works to reduce highmem size on bigger boxes.
-                 */
-                else if (!memcmp(from, "highmem=", 8))
-                        highmem_pages = memparse(from+8, &from) >> PAGE_SHIFT;
-        
-                /*
-                 * vmalloc=size forces the vmalloc area to be exactly 'size'
-                 * bytes. This can be used to increase (or decrease) the
-                 * vmalloc area - the default is 128m.
-                 */
-                else if (!memcmp(from, "vmalloc=", 8))
-                        __VMALLOC_RESERVE = memparse(from+8, &from);
-
-        next_char:
-                c = *(from++);
-                if (!c)
-                        break;
-                if (COMMAND_LINE_SIZE <= ++len)
-                        break;
-                *(to++) = c;
-        }
-        *to = '\0';
-        *cmdline_p = command_line;
-        if (userdef) {
-                printk(KERN_INFO "user-defined physical RAM map:\n");
-                print_memory_map("user");
-        }
+        __VMALLOC_RESERVE = memparse(arg, &arg);
+        return 0;
 }
+early_param("vmalloc", parse_vmalloc);
 
 /*
  * Callback for efi_memory_walk.
@@ -1507,17 +1395,15 @@ void __init setup_arch(char **cmdline_p)
         data_resource.start = virt_to_phys(_etext);
         data_resource.end = virt_to_phys(_edata)-1;
 
-        parse_cmdline_early(cmdline_p);
+        parse_early_param();
 
-#ifdef CONFIG_EARLY_PRINTK
-        {
-                char *s = strstr(*cmdline_p, "earlyprintk=");
-                if (s) {
-                        setup_early_printk(strchr(s, '=') + 1);
-                        printk("early console enabled\n");
-                }
+        if (user_defined_memmap) {
+                printk(KERN_INFO "user-defined physical RAM map:\n");
+                print_memory_map("user");
         }
-#endif
+
+        strlcpy(command_line, saved_command_line, COMMAND_LINE_SIZE);
+        *cmdline_p = command_line;
 
         max_low_pfn = setup_memory();
 
@@ -1546,7 +1432,7 @@ void __init setup_arch(char **cmdline_p)
         dmi_scan_machine();
 
 #ifdef CONFIG_X86_GENERICARCH
-        generic_apic_probe(*cmdline_p);
+        generic_apic_probe();
 #endif  
         if (efi_enabled)
                 efi_map_memmap();
diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c
index 9367af76ce37..517eb3874550 100644
--- a/arch/i386/kernel/smpboot.c
+++ b/arch/i386/kernel/smpboot.c
@@ -1491,3 +1491,16 @@ void __init smp_intr_init(void)
         /* IPI for generic function call */
         set_intr_gate(CALL_FUNCTION_VECTOR, call_function_interrupt);
 }
+
+/*
+ * If the BIOS enumerates physical processors before logical,
+ * maxcpus=N at enumeration-time can be used to disable HT.
+ */
+static int __init parse_maxcpus(char *arg)
+{
+        extern unsigned int maxcpus;
+
+        maxcpus = simple_strtoul(arg, NULL, 0);
+        return 0;
+}
+early_param("maxcpus", parse_maxcpus);