diff options
author | Vivek Goyal <vgoyal@in.ibm.com> | 2007-01-05 19:36:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2007-01-06 02:55:23 -0500 |
commit | 3771a450cf47fa64f36c53ba61e36aa2ec84a86b (patch) | |
tree | 1ab5319f1187a4b6da73120c3addf001d97d28f9 /arch/i386/kernel/smpboot.c | |
parent | 9dbeeec91e8f4a200ac56af5004473fa6099520f (diff) |
[PATCH] i386: modpost smpboot code warning fix
o Currently synchronize_tsc_ap() is of type __init. It is called by
smp_callin() which is of type __cpuinit. So synchronize_tsc_ap()
should be of type __cpuinit.
o Modpost generates warnings for i386 if CONFIG_RELOCATABLE=y and
CONFIG_HOTPLUG_CPU=y
WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between 'start_secondary' (at offset 0xc01164dc) and 'initialize_secondary'
WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between 'start_secondary' (at offset 0xc01164e8) and 'initialize_secondary'
o tsc is of type __initdata. It should be of type __cpuinitdata.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Cc: Andi Kleen <ak@suse.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/i386/kernel/smpboot.c')
-rw-r--r-- | arch/i386/kernel/smpboot.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c index aef39be81361..300d9b38d02e 100644 --- a/arch/i386/kernel/smpboot.c +++ b/arch/i386/kernel/smpboot.c | |||
@@ -227,7 +227,7 @@ static struct { | |||
227 | atomic_t count_start; | 227 | atomic_t count_start; |
228 | atomic_t count_stop; | 228 | atomic_t count_stop; |
229 | unsigned long long values[NR_CPUS]; | 229 | unsigned long long values[NR_CPUS]; |
230 | } tsc __initdata = { | 230 | } tsc __cpuinitdata = { |
231 | .start_flag = ATOMIC_INIT(0), | 231 | .start_flag = ATOMIC_INIT(0), |
232 | .count_start = ATOMIC_INIT(0), | 232 | .count_start = ATOMIC_INIT(0), |
233 | .count_stop = ATOMIC_INIT(0), | 233 | .count_stop = ATOMIC_INIT(0), |
@@ -332,7 +332,7 @@ static void __init synchronize_tsc_bp(void) | |||
332 | printk("passed.\n"); | 332 | printk("passed.\n"); |
333 | } | 333 | } |
334 | 334 | ||
335 | static void __init synchronize_tsc_ap(void) | 335 | static void __cpuinit synchronize_tsc_ap(void) |
336 | { | 336 | { |
337 | int i; | 337 | int i; |
338 | 338 | ||