diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2007-05-02 13:27:11 -0400 |
---|---|---|
committer | Andi Kleen <andi@basil.nowhere.org> | 2007-05-02 13:27:11 -0400 |
commit | 4fbb5968810b237e81977f131986b9efd5245368 (patch) | |
tree | e2d67eee96c143da26ccad791b3e1f23c3bcbe03 /arch/i386/kernel/smpboot.c | |
parent | 141f9cfe0a948c8fe26e5669364ee62c03ea42e8 (diff) |
[PATCH] i386: cleanup GDT Access
Now we have an explicit per-cpu GDT variable, we don't need to keep the
descriptors around to use them to find the GDT: expose cpu_gdt directly.
We could go further and make load_gdt() pack the descriptor for us, or even
assume it means "load the current cpu's GDT" which is what it always does.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'arch/i386/kernel/smpboot.c')
-rw-r--r-- | arch/i386/kernel/smpboot.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c index 954245f6d307..b0ad04d9ef21 100644 --- a/arch/i386/kernel/smpboot.c +++ b/arch/i386/kernel/smpboot.c | |||
@@ -786,13 +786,9 @@ static inline struct task_struct * alloc_idle_task(int cpu) | |||
786 | secondary which will soon come up. */ | 786 | secondary which will soon come up. */ |
787 | static __cpuinit void init_gdt(int cpu, struct task_struct *idle) | 787 | static __cpuinit void init_gdt(int cpu, struct task_struct *idle) |
788 | { | 788 | { |
789 | struct Xgt_desc_struct *cpu_gdt_descr = &per_cpu(cpu_gdt_descr, cpu); | 789 | struct desc_struct *gdt = get_cpu_gdt_table(cpu); |
790 | struct desc_struct *gdt = per_cpu(cpu_gdt, cpu); | ||
791 | struct i386_pda *pda = &per_cpu(_cpu_pda, cpu); | 790 | struct i386_pda *pda = &per_cpu(_cpu_pda, cpu); |
792 | 791 | ||
793 | cpu_gdt_descr->address = (unsigned long)gdt; | ||
794 | cpu_gdt_descr->size = GDT_SIZE - 1; | ||
795 | |||
796 | pack_descriptor((u32 *)&gdt[GDT_ENTRY_PDA].a, | 792 | pack_descriptor((u32 *)&gdt[GDT_ENTRY_PDA].a, |
797 | (u32 *)&gdt[GDT_ENTRY_PDA].b, | 793 | (u32 *)&gdt[GDT_ENTRY_PDA].b, |
798 | (unsigned long)pda, sizeof(*pda) - 1, | 794 | (unsigned long)pda, sizeof(*pda) - 1, |
@@ -1187,7 +1183,11 @@ void __init smp_prepare_cpus(unsigned int max_cpus) | |||
1187 | * it's on the real one. */ | 1183 | * it's on the real one. */ |
1188 | static inline void switch_to_new_gdt(void) | 1184 | static inline void switch_to_new_gdt(void) |
1189 | { | 1185 | { |
1190 | load_gdt(&per_cpu(cpu_gdt_descr, smp_processor_id())); | 1186 | struct Xgt_desc_struct gdt_descr; |
1187 | |||
1188 | gdt_descr.address = (long)get_cpu_gdt_table(smp_processor_id()); | ||
1189 | gdt_descr.size = GDT_SIZE - 1; | ||
1190 | load_gdt(&gdt_descr); | ||
1191 | asm volatile ("mov %0, %%fs" : : "r" (__KERNEL_PDA) : "memory"); | 1191 | asm volatile ("mov %0, %%fs" : : "r" (__KERNEL_PDA) : "memory"); |
1192 | } | 1192 | } |
1193 | 1193 | ||