diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-06-27 05:10:56 -0400 |
---|---|---|
committer | Bryan Wu <bryan.wu@canonical.com> | 2012-07-23 19:52:35 -0400 |
commit | 5391dd0a9d084633e20e6583cfed233581c452f9 (patch) | |
tree | 35ac5251f60c9a46b2cf4a2e5e12c30f05a48865 /arch/cris | |
parent | 32abb4788d3fff69fa242c7850e39ec1418df4f4 (diff) |
leds-lp5523: BUG() in error handling in probe()
Inside the error handling in lp5523_init_led(), there is a place that
calls to led_classdev_unregister(). When we unregister the LED drivers,
it tries to set the brightness to OFF. In this driver setting the
brightness is done through a work queue and the work queue hasn't been
initialized yet.
The result is that we trigger a WARN_ON() in the __queue_work().
The fix is to move the INIT_WORK() in front of the call to
lp5523_init_led().
Matt Renzelmann found this using a bug finding tool.
Reported-by: Matt Renzelmann <mjr@cs.wisc.edu>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
Diffstat (limited to 'arch/cris')
0 files changed, 0 insertions, 0 deletions