diff options
author | Ilya Loginov <isloginov@gmail.com> | 2009-11-26 03:16:19 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-11-26 03:16:19 -0500 |
commit | 2d4dc890b5c8fabd818a8586607e6843c4375e62 (patch) | |
tree | 9976ed7b0eed0056f8289aeb6a2b0abf8c940454 /arch/blackfin | |
parent | 3586e917f2c7df769d173c4ec99554cb40a911e5 (diff) |
block: add helpers to run flush_dcache_page() against a bio and a request's pages
Mtdblock driver doesn't call flush_dcache_page for pages in request. So,
this causes problems on architectures where the icache doesn't fill from
the dcache or with dcache aliases. The patch fixes this.
The ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE symbol was introduced to avoid
pointless empty cache-thrashing loops on architectures for which
flush_dcache_page() is a no-op. Every architecture was provided with this
flush pages on architectires where ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE is
equal 1 or do nothing otherwise.
See "fix mtd_blkdevs problem with caches on some architectures" discussion
on LKML for more information.
Signed-off-by: Ilya Loginov <isloginov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Peter Horton <phorton@bitbox.co.uk>
Cc: "Ed L. Cashin" <ecashin@coraid.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'arch/blackfin')
-rw-r--r-- | arch/blackfin/include/asm/cacheflush.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/blackfin/include/asm/cacheflush.h b/arch/blackfin/include/asm/cacheflush.h index af03a36c7a4e..417eaac7fe99 100644 --- a/arch/blackfin/include/asm/cacheflush.h +++ b/arch/blackfin/include/asm/cacheflush.h | |||
@@ -68,9 +68,11 @@ do { memcpy(dst, src, len); \ | |||
68 | #endif | 68 | #endif |
69 | #if defined(CONFIG_BFIN_EXTMEM_WRITEBACK) || defined(CONFIG_BFIN_L2_WRITEBACK) | 69 | #if defined(CONFIG_BFIN_EXTMEM_WRITEBACK) || defined(CONFIG_BFIN_L2_WRITEBACK) |
70 | # define flush_dcache_range(start,end) blackfin_dcache_flush_range((start), (end)) | 70 | # define flush_dcache_range(start,end) blackfin_dcache_flush_range((start), (end)) |
71 | #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 | ||
71 | # define flush_dcache_page(page) blackfin_dflush_page(page_address(page)) | 72 | # define flush_dcache_page(page) blackfin_dflush_page(page_address(page)) |
72 | #else | 73 | #else |
73 | # define flush_dcache_range(start,end) do { } while (0) | 74 | # define flush_dcache_range(start,end) do { } while (0) |
75 | #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 | ||
74 | # define flush_dcache_page(page) do { } while (0) | 76 | # define flush_dcache_page(page) do { } while (0) |
75 | #endif | 77 | #endif |
76 | 78 | ||