diff options
author | Mike Frysinger <vapier@gentoo.org> | 2010-10-26 23:46:22 -0400 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2011-01-10 07:18:08 -0500 |
commit | 1a5c226528990515c603bae04233016411b44159 (patch) | |
tree | c3f1fa9565c601ccbf00289e37f9c3d4ea258324 /arch/blackfin/mach-bf561 | |
parent | 51946b10cfc741bfdcb82ea6ba65e775702f3a27 (diff) |
Blackfin: clean up mach header includes
The main asm/blackfin.h header will pull in mach/blackfin.h to get
all the fun Blackfin defines. So having any of the sub-mach headers
trying to include asm/blackfin.h makes no sense -- punt it.
The mach/blackfin.h header takes care of including the part-specific
def headers which in turn will include any other needed def file.
Similarly, it takes care of pulling in the part-specific cdef header.
So move this logic out of the blackfin.h when necessary.
Further, make sure the cdef headers do not waste time including the
def headers again.
Since all parts need the common def/cdef headers, move this logic
out of the part-specific headers and into the mach/blackfin.h file.
Finally, we need to split the BF539 def header since the BF538 does
not have MXVR and we don't want to expose those MMRs.
So now all parts should have the same behavior:
mach/blackfin.h
asm/def_LPBlackfin.h
part-specific def.h
if ! asm
asm/cdef_LPBlackfin.h
part-specific cdef.h
And the sub def/cdef headers only tail into what they need.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'arch/blackfin/mach-bf561')
-rw-r--r-- | arch/blackfin/mach-bf561/include/mach/blackfin.h | 11 | ||||
-rw-r--r-- | arch/blackfin/mach-bf561/include/mach/cdefBF561.h | 10 | ||||
-rw-r--r-- | arch/blackfin/mach-bf561/include/mach/defBF561.h | 9 |
3 files changed, 9 insertions, 21 deletions
diff --git a/arch/blackfin/mach-bf561/include/mach/blackfin.h b/arch/blackfin/mach-bf561/include/mach/blackfin.h index 891cb599aa63..dc470534c085 100644 --- a/arch/blackfin/mach-bf561/include/mach/blackfin.h +++ b/arch/blackfin/mach-bf561/include/mach/blackfin.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2005-2009 Analog Devices Inc. | 2 | * Copyright 2005-2010 Analog Devices Inc. |
3 | * | 3 | * |
4 | * Licensed under the GPL-2 or later. | 4 | * Licensed under the GPL-2 or later. |
5 | */ | 5 | */ |
@@ -10,11 +10,14 @@ | |||
10 | #define BF561_FAMILY | 10 | #define BF561_FAMILY |
11 | 11 | ||
12 | #include "bf561.h" | 12 | #include "bf561.h" |
13 | #include "defBF561.h" | ||
14 | #include "anomaly.h" | 13 | #include "anomaly.h" |
15 | 14 | ||
16 | #if !defined(__ASSEMBLY__) | 15 | #include <asm/def_LPBlackfin.h> |
17 | #include "cdefBF561.h" | 16 | #include "defBF561.h" |
17 | |||
18 | #ifndef __ASSEMBLY__ | ||
19 | # include <asm/cdef_LPBlackfin.h> | ||
20 | # include "cdefBF561.h" | ||
18 | #endif | 21 | #endif |
19 | 22 | ||
20 | #define bfin_read_FIO_FLAG_D() bfin_read_FIO0_FLAG_D() | 23 | #define bfin_read_FIO_FLAG_D() bfin_read_FIO0_FLAG_D() |
diff --git a/arch/blackfin/mach-bf561/include/mach/cdefBF561.h b/arch/blackfin/mach-bf561/include/mach/cdefBF561.h index 2670867d16e8..549f0fe6edb8 100644 --- a/arch/blackfin/mach-bf561/include/mach/cdefBF561.h +++ b/arch/blackfin/mach-bf561/include/mach/cdefBF561.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2005-2009 Analog Devices Inc. | 2 | * Copyright 2005-2010 Analog Devices Inc. |
3 | * | 3 | * |
4 | * Licensed under the GPL-2 or later. | 4 | * Licensed under the GPL-2 or later. |
5 | */ | 5 | */ |
@@ -7,14 +7,6 @@ | |||
7 | #ifndef _CDEF_BF561_H | 7 | #ifndef _CDEF_BF561_H |
8 | #define _CDEF_BF561_H | 8 | #define _CDEF_BF561_H |
9 | 9 | ||
10 | #include <asm/blackfin.h> | ||
11 | |||
12 | /* include all Core registers and bit definitions */ | ||
13 | #include "defBF561.h" | ||
14 | |||
15 | /*include core specific register pointer definitions*/ | ||
16 | #include <asm/cdef_LPBlackfin.h> | ||
17 | |||
18 | /*********************************************************************************** */ | 10 | /*********************************************************************************** */ |
19 | /* System MMR Register Map */ | 11 | /* System MMR Register Map */ |
20 | /*********************************************************************************** */ | 12 | /*********************************************************************************** */ |
diff --git a/arch/blackfin/mach-bf561/include/mach/defBF561.h b/arch/blackfin/mach-bf561/include/mach/defBF561.h index 851801f0ed11..71e805ea74e5 100644 --- a/arch/blackfin/mach-bf561/include/mach/defBF561.h +++ b/arch/blackfin/mach-bf561/include/mach/defBF561.h | |||
@@ -1,18 +1,11 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2005-2009 Analog Devices Inc. | 2 | * Copyright 2005-2010 Analog Devices Inc. |
3 | * | 3 | * |
4 | * Licensed under the ADI BSD license or the GPL-2 (or later) | 4 | * Licensed under the ADI BSD license or the GPL-2 (or later) |
5 | */ | 5 | */ |
6 | 6 | ||
7 | #ifndef _DEF_BF561_H | 7 | #ifndef _DEF_BF561_H |
8 | #define _DEF_BF561_H | 8 | #define _DEF_BF561_H |
9 | /* | ||
10 | #if !defined(__ADSPBF561__) | ||
11 | #warning defBF561.h should only be included for BF561 chip. | ||
12 | #endif | ||
13 | */ | ||
14 | /* include all Core registers and bit definitions */ | ||
15 | #include <asm/def_LPBlackfin.h> | ||
16 | 9 | ||
17 | /*********************************************************************************** */ | 10 | /*********************************************************************************** */ |
18 | /* System MMR Register Map */ | 11 | /* System MMR Register Map */ |