diff options
author | Bernd Schmidt <bernds_cb1@t-online.de> | 2009-01-07 10:14:38 -0500 |
---|---|---|
committer | Bryan Wu <cooloney@kernel.org> | 2009-01-07 10:14:38 -0500 |
commit | dbdf20db537a5369c65330f878ad4905020a8bfa (patch) | |
tree | c7fa553755e2d75a6e98d3f32fbe41fab9f72609 /arch/blackfin/kernel/setup.c | |
parent | 6651ece9e257302ee695ee76e69a4427f7033235 (diff) |
Blackfin arch: Faster C implementation of no-MPU CPLB handler
This is a mixture ofcMichael McTernan's patch and the existing cplb-mpu code.
We ditch the old cplb-nompu implementation, which is a good example of
why a good algorithm in a HLL is preferrable to a bad algorithm written in
assembly. Rather than try to construct a table of all posible CPLBs and
search it, we just create a (smaller) table of memory regions and
their attributes. Some of the data structures are now unified for both
the mpu and nompu cases. A lot of needless complexity in cplbinit.c is
removed.
Further optimizations:
* compile cplbmgr.c with a lot of -ffixed-reg options, and omit saving
these registers on the stack when entering a CPLB exception.
* lose cli/nop/nop/sti sequences for some workarounds - these don't
* make
sense in an exception context
Additional code unification should be possible after this.
[Mike Frysinger <vapier.adi@gmail.com>:
- convert CPP if statements to C if statements
- remove redundant statements
- use a do...while loop rather than a for loop to get slightly better
optimization and to avoid gcc "may be used uninitialized" warnings ...
we know that the [id]cplb_nr_bounds variables will never be 0, so this
is OK
- the no-mpu code was the last user of MAX_MEM_SIZE and with that rewritten,
we can punt it
- add some BUG_ON() checks to make sure we dont overflow the small
cplb_bounds array
- add i/d cplb entries for the bootrom because there is functions/data in
there we want to access
- we do not need a NULL trailing entry as any time we access the bounds
arrays, we use the nr_bounds variable
]
Signed-off-by: Michael McTernan <mmcternan@airvana.com>
Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bernd Schmidt <bernds_cb1@t-online.de>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Diffstat (limited to 'arch/blackfin/kernel/setup.c')
-rw-r--r-- | arch/blackfin/kernel/setup.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c index d3d37e7f465b..20d04a1bc861 100644 --- a/arch/blackfin/kernel/setup.c +++ b/arch/blackfin/kernel/setup.c | |||
@@ -88,6 +88,7 @@ void __init generate_cplb_tables(void) | |||
88 | { | 88 | { |
89 | unsigned int cpu; | 89 | unsigned int cpu; |
90 | 90 | ||
91 | generate_cplb_tables_all(); | ||
91 | /* Generate per-CPU I&D CPLB tables */ | 92 | /* Generate per-CPU I&D CPLB tables */ |
92 | for (cpu = 0; cpu < num_possible_cpus(); ++cpu) | 93 | for (cpu = 0; cpu < num_possible_cpus(); ++cpu) |
93 | generate_cplb_tables_cpu(cpu); | 94 | generate_cplb_tables_cpu(cpu); |
@@ -97,19 +98,11 @@ void __init generate_cplb_tables(void) | |||
97 | void __cpuinit bfin_setup_caches(unsigned int cpu) | 98 | void __cpuinit bfin_setup_caches(unsigned int cpu) |
98 | { | 99 | { |
99 | #ifdef CONFIG_BFIN_ICACHE | 100 | #ifdef CONFIG_BFIN_ICACHE |
100 | #ifdef CONFIG_MPU | ||
101 | bfin_icache_init(icplb_tbl[cpu]); | 101 | bfin_icache_init(icplb_tbl[cpu]); |
102 | #else | ||
103 | bfin_icache_init(icplb_tables[cpu]); | ||
104 | #endif | ||
105 | #endif | 102 | #endif |
106 | 103 | ||
107 | #ifdef CONFIG_BFIN_DCACHE | 104 | #ifdef CONFIG_BFIN_DCACHE |
108 | #ifdef CONFIG_MPU | ||
109 | bfin_dcache_init(dcplb_tbl[cpu]); | 105 | bfin_dcache_init(dcplb_tbl[cpu]); |
110 | #else | ||
111 | bfin_dcache_init(dcplb_tables[cpu]); | ||
112 | #endif | ||
113 | #endif | 106 | #endif |
114 | 107 | ||
115 | /* | 108 | /* |