diff options
author | Manjunath Kondaiah G <manjugk@ti.com> | 2010-10-08 13:00:19 -0400 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2010-10-08 13:12:38 -0400 |
commit | b0a330dc5eff6b27cce3b7b5dbea9379d969f73e (patch) | |
tree | f711cd79abe76c891bb72172c122af4c0ecf550b /arch/arm | |
parent | 600ecd9874d56d310a597b1e0a3936f195c83022 (diff) |
OMAP: plat-omap: Fix static function warnings
This patch fixes sparse warnings due non declarations of static functions.
arch/arm/plat-omap/sram.c:130:13: warning: symbol 'omap_detect_sram' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:216:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:450:12: warning: symbol 'omap_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:348:12: warning: symbol 'omap242x_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:369:12: warning: symbol 'omap243x_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:425:12: warning: symbol 'omap34xx_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:441:12: warning: symbol 'omap44xx_sram_init' was not declared. Should it be static
arch/arm/plat-omap/mcbsp.c:36:6: warning: symbol 'omap_mcbsp_write' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:50:5: warning: symbol 'omap_mcbsp_read' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:65:6: warning: symbol 'omap_mcbsp_st_write' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:70:5: warning: symbol 'omap_mcbsp_st_read' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:1648:15: warning: symbol 'omap_st_add' was not declared. Should it be static?
arch/arm/plat-omap/fb.c:414:15: warning: symbol 'omapfb_reserve_sram' was not declared. Should it be static?
arch/arm/plat-omap/cpu-omap.c:43:5: warning: symbol 'omap_verify_speed' was not declared. Should it be static?
arch/arm/plat-omap/cpu-omap.c:61:14: warning: symbol 'omap_getspeed' was not declared. Should it be static?
Signed-off-by: Manjunath Kondaiah G <manjugk@ti.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Nishanth Menon <nm@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm')
-rw-r--r-- | arch/arm/mach-omap2/io.c | 1 | ||||
-rw-r--r-- | arch/arm/mach-omap2/io.h | 7 | ||||
-rw-r--r-- | arch/arm/plat-omap/cpu-omap.c | 4 | ||||
-rw-r--r-- | arch/arm/plat-omap/fb.c | 2 | ||||
-rw-r--r-- | arch/arm/plat-omap/fb.h | 10 | ||||
-rw-r--r-- | arch/arm/plat-omap/include/plat/sram.h | 1 | ||||
-rw-r--r-- | arch/arm/plat-omap/mcbsp.c | 10 | ||||
-rw-r--r-- | arch/arm/plat-omap/sram.c | 21 | ||||
-rw-r--r-- | arch/arm/plat-omap/sram.h | 6 |
9 files changed, 42 insertions, 20 deletions
diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c index 490d87082fad..40562ddd3ee4 100644 --- a/arch/arm/mach-omap2/io.c +++ b/arch/arm/mach-omap2/io.c | |||
@@ -36,6 +36,7 @@ | |||
36 | #include "clock2xxx.h" | 36 | #include "clock2xxx.h" |
37 | #include "clock3xxx.h" | 37 | #include "clock3xxx.h" |
38 | #include "clock44xx.h" | 38 | #include "clock44xx.h" |
39 | #include "io.h" | ||
39 | 40 | ||
40 | #include <plat/omap-pm.h> | 41 | #include <plat/omap-pm.h> |
41 | #include <plat/powerdomain.h> | 42 | #include <plat/powerdomain.h> |
diff --git a/arch/arm/mach-omap2/io.h b/arch/arm/mach-omap2/io.h new file mode 100644 index 000000000000..fd230c6cded5 --- /dev/null +++ b/arch/arm/mach-omap2/io.h | |||
@@ -0,0 +1,7 @@ | |||
1 | |||
2 | #ifndef __MACH_OMAP2_IO_H__ | ||
3 | #define __MACH_OMAP2_IO_H__ | ||
4 | |||
5 | extern int __init omap_sram_init(void); | ||
6 | |||
7 | #endif /* __MACH_OMAP2_IO_H__ */ | ||
diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c index 6d3d33360056..11c54ec8d47f 100644 --- a/arch/arm/plat-omap/cpu-omap.c +++ b/arch/arm/plat-omap/cpu-omap.c | |||
@@ -40,7 +40,7 @@ static struct clk *mpu_clk; | |||
40 | 40 | ||
41 | /* TODO: Add support for SDRAM timing changes */ | 41 | /* TODO: Add support for SDRAM timing changes */ |
42 | 42 | ||
43 | int omap_verify_speed(struct cpufreq_policy *policy) | 43 | static int omap_verify_speed(struct cpufreq_policy *policy) |
44 | { | 44 | { |
45 | if (freq_table) | 45 | if (freq_table) |
46 | return cpufreq_frequency_table_verify(policy, freq_table); | 46 | return cpufreq_frequency_table_verify(policy, freq_table); |
@@ -58,7 +58,7 @@ int omap_verify_speed(struct cpufreq_policy *policy) | |||
58 | return 0; | 58 | return 0; |
59 | } | 59 | } |
60 | 60 | ||
61 | unsigned int omap_getspeed(unsigned int cpu) | 61 | static unsigned int omap_getspeed(unsigned int cpu) |
62 | { | 62 | { |
63 | unsigned long rate; | 63 | unsigned long rate; |
64 | 64 | ||
diff --git a/arch/arm/plat-omap/fb.c b/arch/arm/plat-omap/fb.c index 0054b9501a53..725df5c1569d 100644 --- a/arch/arm/plat-omap/fb.c +++ b/arch/arm/plat-omap/fb.c | |||
@@ -36,6 +36,8 @@ | |||
36 | #include <plat/board.h> | 36 | #include <plat/board.h> |
37 | #include <plat/sram.h> | 37 | #include <plat/sram.h> |
38 | 38 | ||
39 | #include "fb.h" | ||
40 | |||
39 | #if defined(CONFIG_FB_OMAP) || defined(CONFIG_FB_OMAP_MODULE) | 41 | #if defined(CONFIG_FB_OMAP) || defined(CONFIG_FB_OMAP_MODULE) |
40 | 42 | ||
41 | static struct omapfb_platform_data omapfb_config; | 43 | static struct omapfb_platform_data omapfb_config; |
diff --git a/arch/arm/plat-omap/fb.h b/arch/arm/plat-omap/fb.h new file mode 100644 index 000000000000..d765d0bd8520 --- /dev/null +++ b/arch/arm/plat-omap/fb.h | |||
@@ -0,0 +1,10 @@ | |||
1 | #ifndef __PLAT_OMAP_FB_H__ | ||
2 | #define __PLAT_OMAP_FB_H__ | ||
3 | |||
4 | extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart, | ||
5 | unsigned long sram_vstart, | ||
6 | unsigned long sram_size, | ||
7 | unsigned long pstart_avail, | ||
8 | unsigned long size_avail); | ||
9 | |||
10 | #endif /* __PLAT_OMAP_FB_H__ */ | ||
diff --git a/arch/arm/plat-omap/include/plat/sram.h b/arch/arm/plat-omap/include/plat/sram.h index 16a1b458d53c..5905100b29a1 100644 --- a/arch/arm/plat-omap/include/plat/sram.h +++ b/arch/arm/plat-omap/include/plat/sram.h | |||
@@ -11,7 +11,6 @@ | |||
11 | #ifndef __ARCH_ARM_OMAP_SRAM_H | 11 | #ifndef __ARCH_ARM_OMAP_SRAM_H |
12 | #define __ARCH_ARM_OMAP_SRAM_H | 12 | #define __ARCH_ARM_OMAP_SRAM_H |
13 | 13 | ||
14 | extern int __init omap_sram_init(void); | ||
15 | extern void * omap_sram_push(void * start, unsigned long size); | 14 | extern void * omap_sram_push(void * start, unsigned long size); |
16 | extern void omap_sram_reprogram_clock(u32 dpllctl, u32 ckctl); | 15 | extern void omap_sram_reprogram_clock(u32 dpllctl, u32 ckctl); |
17 | 16 | ||
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index ecbfe398a309..b2e046990d38 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c | |||
@@ -33,7 +33,7 @@ | |||
33 | struct omap_mcbsp **mcbsp_ptr; | 33 | struct omap_mcbsp **mcbsp_ptr; |
34 | int omap_mcbsp_count, omap_mcbsp_cache_size; | 34 | int omap_mcbsp_count, omap_mcbsp_cache_size; |
35 | 35 | ||
36 | void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) | 36 | static void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) |
37 | { | 37 | { |
38 | if (cpu_class_is_omap1()) { | 38 | if (cpu_class_is_omap1()) { |
39 | ((u16 *)mcbsp->reg_cache)[reg / sizeof(u16)] = (u16)val; | 39 | ((u16 *)mcbsp->reg_cache)[reg / sizeof(u16)] = (u16)val; |
@@ -47,7 +47,7 @@ void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) | |||
47 | } | 47 | } |
48 | } | 48 | } |
49 | 49 | ||
50 | int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache) | 50 | static int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache) |
51 | { | 51 | { |
52 | if (cpu_class_is_omap1()) { | 52 | if (cpu_class_is_omap1()) { |
53 | return !from_cache ? __raw_readw(mcbsp->io_base + reg) : | 53 | return !from_cache ? __raw_readw(mcbsp->io_base + reg) : |
@@ -62,12 +62,12 @@ int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache) | |||
62 | } | 62 | } |
63 | 63 | ||
64 | #ifdef CONFIG_ARCH_OMAP3 | 64 | #ifdef CONFIG_ARCH_OMAP3 |
65 | void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) | 65 | static void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) |
66 | { | 66 | { |
67 | __raw_writel(val, mcbsp->st_data->io_base_st + reg); | 67 | __raw_writel(val, mcbsp->st_data->io_base_st + reg); |
68 | } | 68 | } |
69 | 69 | ||
70 | int omap_mcbsp_st_read(struct omap_mcbsp *mcbsp, u16 reg) | 70 | static int omap_mcbsp_st_read(struct omap_mcbsp *mcbsp, u16 reg) |
71 | { | 71 | { |
72 | return __raw_readl(mcbsp->st_data->io_base_st + reg); | 72 | return __raw_readl(mcbsp->st_data->io_base_st + reg); |
73 | } | 73 | } |
@@ -1648,7 +1648,7 @@ static const struct attribute_group sidetone_attr_group = { | |||
1648 | .attrs = (struct attribute **)sidetone_attrs, | 1648 | .attrs = (struct attribute **)sidetone_attrs, |
1649 | }; | 1649 | }; |
1650 | 1650 | ||
1651 | int __devinit omap_st_add(struct omap_mcbsp *mcbsp) | 1651 | static int __devinit omap_st_add(struct omap_mcbsp *mcbsp) |
1652 | { | 1652 | { |
1653 | struct omap_mcbsp_platform_data *pdata = mcbsp->pdata; | 1653 | struct omap_mcbsp_platform_data *pdata = mcbsp->pdata; |
1654 | struct omap_mcbsp_st_data *st_data; | 1654 | struct omap_mcbsp_st_data *st_data; |
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c index 98c86ff17205..dba5704b77db 100644 --- a/arch/arm/plat-omap/sram.c +++ b/arch/arm/plat-omap/sram.c | |||
@@ -19,6 +19,7 @@ | |||
19 | #include <linux/kernel.h> | 19 | #include <linux/kernel.h> |
20 | #include <linux/init.h> | 20 | #include <linux/init.h> |
21 | #include <linux/io.h> | 21 | #include <linux/io.h> |
22 | #include <linux/omapfb.h> | ||
22 | 23 | ||
23 | #include <asm/tlb.h> | 24 | #include <asm/tlb.h> |
24 | #include <asm/cacheflush.h> | 25 | #include <asm/cacheflush.h> |
@@ -31,6 +32,8 @@ | |||
31 | #include <plat/vram.h> | 32 | #include <plat/vram.h> |
32 | 33 | ||
33 | #include <plat/control.h> | 34 | #include <plat/control.h> |
35 | #include "sram.h" | ||
36 | #include "fb.h" | ||
34 | 37 | ||
35 | #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) | 38 | #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) |
36 | # include "../mach-omap2/prm.h" | 39 | # include "../mach-omap2/prm.h" |
@@ -79,12 +82,6 @@ static unsigned long omap_sram_base; | |||
79 | static unsigned long omap_sram_size; | 82 | static unsigned long omap_sram_size; |
80 | static unsigned long omap_sram_ceil; | 83 | static unsigned long omap_sram_ceil; |
81 | 84 | ||
82 | extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart, | ||
83 | unsigned long sram_vstart, | ||
84 | unsigned long sram_size, | ||
85 | unsigned long pstart_avail, | ||
86 | unsigned long size_avail); | ||
87 | |||
88 | /* | 85 | /* |
89 | * Depending on the target RAMFS firewall setup, the public usable amount of | 86 | * Depending on the target RAMFS firewall setup, the public usable amount of |
90 | * SRAM varies. The default accessible size for all device types is 2k. A GP | 87 | * SRAM varies. The default accessible size for all device types is 2k. A GP |
@@ -118,7 +115,7 @@ static int is_sram_locked(void) | |||
118 | * to secure SRAM will hang the system. Also the SRAM is not | 115 | * to secure SRAM will hang the system. Also the SRAM is not |
119 | * yet mapped at this point. | 116 | * yet mapped at this point. |
120 | */ | 117 | */ |
121 | void __init omap_detect_sram(void) | 118 | static void __init omap_detect_sram(void) |
122 | { | 119 | { |
123 | unsigned long reserved; | 120 | unsigned long reserved; |
124 | 121 | ||
@@ -204,7 +201,7 @@ static struct map_desc omap_sram_io_desc[] __initdata = { | |||
204 | /* | 201 | /* |
205 | * Note that we cannot use ioremap for SRAM, as clock init needs SRAM early. | 202 | * Note that we cannot use ioremap for SRAM, as clock init needs SRAM early. |
206 | */ | 203 | */ |
207 | void __init omap_map_sram(void) | 204 | static void __init omap_map_sram(void) |
208 | { | 205 | { |
209 | unsigned long base; | 206 | unsigned long base; |
210 | 207 | ||
@@ -336,7 +333,7 @@ u32 omap2_set_prcm(u32 dpll_ctrl_val, u32 sdrc_rfr_val, int bypass) | |||
336 | #endif | 333 | #endif |
337 | 334 | ||
338 | #ifdef CONFIG_ARCH_OMAP2420 | 335 | #ifdef CONFIG_ARCH_OMAP2420 |
339 | int __init omap242x_sram_init(void) | 336 | static int __init omap242x_sram_init(void) |
340 | { | 337 | { |
341 | _omap2_sram_ddr_init = omap_sram_push(omap242x_sram_ddr_init, | 338 | _omap2_sram_ddr_init = omap_sram_push(omap242x_sram_ddr_init, |
342 | omap242x_sram_ddr_init_sz); | 339 | omap242x_sram_ddr_init_sz); |
@@ -357,7 +354,7 @@ static inline int omap242x_sram_init(void) | |||
357 | #endif | 354 | #endif |
358 | 355 | ||
359 | #ifdef CONFIG_ARCH_OMAP2430 | 356 | #ifdef CONFIG_ARCH_OMAP2430 |
360 | int __init omap243x_sram_init(void) | 357 | static int __init omap243x_sram_init(void) |
361 | { | 358 | { |
362 | _omap2_sram_ddr_init = omap_sram_push(omap243x_sram_ddr_init, | 359 | _omap2_sram_ddr_init = omap_sram_push(omap243x_sram_ddr_init, |
363 | omap243x_sram_ddr_init_sz); | 360 | omap243x_sram_ddr_init_sz); |
@@ -413,7 +410,7 @@ void omap3_sram_restore_context(void) | |||
413 | } | 410 | } |
414 | #endif /* CONFIG_PM */ | 411 | #endif /* CONFIG_PM */ |
415 | 412 | ||
416 | int __init omap34xx_sram_init(void) | 413 | static int __init omap34xx_sram_init(void) |
417 | { | 414 | { |
418 | _omap3_sram_configure_core_dpll = | 415 | _omap3_sram_configure_core_dpll = |
419 | omap_sram_push(omap3_sram_configure_core_dpll, | 416 | omap_sram_push(omap3_sram_configure_core_dpll, |
@@ -429,7 +426,7 @@ static inline int omap34xx_sram_init(void) | |||
429 | #endif | 426 | #endif |
430 | 427 | ||
431 | #ifdef CONFIG_ARCH_OMAP4 | 428 | #ifdef CONFIG_ARCH_OMAP4 |
432 | int __init omap44xx_sram_init(void) | 429 | static int __init omap44xx_sram_init(void) |
433 | { | 430 | { |
434 | printk(KERN_ERR "FIXME: %s not implemented\n", __func__); | 431 | printk(KERN_ERR "FIXME: %s not implemented\n", __func__); |
435 | 432 | ||
diff --git a/arch/arm/plat-omap/sram.h b/arch/arm/plat-omap/sram.h new file mode 100644 index 000000000000..29b43ef97f20 --- /dev/null +++ b/arch/arm/plat-omap/sram.h | |||
@@ -0,0 +1,6 @@ | |||
1 | #ifndef __PLAT_OMAP_SRAM_H__ | ||
2 | #define __PLAT_OMAP_SRAM_H__ | ||
3 | |||
4 | extern int __init omap_sram_init(void); | ||
5 | |||
6 | #endif /* __PLAT_OMAP_SRAM_H__ */ | ||