diff options
author | Paul Walmsley <paul@pwsan.com> | 2012-04-13 08:34:26 -0400 |
---|---|---|
committer | Paul Walmsley <paul@pwsan.com> | 2012-04-13 08:34:26 -0400 |
commit | e2ed89fc4ef436269b63271f6633f1936e236aa8 (patch) | |
tree | 939c0e33bfa743e2224108170a658056719e9e21 /arch/arm | |
parent | 8c3d4534a8da0dc6a2d52b61585e61f7e8143096 (diff) |
ARM: OMAP: add includes for missing prototypes
Several C files in arch/arm/mach-omap* and arch/arm/plat-omap declare
functions that are used by other files, but don't include the header
file where the prototype is declared. This results in the following
warnings from sparse:
arch/arm/mach-omap2/irq.c:114:5: warning: symbol 'omap_irq_pending' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:186:13: warning: symbol 'omap2_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:191:13: warning: symbol 'omap3_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:196:13: warning: symbol 'ti81xx_init_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:233:39: warning: symbol 'omap2_intc_handle_irq' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:242:6: warning: symbol 'omap_intc_save_context' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:265:6: warning: symbol 'omap_intc_restore_context' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:291:6: warning: symbol 'omap3_intc_suspend' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:297:6: warning: symbol 'omap3_intc_prepare_idle' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:306:6: warning: symbol 'omap3_intc_resume_idle' was not declared. Should it be static?
arch/arm/mach-omap2/irq.c:312:39: warning: symbol 'omap3_intc_handle_irq' was not declared. Should it be static?
arch/arm/mach-omap2/omap-secure.c:59:12: warning: symbol 'omap_secure_ram_reserve_memblock' was not declared. Should it be static?
arch/arm/mach-omap2/board-zoom-display.c:133:13: warning: symbol 'zoom_display_init' was not declared. Should it be static?
arch/arm/plat-omap/common.c:73:13: warning: symbol 'omap_init_consistent_dma_size' was not declared. Should it be static?
arch/arm/mach-omap1/irq.c:61:5: warning: symbol 'omap_irq_flags' was not declared. Should it be static?
arch/arm/mach-omap1/irq.c:179:13: warning: symbol 'omap1_init_irq' was not declared. Should it be static?
arch/arm/mach-omap1/reset.c:11:6: warning: symbol 'omap1_restart' was not declared. Should it be static?
Fix by including the appropriate header files.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Diffstat (limited to 'arch/arm')
-rw-r--r-- | arch/arm/mach-omap1/common.h | 5 | ||||
-rw-r--r-- | arch/arm/mach-omap1/id.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap1/io.c | 3 | ||||
-rw-r--r-- | arch/arm/mach-omap1/irq.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap1/reset.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap2/board-zoom-display.c | 1 | ||||
-rw-r--r-- | arch/arm/mach-omap2/common.h | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap2/io.c | 1 | ||||
-rw-r--r-- | arch/arm/mach-omap2/irq.c | 1 | ||||
-rw-r--r-- | arch/arm/mach-omap2/omap-secure.c | 1 | ||||
-rw-r--r-- | arch/arm/plat-omap/common.c | 1 | ||||
-rw-r--r-- | arch/arm/plat-omap/include/plat/common.h | 2 | ||||
-rw-r--r-- | arch/arm/plat-omap/include/plat/dma.h | 1 |
13 files changed, 19 insertions, 5 deletions
diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h index af658ad338ec..ef656ff6ffd2 100644 --- a/arch/arm/mach-omap1/common.h +++ b/arch/arm/mach-omap1/common.h | |||
@@ -56,8 +56,11 @@ void omap1_init_early(void); | |||
56 | void omap1_init_irq(void); | 56 | void omap1_init_irq(void); |
57 | void omap1_restart(char, const char *); | 57 | void omap1_restart(char, const char *); |
58 | 58 | ||
59 | extern void __init omap_check_revision(void); | ||
60 | |||
59 | extern struct sys_timer omap1_timer; | 61 | extern struct sys_timer omap1_timer; |
60 | extern bool omap_32k_timer_init(void); | 62 | extern bool omap_32k_timer_init(void); |
61 | extern void __init omap_init_consistent_dma_size(void); | 63 | |
64 | extern u32 omap_irq_flags; | ||
62 | 65 | ||
63 | #endif /* __ARCH_ARM_MACH_OMAP1_COMMON_H */ | 66 | #endif /* __ARCH_ARM_MACH_OMAP1_COMMON_H */ |
diff --git a/arch/arm/mach-omap1/id.c b/arch/arm/mach-omap1/id.c index 2b28e1da14b0..a1b846aacdaf 100644 --- a/arch/arm/mach-omap1/id.c +++ b/arch/arm/mach-omap1/id.c | |||
@@ -21,6 +21,8 @@ | |||
21 | 21 | ||
22 | #include <mach/hardware.h> | 22 | #include <mach/hardware.h> |
23 | 23 | ||
24 | #include "common.h" | ||
25 | |||
24 | #define OMAP_DIE_ID_0 0xfffe1800 | 26 | #define OMAP_DIE_ID_0 0xfffe1800 |
25 | #define OMAP_DIE_ID_1 0xfffe1804 | 27 | #define OMAP_DIE_ID_1 0xfffe1804 |
26 | #define OMAP_PRODUCTION_ID_0 0xfffe2000 | 28 | #define OMAP_PRODUCTION_ID_0 0xfffe2000 |
diff --git a/arch/arm/mach-omap1/io.c b/arch/arm/mach-omap1/io.c index d969a7203d14..71ce017bf5d8 100644 --- a/arch/arm/mach-omap1/io.c +++ b/arch/arm/mach-omap1/io.c | |||
@@ -18,13 +18,12 @@ | |||
18 | 18 | ||
19 | #include <plat/mux.h> | 19 | #include <plat/mux.h> |
20 | #include <plat/tc.h> | 20 | #include <plat/tc.h> |
21 | #include <plat/dma.h> | ||
21 | 22 | ||
22 | #include "iomap.h" | 23 | #include "iomap.h" |
23 | #include "common.h" | 24 | #include "common.h" |
24 | #include "clock.h" | 25 | #include "clock.h" |
25 | 26 | ||
26 | extern void omap_check_revision(void); | ||
27 | |||
28 | /* | 27 | /* |
29 | * The machine specific code may provide the extra mapping besides the | 28 | * The machine specific code may provide the extra mapping besides the |
30 | * default mapping provided here. | 29 | * default mapping provided here. |
diff --git a/arch/arm/mach-omap1/irq.c b/arch/arm/mach-omap1/irq.c index 4448114fab72..6995fb6a3345 100644 --- a/arch/arm/mach-omap1/irq.c +++ b/arch/arm/mach-omap1/irq.c | |||
@@ -49,6 +49,8 @@ | |||
49 | 49 | ||
50 | #include <mach/hardware.h> | 50 | #include <mach/hardware.h> |
51 | 51 | ||
52 | #include "common.h" | ||
53 | |||
52 | #define IRQ_BANK(irq) ((irq) >> 5) | 54 | #define IRQ_BANK(irq) ((irq) >> 5) |
53 | #define IRQ_BIT(irq) ((irq) & 0x1f) | 55 | #define IRQ_BIT(irq) ((irq) & 0x1f) |
54 | 56 | ||
diff --git a/arch/arm/mach-omap1/reset.c b/arch/arm/mach-omap1/reset.c index f255b153b863..b17709103866 100644 --- a/arch/arm/mach-omap1/reset.c +++ b/arch/arm/mach-omap1/reset.c | |||
@@ -8,6 +8,8 @@ | |||
8 | 8 | ||
9 | #include <mach/hardware.h> | 9 | #include <mach/hardware.h> |
10 | 10 | ||
11 | #include "common.h" | ||
12 | |||
11 | void omap1_restart(char mode, const char *cmd) | 13 | void omap1_restart(char mode, const char *cmd) |
12 | { | 14 | { |
13 | /* | 15 | /* |
diff --git a/arch/arm/mach-omap2/board-zoom-display.c b/arch/arm/mach-omap2/board-zoom-display.c index a43a765dd092..28187f134fff 100644 --- a/arch/arm/mach-omap2/board-zoom-display.c +++ b/arch/arm/mach-omap2/board-zoom-display.c | |||
@@ -16,6 +16,7 @@ | |||
16 | #include <linux/spi/spi.h> | 16 | #include <linux/spi/spi.h> |
17 | #include <plat/mcspi.h> | 17 | #include <plat/mcspi.h> |
18 | #include <video/omapdss.h> | 18 | #include <video/omapdss.h> |
19 | #include <mach/board-zoom.h> | ||
19 | 20 | ||
20 | #define LCD_PANEL_RESET_GPIO_PROD 96 | 21 | #define LCD_PANEL_RESET_GPIO_PROD 96 |
21 | #define LCD_PANEL_RESET_GPIO_PILOT 55 | 22 | #define LCD_PANEL_RESET_GPIO_PILOT 55 |
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h index 57da7f406e28..0e95efccd2d7 100644 --- a/arch/arm/mach-omap2/common.h +++ b/arch/arm/mach-omap2/common.h | |||
@@ -134,8 +134,6 @@ void omap4_map_io(void); | |||
134 | void ti81xx_map_io(void); | 134 | void ti81xx_map_io(void); |
135 | void omap_barriers_init(void); | 135 | void omap_barriers_init(void); |
136 | 136 | ||
137 | extern void __init omap_init_consistent_dma_size(void); | ||
138 | |||
139 | /** | 137 | /** |
140 | * omap_test_timeout - busy-loop, testing a condition | 138 | * omap_test_timeout - busy-loop, testing a condition |
141 | * @cond: condition to test until it evaluates to true | 139 | * @cond: condition to test until it evaluates to true |
diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c index 065bd768987c..2d5a57669a79 100644 --- a/arch/arm/mach-omap2/io.c +++ b/arch/arm/mach-omap2/io.c | |||
@@ -31,6 +31,7 @@ | |||
31 | #include <plat/omap-pm.h> | 31 | #include <plat/omap-pm.h> |
32 | #include <plat/omap_hwmod.h> | 32 | #include <plat/omap_hwmod.h> |
33 | #include <plat/multi.h> | 33 | #include <plat/multi.h> |
34 | #include <plat/dma.h> | ||
34 | 35 | ||
35 | #include "iomap.h" | 36 | #include "iomap.h" |
36 | #include "voltage.h" | 37 | #include "voltage.h" |
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 65f0d2571c9a..14fbc781338f 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include <mach/hardware.h> | 25 | #include <mach/hardware.h> |
26 | 26 | ||
27 | #include "iomap.h" | 27 | #include "iomap.h" |
28 | #include "common.h" | ||
28 | 29 | ||
29 | /* selected INTC register offsets */ | 30 | /* selected INTC register offsets */ |
30 | 31 | ||
diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c index d8f8ef40290f..d9ae4a53d818 100644 --- a/arch/arm/mach-omap2/omap-secure.c +++ b/arch/arm/mach-omap2/omap-secure.c | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <asm/cacheflush.h> | 18 | #include <asm/cacheflush.h> |
19 | #include <asm/memblock.h> | 19 | #include <asm/memblock.h> |
20 | 20 | ||
21 | #include <plat/omap-secure.h> | ||
21 | #include <mach/omap-secure.h> | 22 | #include <mach/omap-secure.h> |
22 | 23 | ||
23 | static phys_addr_t omap_secure_memblock_base; | 24 | static phys_addr_t omap_secure_memblock_base; |
diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c index f1e46ea6b81d..0a9b9a970113 100644 --- a/arch/arm/plat-omap/common.c +++ b/arch/arm/plat-omap/common.c | |||
@@ -20,6 +20,7 @@ | |||
20 | #include <plat/board.h> | 20 | #include <plat/board.h> |
21 | #include <plat/vram.h> | 21 | #include <plat/vram.h> |
22 | #include <plat/dsp.h> | 22 | #include <plat/dsp.h> |
23 | #include <plat/dma.h> | ||
23 | 24 | ||
24 | #include <plat/omap-secure.h> | 25 | #include <plat/omap-secure.h> |
25 | 26 | ||
diff --git a/arch/arm/plat-omap/include/plat/common.h b/arch/arm/plat-omap/include/plat/common.h index b4d7ec3fbfbe..a557b8484e6c 100644 --- a/arch/arm/plat-omap/include/plat/common.h +++ b/arch/arm/plat-omap/include/plat/common.h | |||
@@ -32,6 +32,8 @@ | |||
32 | 32 | ||
33 | extern int __init omap_init_clocksource_32k(void); | 33 | extern int __init omap_init_clocksource_32k(void); |
34 | 34 | ||
35 | extern void __init omap_check_revision(void); | ||
36 | |||
35 | extern void omap_reserve(void); | 37 | extern void omap_reserve(void); |
36 | extern int omap_dss_reset(struct omap_hwmod *); | 38 | extern int omap_dss_reset(struct omap_hwmod *); |
37 | 39 | ||
diff --git a/arch/arm/plat-omap/include/plat/dma.h b/arch/arm/plat-omap/include/plat/dma.h index dc562a5c0a8a..42afb4c45517 100644 --- a/arch/arm/plat-omap/include/plat/dma.h +++ b/arch/arm/plat-omap/include/plat/dma.h | |||
@@ -442,6 +442,7 @@ struct omap_system_dma_plat_info { | |||
442 | u32 (*dma_read)(int reg, int lch); | 442 | u32 (*dma_read)(int reg, int lch); |
443 | }; | 443 | }; |
444 | 444 | ||
445 | extern void __init omap_init_consistent_dma_size(void); | ||
445 | extern void omap_set_dma_priority(int lch, int dst_port, int priority); | 446 | extern void omap_set_dma_priority(int lch, int dst_port, int priority); |
446 | extern int omap_request_dma(int dev_id, const char *dev_name, | 447 | extern int omap_request_dma(int dev_id, const char *dev_name, |
447 | void (*callback)(int lch, u16 ch_status, void *data), | 448 | void (*callback)(int lch, u16 ch_status, void *data), |