diff options
author | Will Deacon <will.deacon@arm.com> | 2011-03-04 06:38:54 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2011-03-09 16:40:18 -0500 |
commit | 5dab26af1bacad9a7189d904fbc8b4fe8e95dd81 (patch) | |
tree | 246c70038035ee4a0505f2b043ecb3c73018b01b /arch/arm | |
parent | fcbdc5fe6ebe07d502c9b652cb63376bcc4227ac (diff) |
ARM: 6784/1: errata: no automatic Store Buffer drain on Cortex-A9
On revisions of the Cortex-A9 prior to r2p0, the Store Buffer does not
have any automatic draining mechanism and therefore a livelock may occur
if an external agent continuously polls a memory location waiting to
observe an update.
This workaround defines cpu_relax() as smp_mb(), preventing correctly
written polling loops from denying visibility of updates to memory.
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm')
-rw-r--r-- | arch/arm/Kconfig | 11 | ||||
-rw-r--r-- | arch/arm/include/asm/processor.h | 2 |
2 files changed, 12 insertions, 1 deletions
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index ec0f6589af05..d3f2de37a4b7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig | |||
@@ -1213,6 +1213,17 @@ config ARM_ERRATA_754322 | |||
1213 | the new ASID. This workaround places two dsb instructions in the mm | 1213 | the new ASID. This workaround places two dsb instructions in the mm |
1214 | switching code so that no page table walks can cross the ASID switch. | 1214 | switching code so that no page table walks can cross the ASID switch. |
1215 | 1215 | ||
1216 | config ARM_ERRATA_754327 | ||
1217 | bool "ARM errata: no automatic Store Buffer drain" | ||
1218 | depends on CPU_V7 && SMP | ||
1219 | help | ||
1220 | This option enables the workaround for the 754327 Cortex-A9 (prior to | ||
1221 | r2p0) erratum. The Store Buffer does not have any automatic draining | ||
1222 | mechanism and therefore a livelock may occur if an external agent | ||
1223 | continuously polls a memory location waiting to observe an update. | ||
1224 | This workaround defines cpu_relax() as smp_mb(), preventing correctly | ||
1225 | written polling loops from denying visibility of updates to memory. | ||
1226 | |||
1216 | endmenu | 1227 | endmenu |
1217 | 1228 | ||
1218 | source "arch/arm/common/Kconfig" | 1229 | source "arch/arm/common/Kconfig" |
diff --git a/arch/arm/include/asm/processor.h b/arch/arm/include/asm/processor.h index 67357baaeeeb..7a1f03c10f1b 100644 --- a/arch/arm/include/asm/processor.h +++ b/arch/arm/include/asm/processor.h | |||
@@ -95,7 +95,7 @@ extern void release_thread(struct task_struct *); | |||
95 | 95 | ||
96 | unsigned long get_wchan(struct task_struct *p); | 96 | unsigned long get_wchan(struct task_struct *p); |
97 | 97 | ||
98 | #if __LINUX_ARM_ARCH__ == 6 | 98 | #if __LINUX_ARM_ARCH__ == 6 || defined(CONFIG_ARM_ERRATA_754327) |
99 | #define cpu_relax() smp_mb() | 99 | #define cpu_relax() smp_mb() |
100 | #else | 100 | #else |
101 | #define cpu_relax() barrier() | 101 | #define cpu_relax() barrier() |