diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-10-06 12:12:25 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-10-13 12:11:28 -0400 |
commit | b1b3f49ce4606452279b58b17f2bbe2ba00304b7 (patch) | |
tree | c9cfdc72dd580a9c3ace71846af45b4f65268f46 /arch/arm/plat-samsung | |
parent | 4f1cd91497774488ed16119ec3f54b3daf1561de (diff) |
ARM: config: sort select statements alphanumerically
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/plat-samsung')
-rw-r--r-- | arch/arm/plat-samsung/Kconfig | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 9c3b90c3538e..59401e1cc530 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig | |||
@@ -7,9 +7,9 @@ | |||
7 | config PLAT_SAMSUNG | 7 | config PLAT_SAMSUNG |
8 | bool | 8 | bool |
9 | depends on PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P | 9 | depends on PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P |
10 | select NO_IOPORT | ||
11 | select GENERIC_IRQ_CHIP | ||
12 | default y | 10 | default y |
11 | select GENERIC_IRQ_CHIP | ||
12 | select NO_IOPORT | ||
13 | help | 13 | help |
14 | Base platform code for all Samsung SoC based systems | 14 | Base platform code for all Samsung SoC based systems |
15 | 15 | ||
@@ -17,16 +17,16 @@ config PLAT_S5P | |||
17 | bool | 17 | bool |
18 | depends on (ARCH_S5P64X0 || ARCH_S5PC100 || ARCH_S5PV210 || ARCH_EXYNOS) | 18 | depends on (ARCH_S5P64X0 || ARCH_S5PC100 || ARCH_S5PV210 || ARCH_EXYNOS) |
19 | default y | 19 | default y |
20 | select ARM_VIC if !ARCH_EXYNOS | 20 | select ARCH_REQUIRE_GPIOLIB |
21 | select ARM_GIC if ARCH_EXYNOS | 21 | select ARM_GIC if ARCH_EXYNOS |
22 | select ARM_VIC if !ARCH_EXYNOS | ||
22 | select GIC_NON_BANKED if ARCH_EXYNOS4 | 23 | select GIC_NON_BANKED if ARCH_EXYNOS4 |
23 | select NO_IOPORT | 24 | select NO_IOPORT |
24 | select ARCH_REQUIRE_GPIOLIB | 25 | select PLAT_SAMSUNG |
25 | select S3C_GPIO_TRACK | 26 | select S3C_GPIO_TRACK |
26 | select S5P_GPIO_DRVSTR | 27 | select S5P_GPIO_DRVSTR |
27 | select SAMSUNG_GPIOLIB_4BIT | ||
28 | select PLAT_SAMSUNG | ||
29 | select SAMSUNG_CLKSRC | 28 | select SAMSUNG_CLKSRC |
29 | select SAMSUNG_GPIOLIB_4BIT | ||
30 | select SAMSUNG_IRQ_VIC_TIMER | 30 | select SAMSUNG_IRQ_VIC_TIMER |
31 | help | 31 | help |
32 | Base platform code for Samsung's S5P series SoC. | 32 | Base platform code for Samsung's S5P series SoC. |
@@ -423,10 +423,10 @@ config S3C_DMA | |||
423 | 423 | ||
424 | config SAMSUNG_DMADEV | 424 | config SAMSUNG_DMADEV |
425 | bool | 425 | bool |
426 | select ARM_AMBA | ||
426 | select DMADEVICES | 427 | select DMADEVICES |
427 | select PL330_DMA if (ARCH_EXYNOS5 || ARCH_EXYNOS4 || CPU_S5PV210 || CPU_S5PC100 || \ | 428 | select PL330_DMA if (ARCH_EXYNOS5 || ARCH_EXYNOS4 || CPU_S5PV210 || CPU_S5PC100 || \ |
428 | CPU_S5P6450 || CPU_S5P6440) | 429 | CPU_S5P6450 || CPU_S5P6440) |
429 | select ARM_AMBA | ||
430 | help | 430 | help |
431 | Use DMA device engine for PL330 DMAC. | 431 | Use DMA device engine for PL330 DMAC. |
432 | 432 | ||