ARM: Orion: DT support for IRQ and GPIO Controllers

Both IRQ and GPIO controllers can now be represented in DT.  The IRQ
controllers are setup first, and then the GPIO controllers. Interrupts
for GPIO lines are placed directly after the main interrupts in the
interrupt space.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Josh Coombs <josh.coombs@gmail.com>
Tested-by: Simon Baatz <gmbnomis@gmail.com>

4 files changed, 173 insertions, 52 deletions

diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
index af95af257301..dfda74fae6f2 100644
--- a/arch/arm/plat-orion/gpio.c
+++ b/arch/arm/plat-orion/gpio.c
@@ -8,15 +8,22 @@
  * warranty of any kind, whether express or implied.
  */
 
+#define DEBUG
+
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/irq.h>
+#include <linux/irqdomain.h>
 #include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/bitops.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
+#include <linux/of.h>
+#include <linux/of_irq.h>
+#include <linux/of_address.h>
+#include <plat/gpio.h>
 
 /*
  * GPIO unit register offsets.
@@ -38,6 +45,7 @@ struct orion_gpio_chip {
         unsigned long           valid_output;
         int                     mask_offset;
         int                     secondary_irq_base;
+        struct irq_domain       *domain;
 };
 
 static void __iomem *GPIO_OUT(struct orion_gpio_chip *ochip)
@@ -222,10 +230,10 @@ static int orion_gpio_to_irq(struct gpio_chip *chip, unsigned pin)
         struct orion_gpio_chip *ochip =
                 container_of(chip, struct orion_gpio_chip, chip);
 
-        return ochip->secondary_irq_base + pin;
+        return irq_create_mapping(ochip->domain,
+                                  ochip->secondary_irq_base + pin);
 }
 
-
 /*
  * Orion-specific GPIO API extensions.
  */
@@ -353,12 +361,10 @@ static int gpio_irq_set_type(struct irq_data *d, u32 type)
         int pin;
         u32 u;
 
-        pin = d->irq - gc->irq_base;
+        pin = d->hwirq - ochip->secondary_irq_base;
 
         u = readl(GPIO_IO_CONF(ochip)) & (1 << pin);
         if (!u) {
-                printk(KERN_ERR "orion gpio_irq_set_type failed "
-                                "(irq %d, pin %d).\n", d->irq, pin);
                 return -EINVAL;
         }
 
@@ -397,17 +403,53 @@ static int gpio_irq_set_type(struct irq_data *d, u32 type)
                         u &= ~(1 << pin);       /* rising */
                 writel(u, GPIO_IN_POL(ochip));
         }
-
         return 0;
 }
 
-void __init orion_gpio_init(int gpio_base, int ngpio,
-                            u32 base, int mask_offset, int secondary_irq_base)
+static void gpio_irq_handler(unsigned irq, struct irq_desc *desc)
+{
+        struct orion_gpio_chip *ochip = irq_get_handler_data(irq);
+        u32 cause, type;
+        int i;
+
+        if (ochip == NULL)
+                return;
+
+        cause = readl(GPIO_DATA_IN(ochip)) & readl(GPIO_LEVEL_MASK(ochip));
+        cause |= readl(GPIO_EDGE_CAUSE(ochip)) & readl(GPIO_EDGE_MASK(ochip));
+
+        for (i = 0; i < ochip->chip.ngpio; i++) {
+                int irq;
+
+                irq = ochip->secondary_irq_base + i;
+
+                if (!(cause & (1 << i)))
+                        continue;
+
+                type = irqd_get_trigger_type(irq_get_irq_data(irq));
+                if ((type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) {
+                        /* Swap polarity (race with GPIO line) */
+                        u32 polarity;
+
+                        polarity = readl(GPIO_IN_POL(ochip));
+                        polarity ^= 1 << i;
+                        writel(polarity, GPIO_IN_POL(ochip));
+                }
+                generic_handle_irq(irq);
+        }
+}
+
+void __init orion_gpio_init(struct device_node *np,
+                            int gpio_base, int ngpio,
+                            void __iomem *base, int mask_offset,
+                            int secondary_irq_base,
+                            int irqs[4])
 {
         struct orion_gpio_chip *ochip;
         struct irq_chip_generic *gc;
         struct irq_chip_type *ct;
         char gc_label[16];
+        int i;
 
         if (orion_gpio_chip_count == ARRAY_SIZE(orion_gpio_chips))
                 return;
@@ -426,6 +468,10 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
         ochip->chip.base = gpio_base;
         ochip->chip.ngpio = ngpio;
         ochip->chip.can_sleep = 0;
+#ifdef CONFIG_OF
+        ochip->chip.of_node = np;
+#endif
+
         spin_lock_init(&ochip->lock);
         ochip->base = (void __iomem *)base;
         ochip->valid_input = 0;
@@ -435,8 +481,6 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
 
         gpiochip_add(&ochip->chip);
 
-        orion_gpio_chip_count++;
-
         /*
          * Mask and clear GPIO interrupts.
          */
@@ -444,16 +488,28 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
         writel(0, GPIO_EDGE_MASK(ochip));
         writel(0, GPIO_LEVEL_MASK(ochip));
 
-        gc = irq_alloc_generic_chip("orion_gpio_irq", 2, secondary_irq_base,
+        /* Setup the interrupt handlers. Each chip can have up to 4
+         * interrupt handlers, with each handler dealing with 8 GPIO
+         * pins. */
+
+        for (i = 0; i < 4; i++) {
+                if (irqs[i]) {
+                        irq_set_handler_data(irqs[i], ochip);
+                        irq_set_chained_handler(irqs[i], gpio_irq_handler);
+                }
+        }
+
+        gc = irq_alloc_generic_chip("orion_gpio_irq", 2,
+                                    secondary_irq_base,
                                     ochip->base, handle_level_irq);
         gc->private = ochip;
-
         ct = gc->chip_types;
         ct->regs.mask = ochip->mask_offset + GPIO_LEVEL_MASK_OFF;
         ct->type = IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW;
         ct->chip.irq_mask = irq_gc_mask_clr_bit;
         ct->chip.irq_unmask = irq_gc_mask_set_bit;
         ct->chip.irq_set_type = gpio_irq_set_type;
+        ct->chip.name = ochip->chip.label;
 
         ct++;
         ct->regs.mask = ochip->mask_offset + GPIO_EDGE_MASK_OFF;
@@ -464,41 +520,69 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
         ct->chip.irq_unmask = irq_gc_mask_set_bit;
         ct->chip.irq_set_type = gpio_irq_set_type;
         ct->handler = handle_edge_irq;
+        ct->chip.name = ochip->chip.label;
 
         irq_setup_generic_chip(gc, IRQ_MSK(ngpio), IRQ_GC_INIT_MASK_CACHE,
                                IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE);
-}
 
-void orion_gpio_irq_handler(int pinoff)
-{
-        struct orion_gpio_chip *ochip;
-        u32 cause, type;
-        int i;
-
-        ochip = orion_gpio_chip_find(pinoff);
-        if (ochip == NULL)
-                return;
-
-        cause = readl(GPIO_DATA_IN(ochip)) & readl(GPIO_LEVEL_MASK(ochip));
-        cause |= readl(GPIO_EDGE_CAUSE(ochip)) & readl(GPIO_EDGE_MASK(ochip));
-
-        for (i = 0; i < ochip->chip.ngpio; i++) {
-                int irq;
+        /* Setup irq domain on top of the generic chip. */
+        ochip->domain = irq_domain_add_legacy(np,
+                                              ochip->chip.ngpio,
+                                              ochip->secondary_irq_base,
+                                              ochip->secondary_irq_base,
+                                              &irq_domain_simple_ops,
+                                              ochip);
+        if (!ochip->domain)
+                panic("%s: couldn't allocate irq domain (DT).\n",
+                      ochip->chip.label);
 
-                irq = ochip->secondary_irq_base + i;
+        orion_gpio_chip_count++;
+}
 
-                if (!(cause & (1 << i)))
-                        continue;
+#ifdef CONFIG_OF
+static void __init orion_gpio_of_init_one(struct device_node *np,
+                                          int irq_gpio_base)
+{
+        int ngpio, gpio_base, mask_offset;
+        void __iomem *base;
+        int ret, i;
+        int irqs[4];
+        int secondary_irq_base;
+
+        ret = of_property_read_u32(np, "ngpio", &ngpio);
+        if (ret)
+                goto out;
+        ret = of_property_read_u32(np, "mask-offset", &mask_offset);
+        if (ret == -EINVAL)
+                mask_offset = 0;
+        else
+                goto out;
+        base = of_iomap(np, 0);
+        if (!base)
+                goto out;
+
+        secondary_irq_base = irq_gpio_base + (32 * orion_gpio_chip_count);
+        gpio_base = 32 * orion_gpio_chip_count;
+
+        /* Get the interrupt numbers. Each chip can have up to 4
+         * interrupt handlers, with each handler dealing with 8 GPIO
+         * pins. */
+
+        for (i = 0; i < 4; i++)
+                irqs[i] = irq_of_parse_and_map(np, i);
+
+        orion_gpio_init(np, gpio_base, ngpio, base, mask_offset,
+                        secondary_irq_base, irqs);
+        return;
+out:
+        pr_err("%s: %s: missing mandatory property\n", __func__, np->name);
+}
 
-                type = irqd_get_trigger_type(irq_get_irq_data(irq));
-                if ((type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) {
-                        /* Swap polarity (race with GPIO line) */
-                        u32 polarity;
+void __init orion_gpio_of_init(int irq_gpio_base)
+{
+        struct device_node *np;
 
-                        polarity = readl(GPIO_IN_POL(ochip));
-                        polarity ^= 1 << i;
-                        writel(polarity, GPIO_IN_POL(ochip));
-                }
-                generic_handle_irq(irq);
-        }
+        for_each_compatible_node(np, NULL, "marvell,orion-gpio")
+                orion_gpio_of_init_one(np, irq_gpio_base);
 }
+#endif
diff --git a/arch/arm/plat-orion/include/plat/gpio.h b/arch/arm/plat-orion/include/plat/gpio.h
index bec0c98ce41f..81c6fc8a7b28 100644
--- a/arch/arm/plat-orion/include/plat/gpio.h
+++ b/arch/arm/plat-orion/include/plat/gpio.h
@@ -13,7 +13,7 @@
 
 #include <linux/init.h>
 #include <linux/types.h>
-
+#include <linux/irqdomain.h>
 /*
  * Orion-specific GPIO API extensions.
  */
@@ -27,13 +27,11 @@ int orion_gpio_led_blink_set(unsigned gpio, int state,
 void orion_gpio_set_valid(unsigned pin, int mode);
 
 /* Initialize gpiolib. */
-void __init orion_gpio_init(int gpio_base, int ngpio,
-                            u32 base, int mask_offset, int secondary_irq_base);
-
-/*
- * GPIO interrupt handling.
- */
-void orion_gpio_irq_handler(int irqoff);
-
+void __init orion_gpio_init(struct device_node *np,
+                            int gpio_base, int ngpio,
+                            void __iomem *base, int mask_offset,
+                            int secondary_irq_base,
+                            int irq[4]);
 
+void __init orion_gpio_of_init(int irq_gpio_base);
 #endif
diff --git a/arch/arm/plat-orion/include/plat/irq.h b/arch/arm/plat-orion/include/plat/irq.h
index f05eeab94968..50547e417936 100644
--- a/arch/arm/plat-orion/include/plat/irq.h
+++ b/arch/arm/plat-orion/include/plat/irq.h
@@ -12,6 +12,5 @@
 #define __PLAT_IRQ_H
 
 void orion_irq_init(unsigned int irq_start, void __iomem *maskaddr);
-
-
+void __init orion_dt_init_irq(void);
 #endif
diff --git a/arch/arm/plat-orion/irq.c b/arch/arm/plat-orion/irq.c
index 2d5b9c1ef389..d751964def4c 100644
--- a/arch/arm/plat-orion/irq.c
+++ b/arch/arm/plat-orion/irq.c
@@ -11,8 +11,12 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/irq.h>
+#include <linux/irqdomain.h>
 #include <linux/io.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
 #include <plat/irq.h>
+#include <plat/gpio.h>
 
 void __init orion_irq_init(unsigned int irq_start, void __iomem *maskaddr)
 {
@@ -32,3 +36,39 @@ void __init orion_irq_init(unsigned int irq_start, void __iomem *maskaddr)
         irq_setup_generic_chip(gc, IRQ_MSK(32), IRQ_GC_INIT_MASK_CACHE,
                                IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE);
 }
+
+#ifdef CONFIG_OF
+static int __init orion_add_irq_domain(struct device_node *np,
+                                       struct device_node *interrupt_parent)
+{
+        int i = 0, irq_gpio;
+        void __iomem *base;
+
+        do {
+                base = of_iomap(np, i);
+                if (base) {
+                        orion_irq_init(i * 32, base);
+                        i++;
+                }
+        } while (base);
+
+        irq_domain_add_legacy(np, i * 32, 0, 0,
+                              &irq_domain_simple_ops, NULL);
+
+        irq_gpio = i * 32;
+        orion_gpio_of_init(irq_gpio);
+
+        return 0;
+}
+
+static const struct of_device_id orion_irq_match[] = {
+        { .compatible = "marvell,orion-intc",
+          .data = orion_add_irq_domain, },
+        {},
+};
+
+void __init orion_dt_init_irq(void)
+{
+        of_irq_init(orion_irq_match);
+}
+#endif