diff options
author | Paul Walmsley <paul@pwsan.com> | 2012-07-26 02:54:26 -0400 |
---|---|---|
committer | Paul Walmsley <paul@pwsan.com> | 2012-09-12 04:57:10 -0400 |
commit | 7852ec0536ca39cefffc6301dc77f8ae55592926 (patch) | |
tree | faa867a05d6571d5027b3fbfdf452678b3d35d38 /arch/arm/plat-omap/dma.c | |
parent | a032d33b65c89a781c871fd1def595fa6a69b52a (diff) |
ARM: OMAP: unwrap strings
Find and unwrap wrapped strings in the style:
pr_debug("clockdomain: hardware cannot set/clear wake up of "
"%s when %s wakes up\n", clkdm1->name, clkdm2->name);
Keeping these strings contiguous seems to be the current Linux kernel
policy.
The offending lines were found with the following command:
pcregrep -rnM '"\s*$\s*"' arch/arm/*omap*
While here, some messages have been clarified, some pr_warning(
... calls have been converted to pr_warn( ..., and some printk(KERN_*
... have been converted to pr_*.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Diffstat (limited to 'arch/arm/plat-omap/dma.c')
-rw-r--r-- | arch/arm/plat-omap/dma.c | 51 |
1 files changed, 22 insertions, 29 deletions
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 7fe626761e53..4b3829ae5337 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c | |||
@@ -969,8 +969,7 @@ void omap_stop_dma(int lch) | |||
969 | l = p->dma_read(CCR, lch); | 969 | l = p->dma_read(CCR, lch); |
970 | } | 970 | } |
971 | if (i >= 100) | 971 | if (i >= 100) |
972 | printk(KERN_ERR "DMA drain did not complete on " | 972 | pr_err("DMA drain did not complete on lch %d\n", lch); |
973 | "lch %d\n", lch); | ||
974 | /* Restore OCP_SYSCONFIG */ | 973 | /* Restore OCP_SYSCONFIG */ |
975 | p->dma_write(sys_cf, OCP_SYSCONFIG, lch); | 974 | p->dma_write(sys_cf, OCP_SYSCONFIG, lch); |
976 | } else { | 975 | } else { |
@@ -1154,8 +1153,7 @@ void omap_dma_link_lch(int lch_head, int lch_queue) | |||
1154 | 1153 | ||
1155 | if ((dma_chan[lch_head].dev_id == -1) || | 1154 | if ((dma_chan[lch_head].dev_id == -1) || |
1156 | (dma_chan[lch_queue].dev_id == -1)) { | 1155 | (dma_chan[lch_queue].dev_id == -1)) { |
1157 | printk(KERN_ERR "omap_dma: trying to link " | 1156 | pr_err("omap_dma: trying to link non requested channels\n"); |
1158 | "non requested channels\n"); | ||
1159 | dump_stack(); | 1157 | dump_stack(); |
1160 | } | 1158 | } |
1161 | 1159 | ||
@@ -1181,15 +1179,13 @@ void omap_dma_unlink_lch(int lch_head, int lch_queue) | |||
1181 | 1179 | ||
1182 | if (dma_chan[lch_head].next_lch != lch_queue || | 1180 | if (dma_chan[lch_head].next_lch != lch_queue || |
1183 | dma_chan[lch_head].next_lch == -1) { | 1181 | dma_chan[lch_head].next_lch == -1) { |
1184 | printk(KERN_ERR "omap_dma: trying to unlink " | 1182 | pr_err("omap_dma: trying to unlink non linked channels\n"); |
1185 | "non linked channels\n"); | ||
1186 | dump_stack(); | 1183 | dump_stack(); |
1187 | } | 1184 | } |
1188 | 1185 | ||
1189 | if ((dma_chan[lch_head].flags & OMAP_DMA_ACTIVE) || | 1186 | if ((dma_chan[lch_head].flags & OMAP_DMA_ACTIVE) || |
1190 | (dma_chan[lch_queue].flags & OMAP_DMA_ACTIVE)) { | 1187 | (dma_chan[lch_queue].flags & OMAP_DMA_ACTIVE)) { |
1191 | printk(KERN_ERR "omap_dma: You need to stop the DMA channels " | 1188 | pr_err("omap_dma: You need to stop the DMA channels before unlinking\n"); |
1192 | "before unlinking\n"); | ||
1193 | dump_stack(); | 1189 | dump_stack(); |
1194 | } | 1190 | } |
1195 | 1191 | ||
@@ -1831,16 +1827,15 @@ static int omap1_dma_handle_ch(int ch) | |||
1831 | if ((csr & 0x3f) == 0) | 1827 | if ((csr & 0x3f) == 0) |
1832 | return 0; | 1828 | return 0; |
1833 | if (unlikely(dma_chan[ch].dev_id == -1)) { | 1829 | if (unlikely(dma_chan[ch].dev_id == -1)) { |
1834 | printk(KERN_WARNING "Spurious interrupt from DMA channel " | 1830 | pr_warn("Spurious interrupt from DMA channel %d (CSR %04x)\n", |
1835 | "%d (CSR %04x)\n", ch, csr); | 1831 | ch, csr); |
1836 | return 0; | 1832 | return 0; |
1837 | } | 1833 | } |
1838 | if (unlikely(csr & OMAP1_DMA_TOUT_IRQ)) | 1834 | if (unlikely(csr & OMAP1_DMA_TOUT_IRQ)) |
1839 | printk(KERN_WARNING "DMA timeout with device %d\n", | 1835 | pr_warn("DMA timeout with device %d\n", dma_chan[ch].dev_id); |
1840 | dma_chan[ch].dev_id); | ||
1841 | if (unlikely(csr & OMAP_DMA_DROP_IRQ)) | 1836 | if (unlikely(csr & OMAP_DMA_DROP_IRQ)) |
1842 | printk(KERN_WARNING "DMA synchronization event drop occurred " | 1837 | pr_warn("DMA synchronization event drop occurred with device %d\n", |
1843 | "with device %d\n", dma_chan[ch].dev_id); | 1838 | dma_chan[ch].dev_id); |
1844 | if (likely(csr & OMAP_DMA_BLOCK_IRQ)) | 1839 | if (likely(csr & OMAP_DMA_BLOCK_IRQ)) |
1845 | dma_chan[ch].flags &= ~OMAP_DMA_ACTIVE; | 1840 | dma_chan[ch].flags &= ~OMAP_DMA_ACTIVE; |
1846 | if (likely(dma_chan[ch].callback != NULL)) | 1841 | if (likely(dma_chan[ch].callback != NULL)) |
@@ -1880,21 +1875,19 @@ static int omap2_dma_handle_ch(int ch) | |||
1880 | 1875 | ||
1881 | if (!status) { | 1876 | if (!status) { |
1882 | if (printk_ratelimit()) | 1877 | if (printk_ratelimit()) |
1883 | printk(KERN_WARNING "Spurious DMA IRQ for lch %d\n", | 1878 | pr_warn("Spurious DMA IRQ for lch %d\n", ch); |
1884 | ch); | ||
1885 | p->dma_write(1 << ch, IRQSTATUS_L0, ch); | 1879 | p->dma_write(1 << ch, IRQSTATUS_L0, ch); |
1886 | return 0; | 1880 | return 0; |
1887 | } | 1881 | } |
1888 | if (unlikely(dma_chan[ch].dev_id == -1)) { | 1882 | if (unlikely(dma_chan[ch].dev_id == -1)) { |
1889 | if (printk_ratelimit()) | 1883 | if (printk_ratelimit()) |
1890 | printk(KERN_WARNING "IRQ %04x for non-allocated DMA" | 1884 | pr_warn("IRQ %04x for non-allocated DMA channel %d\n", |
1891 | "channel %d\n", status, ch); | 1885 | status, ch); |
1892 | return 0; | 1886 | return 0; |
1893 | } | 1887 | } |
1894 | if (unlikely(status & OMAP_DMA_DROP_IRQ)) | 1888 | if (unlikely(status & OMAP_DMA_DROP_IRQ)) |
1895 | printk(KERN_INFO | 1889 | pr_info("DMA synchronization event drop occurred with device %d\n", |
1896 | "DMA synchronization event drop occurred with device " | 1890 | dma_chan[ch].dev_id); |
1897 | "%d\n", dma_chan[ch].dev_id); | ||
1898 | if (unlikely(status & OMAP2_DMA_TRANS_ERR_IRQ)) { | 1891 | if (unlikely(status & OMAP2_DMA_TRANS_ERR_IRQ)) { |
1899 | printk(KERN_INFO "DMA transaction error with device %d\n", | 1892 | printk(KERN_INFO "DMA transaction error with device %d\n", |
1900 | dma_chan[ch].dev_id); | 1893 | dma_chan[ch].dev_id); |
@@ -2014,8 +2007,9 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev) | |||
2014 | 2007 | ||
2015 | p = pdev->dev.platform_data; | 2008 | p = pdev->dev.platform_data; |
2016 | if (!p) { | 2009 | if (!p) { |
2017 | dev_err(&pdev->dev, "%s: System DMA initialized without" | 2010 | dev_err(&pdev->dev, |
2018 | "platform data\n", __func__); | 2011 | "%s: System DMA initialized without platform data\n", |
2012 | __func__); | ||
2019 | return -EINVAL; | 2013 | return -EINVAL; |
2020 | } | 2014 | } |
2021 | 2015 | ||
@@ -2090,8 +2084,8 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev) | |||
2090 | } | 2084 | } |
2091 | ret = setup_irq(dma_irq, &omap24xx_dma_irq); | 2085 | ret = setup_irq(dma_irq, &omap24xx_dma_irq); |
2092 | if (ret) { | 2086 | if (ret) { |
2093 | dev_err(&pdev->dev, "set_up failed for IRQ %d" | 2087 | dev_err(&pdev->dev, "set_up failed for IRQ %d for DMA (error %d)\n", |
2094 | "for DMA (error %d)\n", dma_irq, ret); | 2088 | dma_irq, ret); |
2095 | goto exit_dma_lch_fail; | 2089 | goto exit_dma_lch_fail; |
2096 | } | 2090 | } |
2097 | } | 2091 | } |
@@ -2099,8 +2093,7 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev) | |||
2099 | /* reserve dma channels 0 and 1 in high security devices */ | 2093 | /* reserve dma channels 0 and 1 in high security devices */ |
2100 | if (cpu_is_omap34xx() && | 2094 | if (cpu_is_omap34xx() && |
2101 | (omap_type() != OMAP2_DEVICE_TYPE_GP)) { | 2095 | (omap_type() != OMAP2_DEVICE_TYPE_GP)) { |
2102 | printk(KERN_INFO "Reserving DMA channels 0 and 1 for " | 2096 | pr_info("Reserving DMA channels 0 and 1 for HS ROM code\n"); |
2103 | "HS ROM code\n"); | ||
2104 | dma_chan[0].dev_id = 0; | 2097 | dma_chan[0].dev_id = 0; |
2105 | dma_chan[1].dev_id = 1; | 2098 | dma_chan[1].dev_id = 1; |
2106 | } | 2099 | } |
@@ -2108,8 +2101,8 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev) | |||
2108 | return 0; | 2101 | return 0; |
2109 | 2102 | ||
2110 | exit_dma_irq_fail: | 2103 | exit_dma_irq_fail: |
2111 | dev_err(&pdev->dev, "unable to request IRQ %d" | 2104 | dev_err(&pdev->dev, "unable to request IRQ %d for DMA (error %d)\n", |
2112 | "for DMA (error %d)\n", dma_irq, ret); | 2105 | dma_irq, ret); |
2113 | for (irq_rel = 0; irq_rel < ch; irq_rel++) { | 2106 | for (irq_rel = 0; irq_rel < ch; irq_rel++) { |
2114 | dma_irq = platform_get_irq(pdev, irq_rel); | 2107 | dma_irq = platform_get_irq(pdev, irq_rel); |
2115 | free_irq(dma_irq, (void *)(irq_rel + 1)); | 2108 | free_irq(dma_irq, (void *)(irq_rel + 1)); |