aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/mm
diff options
context:
space:
mode:
authorMarek Szyprowski <m.szyprowski@samsung.com>2013-02-08 04:54:48 -0500
committerMarek Szyprowski <m.szyprowski@samsung.com>2013-02-25 09:30:44 -0500
commitd589829107c5528164a9b7dfe50d0001780865ed (patch)
treeea20dc2f831a19940ed4473eb163c277b73b5115 /arch/arm/mm
parent60460abffc71523d65774f43ce1252972eeb0629 (diff)
ARM: DMA-mapping: fix memory leak in IOMMU dma-mapping implementation
This patch removes page_address() usage in IOMMU-aware dma-mapping implementation and replaced it with direct use of the cpu virtual address provided by the caller. page_address() returned incorrect address for pages remapped in atomic pool, what caused memory leak. Reported-by: Hiroshi Doyu <hdoyu@nvidia.com> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Hiroshi Doyu <hdoyu@nvidia.com>
Diffstat (limited to 'arch/arm/mm')
-rw-r--r--arch/arm/mm/dma-mapping.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 6e2511561c3e..c7e3759f16d3 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -1292,11 +1292,11 @@ err_mapping:
1292 return NULL; 1292 return NULL;
1293} 1293}
1294 1294
1295static void __iommu_free_atomic(struct device *dev, struct page **pages, 1295static void __iommu_free_atomic(struct device *dev, void *cpu_addr,
1296 dma_addr_t handle, size_t size) 1296 dma_addr_t handle, size_t size)
1297{ 1297{
1298 __iommu_remove_mapping(dev, handle, size); 1298 __iommu_remove_mapping(dev, handle, size);
1299 __free_from_pool(page_address(pages[0]), size); 1299 __free_from_pool(cpu_addr, size);
1300} 1300}
1301 1301
1302static void *arm_iommu_alloc_attrs(struct device *dev, size_t size, 1302static void *arm_iommu_alloc_attrs(struct device *dev, size_t size,
@@ -1379,7 +1379,7 @@ void arm_iommu_free_attrs(struct device *dev, size_t size, void *cpu_addr,
1379 } 1379 }
1380 1380
1381 if (__in_atomic_pool(cpu_addr, size)) { 1381 if (__in_atomic_pool(cpu_addr, size)) {
1382 __iommu_free_atomic(dev, pages, handle, size); 1382 __iommu_free_atomic(dev, cpu_addr, handle, size);
1383 return; 1383 return;
1384 } 1384 }
1385 1385